From nobody Fri Oct 18 06:20:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1719472288098277.0017872916786; Thu, 27 Jun 2024 00:11:28 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B6E36139E; Thu, 27 Jun 2024 03:11:26 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 47F2BC6B; Thu, 27 Jun 2024 03:11:09 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1C33BD83; Thu, 27 Jun 2024 03:11:06 -0400 (EDT) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D81DCD65 for ; Thu, 27 Jun 2024 03:10:57 -0400 (EDT) Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2ebec2f11b7so84186731fa.2 for ; Thu, 27 Jun 2024 00:10:57 -0700 (PDT) Received: from localhost.localdomain (163.red-95-127-40.staticip.rima-tde.net. [95.127.40.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424c82519bdsm52155165e9.13.2024.06.27.00.10.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 27 Jun 2024 00:10:55 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719472256; x=1720077056; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VMACaTJ7ceKy98vN0dAl3R2Aaxm14mffc3kVkXfuwRk=; b=UqBTCfD2LAujc5Y45VAWCissGg164Tet3BtCJfVIsH1qZNR1CODs7xDWrr7HjKEuV1 feflX5/1k+q2K7zAJmOfKrSV97Isn4Ms4AsBRHRjxd6otTT9UCoS5JabT/9OXQgB3yVR PvHxN6QiqUwMZqYVeIyQhHKENQWubRByjGX+pNmEyMSTIw+AqDtuGpUWY8z/lQA3X+xN fG/aloQGqF0mOcZ3ggEsJszQW8qk1R3Lkg38cx+i+JB3XceqXmByZCrpXu443wG7psDZ wMTyw4p9Z7OM9U3Fx30WhqnhlVfivcHQnZmj08CH4tbzuTkOg+f0QtPBgUkUUVXNaf6n hGrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719472256; x=1720077056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VMACaTJ7ceKy98vN0dAl3R2Aaxm14mffc3kVkXfuwRk=; b=MAJTFi2spSZsyeEovn3LEcFoUXub7yX+EzEPTgtejg0xTfUPTQhBO59o55aP7AytaX 1LI4L1jxMxu+5h5aBUlocWBrymR1pbqKexmVRNKltcEnpf4dsNGdnzqBgLXK2fO+DCQ0 IhfJextGf6cUzQVHGQbL/k10NPXLEUjogFuUEOvAD0e0hS66brgmgvs+NZRIjxh4RBXh QvdByEls0t5R/NqoigC7f5Mi23kxf4qkfPknGZuTbhaTnjW+QWDoHo8Y1NY53y63Aupf rq/7Z7jafzpCsmITxAz0wefEmhyrPLtkwXgtQVufnZUMsvRCRv5VPTUkXy5fuQQV9tO1 UUUg== X-Forwarded-Encrypted: i=1; AJvYcCX71LrAl13OiiD+C+cU2gPJR2HzPE/4DE/gYfNAAwUXgwF8XOu/LckktSPujLKvHrqYnjwxHXVKjShBNGuf2KXMKh1MMtYPKw== X-Gm-Message-State: AOJu0YxzHkMlIzRGR4bk59EgnXhOPu2axDAFymT2C9MfDB/K682Iv0T/ qa2eKa/+CrcdyAotIRAJiLnplGPQVmoCyoz4OxI+KDjRwKN5XRwfqNm39GXdWE4= X-Google-Smtp-Source: AGHT+IFQaxY7Rzvlk6/HeiEQJyNeUwjWgeSvzwoFLf/+d+DpsR4UxloF/xxwq8NSvyniNK8Wis3S6A== X-Received: by 2002:a2e:780a:0:b0:2ec:5a6e:777d with SMTP id 38308e7fff4ca-2ec5b39cdbamr66685641fa.51.1719472256315; Thu, 27 Jun 2024 00:10:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] hw/sd/sdcard: Deprecate support for spec v1.10 Date: Thu, 27 Jun 2024 09:10:37 +0200 Message-ID: <20240627071040.36190-2-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240627071040.36190-1-philmd@linaro.org> References: <20240627071040.36190-1-philmd@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: STRW3FDABVBJIWRKHEMAAEU6LRDUGB5N X-Message-ID-Hash: STRW3FDABVBJIWRKHEMAAEU6LRDUGB5N X-MailFrom: philmd@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , devel@lists.libvirt.org, Bin Meng , Sai Pavan Boddu , Joel Stanley X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1719472289507100001 Content-Type: text/plain; charset="utf-8" We use the v2.00 spec by default since commit 2f0939c234 ("sdcard: Add a 'spec_version' property, default to Spec v2.00"). Time to deprecate the v1.10 which doesn't bring much, and is not tested. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater --- docs/about/deprecated.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ff3da68208..02cdef14aa 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -362,6 +362,12 @@ recommending to switch to their stable counterparts: - "Zve64f" should be replaced with "zve64f" - "Zve64d" should be replaced with "zve64d" =20 +``-device sd-card,spec_version=3D1`` (since 9.1) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +SD physical layer specification v2.00 supersedes the v1.10 one. +v2.00 is the default since QEMU 3.0.0. + Block device options '''''''''''''''''''' =20 --=20 2.41.0 From nobody Fri Oct 18 06:20:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1719472308905535.0983784927054; Thu, 27 Jun 2024 00:11:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D7BBF137E; Thu, 27 Jun 2024 03:11:47 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 22FE113C1; Thu, 27 Jun 2024 03:11:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 83A5DC31; Thu, 27 Jun 2024 03:11:08 -0400 (EDT) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B08F7D48 for ; Thu, 27 Jun 2024 03:11:07 -0400 (EDT) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-424aa70fbc4so14564885e9.1 for ; Thu, 27 Jun 2024 00:11:07 -0700 (PDT) Received: from localhost.localdomain (163.red-95-127-40.staticip.rima-tde.net. [95.127.40.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42564b7b7a5sm12282925e9.24.2024.06.27.00.11.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 27 Jun 2024 00:11:05 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719472266; x=1720077066; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1BvAUzJDJRk95OJML/aybeF+xlz5tOaGkq6qYevEQMg=; b=L/FjOCyG8NioGZDKmsiTRNriwVKN9tNzgl0xtr1C6dN8DsOAyk8zaxBWpGDlCC72qZ KDcvHh/8/YIKJGUPteUGxAVSj8bB5/uE4leldr2rDZRK8gekZRmByWORESJyQpSvKJeZ LZdcSzjShGwWugnsg/QATD86OjYmOnMWEUSZjDBiONdXPpAnOYA+309kMAcCb126+tGV ivQawvDOwvWvSoKfSFVxz6TcBqRspeT/NDA2FSChCwHW8FVn6Vky15iopMgeoPjsqdw9 TSO38aOQ4AMTs8MyZtDdLHwKivsvnDSO2S7XStZ0QmqJU35IlnyrSaV3KJ4XO8Rf/9P5 iS0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719472266; x=1720077066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1BvAUzJDJRk95OJML/aybeF+xlz5tOaGkq6qYevEQMg=; b=H7WrxPytkYiDnvjp8zr96nmBzvW9/yXsIHAhcgKh/LOanwPinvmpdbB5XS5nHc+CKK 9+yfLSan+xYP3jr2rHe9MyMvS+qwIEXH4TQMAlO/ONyxyJijnafGylCBLzzWr38VejdG CoRK1qI3R1NKr45YSuP/98S8kgyBH+r4yiEAowcD3tfeYoQ8IalGLR8F+WGdyZRtmUkI rTznGaxD1alyO2kQ/feL+kzNDN5mPdxuQuJP4pZ3f+QGJW2ycpgaxgUMNQjqS5IteFwY nPaaAM80yYoLCsQDN2qokaGKuGsOtb06/UDPxQBZuMDBwE9AxQ2wshfW5CH3yawuRD5M 4Qvg== X-Forwarded-Encrypted: i=1; AJvYcCWq+sVPvfIiB3lgcWNcZcAX1wr1keMS2ndmIPmCW9QAjKCI7ZHNMEHtW7rWSmBL+5JItcLEobINLMTlegQrPoWqTIu23CArWg== X-Gm-Message-State: AOJu0YyeR5IBTn/TGEzg6zL/xRhsWjKv1fpK+Bo/bJ1O4q6VEj9JjcnB 9TnWcCZmJfske6j715C59RUTu/T8xikl9iDJao/fD1HvAL6BBaOwFePwifasFRA= X-Google-Smtp-Source: AGHT+IFuzwL9+Ud6NHoY1okbe19bVu2ehNQ2veeCej8S5qR6kvWCvUQnRFRIybf9+7CfNs1TB8TT7Q== X-Received: by 2002:a05:600c:3ac3:b0:424:9593:29e5 with SMTP id 5b1f17b1804b1-42495932ab4mr68789885e9.40.1719472266339; Thu, 27 Jun 2024 00:11:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/3] hw/sd/sdcard: Use spec v3.01 by default Date: Thu, 27 Jun 2024 09:10:38 +0200 Message-ID: <20240627071040.36190-3-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240627071040.36190-1-philmd@linaro.org> References: <20240627071040.36190-1-philmd@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: B2AYIYB4PVKJOIJBUBJ2JBFETCZYMRE5 X-Message-ID-Hash: B2AYIYB4PVKJOIJBUBJ2JBFETCZYMRE5 X-MailFrom: philmd@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , devel@lists.libvirt.org, Bin Meng , Sai Pavan Boddu , Joel Stanley X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1719472309584100001 Content-Type: text/plain; charset="utf-8" Recent SDHCI expect cards to support the v3.01 spec to negociate lower I/O voltage. Select it by default. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater --- hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index a48010cfc1..d0a1d5db18 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -2280,7 +2280,7 @@ static void sd_realize(DeviceState *dev, Error **errp) =20 static Property sd_properties[] =3D { DEFINE_PROP_UINT8("spec_version", SDState, - spec_version, SD_PHY_SPECv2_00_VERS), + spec_version, SD_PHY_SPECv3_01_VERS), DEFINE_PROP_DRIVE("drive", SDState, blk), /* We do not model the chip select pin, so allow the board to select * whether card should be in SSI or MMC/SD mode. It is also up to the --=20 2.41.0 From nobody Fri Oct 18 06:20:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 171947233099344.215151155896706; Thu, 27 Jun 2024 00:12:10 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D7E74D3A; Thu, 27 Jun 2024 03:12:09 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3907D13C6; Thu, 27 Jun 2024 03:11:39 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D2D25137F; Thu, 27 Jun 2024 03:11:34 -0400 (EDT) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B1CDE1365 for ; Thu, 27 Jun 2024 03:11:16 -0400 (EDT) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-424ad289912so12991365e9.2 for ; Thu, 27 Jun 2024 00:11:16 -0700 (PDT) Received: from localhost.localdomain (163.red-95-127-40.staticip.rima-tde.net. [95.127.40.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42564b7baa9sm12357225e9.22.2024.06.27.00.11.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 27 Jun 2024 00:11:14 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719472275; x=1720077075; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MqiVMmEkjN8Fbce556VJrgK/N9f2zTrZ51XC0SKKdOs=; b=th8xM042zE4Ve4EyRPGQHIUEG7MDy6x5gtgZsO7t27vmJeWZgc3FiMcgbK+XMCPMbz ZAQDSRq2I/+X8SMpKMQua4o4yS8ySajyg0YPGOiW+PfjuZPSQlMtHMjBSNa6r0aGOkdh MxRfyhqDcniXGiXxtloLLpR08NbhU54JrIaHzN7+vVLiMh8FXUPssf44CfnSV0n4luhd mMzRfTOw66cHOC0hf4ElTq0kInnanHpsrvDRuSCA92YDA38aTuhfNLDaeQkCd7FQg9co nvYRM5Mc/n6GRL0C2Vqkzt9GiLtX5IWhserwIGJyIzRDq8ZN3AVvQ7AmG8vlQWP5FxeJ 0hQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719472275; x=1720077075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MqiVMmEkjN8Fbce556VJrgK/N9f2zTrZ51XC0SKKdOs=; b=f1SbBr14guoGXZXbYlMGxBYLEpPBTmam5wutYl+tyj4Beau1FLuUPpOzB69ZtjnFxw syOpqHV+XWxBoUb66buy+5k4EOCKxT25d6PqpOhEx+0Rt9108XJbay2EkJGk70qsKad+ vURk4kCNsTjvSZDVcwMCNpT4Nuqdl8eCmhd+9EkQm40rpMEv1cMY818u9srk8e3TQMhl esadUQ5R3pJJDawUWpug7K25kzH24GvSPVM7nZP0ztGLXXPXvYMyfuyJ5C+hoCdhJ5E5 XRP27JpGGdGxxBo6eQmPBhTsAZzgvGhcs1+b+un0rOZzXb+US3wvvkkAwZ5rnbk0HAbE mndA== X-Forwarded-Encrypted: i=1; AJvYcCVCq8YyJNJIEPW3MDf+l16b+Uupj+bMq/CZO1keojW15cKRFyMRq+uj+b/SQNV8kp2IgwCXAkLticQvEDIYZHN144CXCk5WcA== X-Gm-Message-State: AOJu0YwRsh8sc7ZCrOwJZrVZ/tXtITldlk4ScyFk52WwwjyquoEm1PAg 6V1DglzPry1OJN/1ahS5+xBuZ6Zk5ENvGT3qMfH4lUuupyGbcBkzex5MSTzFaIw= X-Google-Smtp-Source: AGHT+IE7FxGYasAWUuBxHkZ8gDR0rNja73NcLQilBhDLG513Io6NpXHqyZjn3C23nBvscKrjRIFb5g== X-Received: by 2002:a05:600c:434b:b0:424:abd7:2321 with SMTP id 5b1f17b1804b1-424abd72412mr35969995e9.12.1719472275489; Thu, 27 Jun 2024 00:11:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-10.0 3/3] hw/sd/sdcard: Remove support for spec v1.10 Date: Thu, 27 Jun 2024 09:10:39 +0200 Message-ID: <20240627071040.36190-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240627071040.36190-1-philmd@linaro.org> References: <20240627071040.36190-1-philmd@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: THH6RDDQA3PSJI2IWFODMSLQXD5OBDI5 X-Message-ID-Hash: THH6RDDQA3PSJI2IWFODMSLQXD5OBDI5 X-MailFrom: philmd@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , devel@lists.libvirt.org, Bin Meng , Sai Pavan Boddu , Joel Stanley X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1719472331704100005 Content-Type: text/plain; charset="utf-8" Support for spec v1.10 was deprecated in QEMU v9.1. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 5 +++++ include/hw/sd/sd.h | 1 - hw/sd/sd.c | 12 ++---------- 4 files changed, 7 insertions(+), 17 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 02cdef14aa..ff3da68208 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -362,12 +362,6 @@ recommending to switch to their stable counterparts: - "Zve64f" should be replaced with "zve64f" - "Zve64d" should be replaced with "zve64d" =20 -``-device sd-card,spec_version=3D1`` (since 9.1) -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - -SD physical layer specification v2.00 supersedes the v1.10 one. -v2.00 is the default since QEMU 3.0.0. - Block device options '''''''''''''''''''' =20 diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index fc7b28e637..dfe04b0555 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -1056,6 +1056,11 @@ by using ``-machine graphics=3Doff``. =20 The 'pvrdma' device and the whole RDMA subsystem have been removed. =20 +``-device sd-card,spec_version=3D1`` (since 10.0) +''''''''''''''''''''''''''''''''''''''''''''''' + +SD physical layer specification v2.00 supersedes the v1.10 one. + Related binaries ---------------- =20 diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index 2c8748fb9b..362e149360 100644 --- a/include/hw/sd/sd.h +++ b/include/hw/sd/sd.h @@ -56,7 +56,6 @@ #define AKE_SEQ_ERROR (1 << 3) =20 enum SDPhySpecificationVersion { - SD_PHY_SPECv1_10_VERS =3D 1, SD_PHY_SPECv2_00_VERS =3D 2, SD_PHY_SPECv3_01_VERS =3D 3, }; diff --git a/hw/sd/sd.c b/hw/sd/sd.c index d0a1d5db18..37a6a989ee 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -168,7 +168,6 @@ static bool sd_is_spi(SDState *sd) static const char *sd_version_str(enum SDPhySpecificationVersion version) { static const char *sdphy_version[] =3D { - [SD_PHY_SPECv1_10_VERS] =3D "v1.10", [SD_PHY_SPECv2_00_VERS] =3D "v2.00", [SD_PHY_SPECv3_01_VERS] =3D "v3.01", }; @@ -371,11 +370,7 @@ static void sd_set_ocr(SDState *sd) static void sd_set_scr(SDState *sd) { sd->scr[0] =3D 0 << 4; /* SCR structure version 1.0 */ - if (sd->spec_version =3D=3D SD_PHY_SPECv1_10_VERS) { - sd->scr[0] |=3D 1; /* Spec Version 1.10 */ - } else { - sd->scr[0] |=3D 2; /* Spec Version 2.00 or Version 3.0X */ - } + sd->scr[0] |=3D 2; /* Spec Version 2.00 or Version 3.0X */ sd->scr[1] =3D (2 << 4) /* SDSC Card (Security Version 1.01) */ | 0b0101; /* 1-bit or 4-bit width bus modes */ sd->scr[2] =3D 0x00; /* Extended Security is not supported. */ @@ -1241,9 +1236,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, S= DRequest req) break; =20 case 8: /* CMD8: SEND_IF_COND */ - if (sd->spec_version < SD_PHY_SPECv2_00_VERS) { - break; - } if (sd->state !=3D sd_idle_state) { break; } @@ -2231,7 +2223,7 @@ static void sd_realize(DeviceState *dev, Error **errp) int ret; =20 switch (sd->spec_version) { - case SD_PHY_SPECv1_10_VERS + case SD_PHY_SPECv2_00_VERS ... SD_PHY_SPECv3_01_VERS: break; default: --=20 2.41.0