From nobody Mon Sep 16 19:19:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=nutanix.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 171925043537917.20251654585286; Mon, 24 Jun 2024 10:33:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 48C67139D; Mon, 24 Jun 2024 13:33:54 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 678B413A3; Mon, 24 Jun 2024 13:32:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C5F02C6B; Mon, 24 Jun 2024 13:26:59 -0400 (EDT) Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com [148.163.155.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AF3AF10F5 for ; Mon, 24 Jun 2024 13:26:58 -0400 (EDT) Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45OBobxe025188; Mon, 24 Jun 2024 10:26:58 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 3ywwxcktyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jun 2024 10:26:57 -0700 (PDT) Received: from LV8PR02MB10287.namprd02.prod.outlook.com (2603:10b6:408:1fa::10) by BY5PR02MB6769.namprd02.prod.outlook.com (2603:10b6:a03:207::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.30; Mon, 24 Jun 2024 17:26:55 +0000 Received: from LV8PR02MB10287.namprd02.prod.outlook.com ([fe80::b769:6234:fd94:5054]) by LV8PR02MB10287.namprd02.prod.outlook.com ([fe80::b769:6234:fd94:5054%3]) with mapi id 15.20.7698.025; Mon, 24 Jun 2024 17:26:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=proofpoint20171006; bh=Qpm197E4zfgDI hJzi5LwEMoh3TH4rsMWgY+Iw/xzC/o=; b=tQAb5LUh53ih4azxTRwB34OGcoh1D rXJcQR8fjBkKgCtkIJKFD7ZvHJA5mr17tR4MEPM0rLq4/9faQbUiAy7cEnQG8zp3 zuvY1ng52iIhNvZ98V0TQkUNzRD7btz3+DHS46PubUwAg35wUHTbbmkjG5KLhi/f 2kuWz1+NKyPYf3neJvORRJYlKNKvQ9Xb4lD7kD4nG79gYX0XrFm0zIUS+FoadgYT wsVSzy5qy1n6U6zMLJ9DUhVSYgVjJfc1TmLO99zCXCrJrRo6LbWLLZSqp60qOhbU TTl2BBTv7LyVpOd0wI3fh5t2ixTVeOQF7hdCdr5ejoZb1o2bgVq7XvCRw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D1pZFgOrxQ9xk9jQ4NYuSdqQ0AiW5F9F7twInJUXusDdykUbnGJGKipcp55hoHk/sVb2xh9o/t63II+9/WQ6WdwkzkhzlTq/FCuppaPnHrfoINmHvDgrjIh23ThHFzBrDkMt6TIJ8LjKlsukMMg/ANnZVdGtf7hz2cJBk6K1S4sJkOVL+4QZL2GzzlpWYGNBXsTGlnxBRaKj+LOsM0jGbF7UYc8/AoMvOVZ9k0X0kJQ/LphtF1yQzBPy3s6OPb2SWT5rOOdQuCbQz/uqrGJ2wYX5qIAgk3Q316BI7Ct56x0W8JT0W59PXXHZx22A6ZqS8FL6M3KJjvEAGRUFBhGcHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qpm197E4zfgDIhJzi5LwEMoh3TH4rsMWgY+Iw/xzC/o=; b=PX/xud14Tuz95WThNS/3Io9XAHXcTsoj1Aez1xlGQNr8HCqvkjb5hOLjhd4lC1+UA6yb/MoyQUtNvML7TREYLorY3q5QCWc9lVBjNcx+A0I4QT1HSRtHUJgkCFUk4d3qn+reLKZaB/4XYb6edZ7187IvfhRm6xknop97Loerd8qND/Jgj0TJxmIkzD9NuELmHRZlAnHudc4tAN3DWraqorH+gnjOTlN4DSkpi5R4MD5sE4aK0azZ6LaKGNrX/7tRToVBTYPlVW7+6EnggfXF+QF+dUshwvVhUZGA6fqtG9BFFI3BcEcyhTMd1rwNDWvujDA+7eVqjMJ+yWjuAMqRfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qpm197E4zfgDIhJzi5LwEMoh3TH4rsMWgY+Iw/xzC/o=; b=K5M0peAa6wFAW6V16aF6Uhqpck11htKkSzCPaeTv6KXuobrVtz7Zl4V+ZKpBb/JGQILz7WvKNaG08U0FOvPeeUV94087p1Hzp/x8e6AJGoi3eSqfohr0bEmmOZI1IXNxZRbs6TBrpzeeN/77o0ozqqoTxtKs1kDuA62eq2KnZ11P8BEToi8S32nS3F6F+w3DFaMNBGzLa9uJSswCzyvVaQsvU9sLWD8BZmflS3XDd53SDSBtvvvRVE4zSzzMJCUwE540M6q8M0UDgz8J5YSq2nav+nu+6ZpFyzbhubPUQtCAVbpVlnpF40d1pfZrkksIb7KfZS+pOy56VLJr7hirtQ== From: Jon Kohler To: devel@lists.libvirt.org Subject: [PATCH v2] qemu: add support for qemu switchover-ack Date: Mon, 24 Jun 2024 10:38:51 -0700 Message-ID: <20240624173855.3798035-1-jon@nutanix.com> X-Mailer: git-send-email 2.43.0 X-ClientProxiedBy: SJ0PR05CA0151.namprd05.prod.outlook.com (2603:10b6:a03:339::6) To LV8PR02MB10287.namprd02.prod.outlook.com (2603:10b6:408:1fa::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR02MB10287:EE_|BY5PR02MB6769:EE_ X-MS-Office365-Filtering-Correlation-Id: b5e4c8a8-eb1b-407f-96c4-08dc9472d7d5 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|1800799021|52116011|366013|376011|38350700011; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?A6f9THG/mXU0AEF5wss3eKPPwzhtlnCjc497OISb/SiIi2xKk8L6XQOlyHGm?= =?us-ascii?Q?gTCvMMbLGZuJVt5QnWYCMrqNxmGl9TpESOf5ytsJLamPs6b544B3MM8Vytes?= =?us-ascii?Q?7LbjM5SjGvF5CuJh8L580pKlsv/o2HZ6XxKT4uK0KW0FGBSLCXieoF0QXUo+?= =?us-ascii?Q?kxGh70TiQCNGu+vjbHfqUg8gR3ycQQDH19OGJsjoSwwL6r0PvAUSh80R6R89?= =?us-ascii?Q?M8Hc8ze5eaxQRkXgVPZ+AHvW8eeaObVH5jj2jFGXm9jzcjtUY8n4dqipDHR1?= =?us-ascii?Q?GE5MIxnD00oi/NKBxQVssGlD34BCmNwhmnTdsHzqC8MP808q3e8myHpPrYVz?= =?us-ascii?Q?86lvLGWdfjuksekhs0GoaZy41/JbxSkFgramqAnzePgEuig5/jI67yEslDxK?= =?us-ascii?Q?OV4t555MKA0W3Y1a4WVRLQi/BDpRINT/C3MeHPKjWTYi6KNZPGKIk3Zlo9Mt?= =?us-ascii?Q?vvo6jMDkRnKvVrca3c27p31OE9OBc/peaQ3wC8TAuK2rWxRThLSUJepJN/me?= =?us-ascii?Q?t1HVsdFXEBuS/7+wT/2o+1SUVMNt9wK+WvcCKxzDOrZ8sll2nWSwXFH3193z?= =?us-ascii?Q?7vOGAkFXTfR9BdfaPLZxEb11ZIMcD6MxPWvypOcqSZWfiwx/Yc+qoKehzbfh?= =?us-ascii?Q?VhM8XBimWOrVZHtBAQPcDmlm0/cTWIX3htebxP/ZoqbN5HpmfpStDV1ThHYN?= =?us-ascii?Q?9EgrR2tOAVcbLLCzS/nl9NZmxpvBV5X6VmtRseKS2hRM1aIM6u23kaGVxKws?= =?us-ascii?Q?UOab5lDtS4csaPR5BoLfgZeLw8ynY65AZoNYbwEgEiOH7TWtTdCGhGA0JClF?= =?us-ascii?Q?JdZ8qlJekUbT6lv74oS7rVQuF3GA/jEq+gU8QkFO+bAuMtx7mM9klyOSlhf3?= =?us-ascii?Q?6qg9XFQUjgRvWmabqgiSGfzAv0AOVAzdech5hRw4fWHO6Vui7fmEnI80C/8Y?= =?us-ascii?Q?W8S3RVzFSWvXRISYGwyXwNECuCx0BPp13x578c/uI9LS/vs4WHU2/gxKoVCB?= =?us-ascii?Q?KqI+K+jMALdmB9+6qlXt1Gt+rj0fyKRbleCmFiRzkc8ByXQdSTS/duPJelwX?= =?us-ascii?Q?IFJ4oWQpRnSjpLICfMrJdvS2B8/b47Xgu1qcudule67OFzg6xawAzbNw1vvu?= =?us-ascii?Q?YgUOxi3Ni1wfInR+Ma8fbkomrtekqNVdGZQIm+9FPRWM3LFSFgP0GIVdTrrf?= =?us-ascii?Q?fUIblF6gsONYZ+7IoBsvtMZrmf1QBRkZ7oUxRFGvizQnHhZeeCvu86mgYwPn?= =?us-ascii?Q?kO6x5XrbB2W706ITVIHuMFUMnVFr5LIDbKT0HDqhKiXpgQVKU5fhcfdopwbH?= =?us-ascii?Q?Eibqf3ZqrtWqLggTQiIoPsx3?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR02MB10287.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230037)(1800799021)(52116011)(366013)(376011)(38350700011);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nz6ltNQfiwCRvEms5n3ml6vD51wuPJbUM4GggA88LqUNfrMEkAN+lRLMKIWQ?= =?us-ascii?Q?EGvu469PyVqcTDLoKou71w6Y8NPHjxb5QJOFA1sEoTTG6yPgfAo4S41b5fTr?= =?us-ascii?Q?QwxT5PRiAEqojXuPd5areLQpFHbxCh5JvUDh80eDRsQZMmywKB83k9pX7Mma?= =?us-ascii?Q?U8qEpNHh+43iHRudruTcQepw0EF/wi7W6S5hjQE5Yc+Q/YoAPy8W4AB9hmOj?= =?us-ascii?Q?WrxWqbx4rFHsxw6/oHBC0QFM26hUVfrbhLVNijVKmOTepdo/r32vwMtNkzjk?= =?us-ascii?Q?1labGLAG/AFBuSYPplRXJF6qUYl++j5Rx8q/eOLnnw+XmTMYeD+O7DkFcuPO?= =?us-ascii?Q?p0Q9pwyrfhhhcA3mD/Qz8Wh2XVmd3HTXs37hUfuf8w4tkFwgvdntwPRJsw4h?= =?us-ascii?Q?8PxrJszcVnJwR89BfZA9TC5zuIOwnxd2xsX1c4K5TTQ4rzYPoTXnYPIaDw/c?= =?us-ascii?Q?ffUoT5TC4KKLZ7TjefT0RFxxLGHLwvTEcefUmwof2NIyqFdCEtCqPzXuO931?= =?us-ascii?Q?pzbZ7QAyhPviEVtdjxByOGX9NEEf8vhh+3vpIffY9tf/4wLdtssgzDB5HFfQ?= =?us-ascii?Q?o8RuUzV4oCgwghta177XlC8vAGgFVTW7sLi1wmXz+Rb/XsR5ZWIPWyRgCOmB?= =?us-ascii?Q?9xEz13kFGjTfV40bZhDSMuqJYw8cxQhzlxitadh0cZRZC47b8F/DzVGETsiX?= =?us-ascii?Q?D4B/VJRE9HhzEhPDJ8qxpf5uwXsf8kTNg/NthCK8dGM9qsdV8FCjOIw3YmuW?= =?us-ascii?Q?fQs1FT5XjgycvOSECaIwm5jnzEknOG5P8DZSocxxJjUNAWs8S0IlUzn16vGj?= =?us-ascii?Q?pbtRTgEHqVBCYiSOox2B1ePFWH0GOoDqTFEBCPBWMK3xt+AwL421NRooY0XF?= =?us-ascii?Q?VZ3C49050On6fH7/a7kHykfZUBwoyB9JMJoqZKfxBQxykG4TS8OsumOhP7DD?= =?us-ascii?Q?2T0D6fCXy0v4hiSDa+/t3/+I9E3hrSgbmS6c7nvCGMEEqROzaAx8WX15x4jl?= =?us-ascii?Q?/wM8kQd9yfA2w5UIy8Rt3dtT5LxjcW+E8jUG9xzlvZMCYBAaWdUIV7hObM5K?= =?us-ascii?Q?an17FReSHL1pDne+AMBWk7f0lFTnF6EwWaU3YsI11y0fzaeosUpiRC67d2eh?= =?us-ascii?Q?sC3/JIU1ei2AvNzUT2beNZbIa6lWHoHk4yK/SA57d2FrzDW/WQnmYZal+U9X?= =?us-ascii?Q?lRGExywqO8N0SzLy9aqDo38IzYRJ9GE2C0GGBKFeUi7mWSXctb+UWpezmSwy?= =?us-ascii?Q?GuYf+Us8ng0t/Bgw+/Zex2+tn0Qp+HwfaQcrJE2Prh4kTi1qB8vpwMWFqQfE?= =?us-ascii?Q?Bl2EcmoZVVZ2pc6/22MaTLI6rw6LDw6J+myQOsbT2i1Wrce8Surd7UX3nVP+?= =?us-ascii?Q?pUtaV3QX+OXvP1QB7TDR+jN2OpgP7JY1tZDBNaVXqcxzVieU2RCddT6UHtl0?= =?us-ascii?Q?RTxVEC23zQym7LyPhOS4wA/b5aGxkBI68jwwHesY6jAVImYcHYi87u5xADz9?= =?us-ascii?Q?5QbGozH0RHcCGR5V4qMSS+lkpti2puV5iiakR+UELEnyghi55a+vutNiOr6h?= =?us-ascii?Q?yHYWy9VFwIxT81cDp2Km6nEs7RtP27qCRSE426xCUnwJl79Hk5gvEbAEX/0K?= =?us-ascii?Q?Zw=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5e4c8a8-eb1b-407f-96c4-08dc9472d7d5 X-MS-Exchange-CrossTenant-AuthSource: LV8PR02MB10287.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2024 17:26:54.9221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YpJXLdU9vOdSnamYXW6NgEXx3l9LnYrLViYCiyFuQVjD0gpPpj7yw+Zyro96+4C66lh8d8ALyFK0tfAMb3KizeUpzLJ6VDrmiPIkS87WEPs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6769 X-Proofpoint-ORIG-GUID: AuwlpJVJWtnILvIKQR1VTrr2yaFylHqq X-Proofpoint-GUID: AuwlpJVJWtnILvIKQR1VTrr2yaFylHqq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-24_13,2024-06-24_01,2024-05-17_01 X-Proofpoint-Spam-Reason: safe Content-Transfer-Encoding: quoted-printable X-MailFrom: jon@nutanix.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: PMONO45WNTR6HJIEH4F3CLPJPHUPXHL7 X-Message-ID-Hash: PMONO45WNTR6HJIEH4F3CLPJPHUPXHL7 X-Mailman-Approved-At: Mon, 24 Jun 2024 17:32:55 -0400 CC: Jon Kohler , Avihai Horon , Markus Armbruster , Peter Xu , YangHang Liu X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1719250437119100001 Content-Type: text/plain; charset="utf-8" Add plumbing for QEMU's switchover-ack migration capability, which helps lower the downtime during VFIO migrations. This capability is enabled by default as long as both the source and destination support it. Note: switchover-ack depends on the return path capability, so this may not be used when VIR_MIGRATE_TUNNELLED flag is set. Extensive details about the qemu switchover-ack implementation are available in the qemu series v6 cover letter [1] where the highlight is the extreme reduction in guest visible downtime. In addition to the original test results below, I saw a roughly ~20% reduction in downtime for VFIO VGPU devices at minimum. =3D=3D=3D Test results =3D=3D=3D The below table shows the downtime of two identical migrations. In the first migration swithcover ack is disabled and in the second it is enabled. The migrated VM is assigned with a mlx5 VFIO device which has 300MB of device data to be migrated. +----------------------+-----------------------+----------+ | Switchover ack | VFIO device data size | Downtime | +----------------------+-----------------------+----------+ | Disabled | 300MB | 1900ms | | Enabled | 300MB | 420ms | +----------------------+-----------------------+----------+ Switchover ack gives a roughly 4.5 times improvement in downtime. The 1480ms difference is time that is used for resource allocation for the VFIO device in the destination. Without switchover ack, this time is spent when the source VM is stopped and thus the downtime is much higher. With switchover ack, the time is spent when the source VM is still running. [1] https://patchwork.kernel.org/project/qemu-devel/cover/20230621111201.29= 729-1-avihaih@nvidia.com/ Signed-off-by: Jon Kohler Cc: Alex Williamson Cc: Avihai Horon Cc: Markus Armbruster Cc: Peter Xu Cc: YangHang Liu Reviewed-by: Jiri Denemark --- v1 - https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/2= XCWPYAUE7HUIMSAYYWAUUYGGZ6WYR53/ v1 -> v2: - Addressed comments to simplify approach (Daniel, Jiri) --- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 8 +++++++- src/qemu/qemu_migration_params.h | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.h b/src/qemu/qemu_migration.h index ed62fd4a91..cd89e100e1 100644 --- a/src/qemu/qemu_migration.h +++ b/src/qemu/qemu_migration.h @@ -62,6 +62,7 @@ VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES | \ VIR_MIGRATE_POSTCOPY_RESUME | \ VIR_MIGRATE_ZEROCOPY | \ + VIR_MIGRATE_SWITCHOVER_ACK | \ 0) =20 /* All supported migration parameters and their types. */ diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_par= ams.c index 48f8657f71..9593b6ba65 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -105,6 +105,7 @@ VIR_ENUM_IMPL(qemuMigrationCapability, "return-path", "zero-copy-send", "postcopy-preempt", + "switchover-ack", ); =20 =20 @@ -138,7 +139,7 @@ struct _qemuMigrationParamsAlwaysOnItem { typedef struct _qemuMigrationParamsFlagMapItem qemuMigrationParamsFlagMapI= tem; struct _qemuMigrationParamsFlagMapItem { /* Describes what to do with the capability if @flag is found. - * When se to QEMU_MIGRATION_FLAG_REQUIRED, the capability will be + * When set to QEMU_MIGRATION_FLAG_REQUIRED, the capability will be * enabled iff the specified migration flag is enabled. On the other h= and * QEMU_MIGRATION_FLAG_FORBIDDEN will enable the capability as long as * the specified migration flag is not enabled. */ @@ -215,6 +216,11 @@ static const qemuMigrationParamsFlagMapItem qemuMigrat= ionParamsFlagMap[] =3D { .flag =3D VIR_MIGRATE_ZEROCOPY, .cap =3D QEMU_MIGRATION_CAP_ZERO_COPY_SEND, .party =3D QEMU_MIGRATION_SOURCE}, + + {.match =3D QEMU_MIGRATION_FLAG_FORBIDDEN, + .flag =3D VIR_MIGRATE_TUNNELLED, + .cap =3D QEMU_MIGRATION_CAP_SWITCHOVER_ACK, + .party =3D QEMU_MIGRATION_SOURCE | QEMU_MIGRATION_DESTINATION}, }; =20 /* Translation from VIR_MIGRATE_PARAM_* typed parameters to diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_par= ams.h index 91bc6792cd..df67f1fb92 100644 --- a/src/qemu/qemu_migration_params.h +++ b/src/qemu/qemu_migration_params.h @@ -41,6 +41,7 @@ typedef enum { QEMU_MIGRATION_CAP_RETURN_PATH, QEMU_MIGRATION_CAP_ZERO_COPY_SEND, QEMU_MIGRATION_CAP_POSTCOPY_PREEMPT, + QEMU_MIGRATION_CAP_SWITCHOVER_ACK, =20 QEMU_MIGRATION_CAP_LAST } qemuMigrationCapability; --=20 2.43.0