From nobody Fri Oct 18 08:50:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=reject dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1718800254955223.05625703877206; Wed, 19 Jun 2024 05:30:54 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E136E121E; Wed, 19 Jun 2024 08:30:53 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id F28971253; Wed, 19 Jun 2024 08:29:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 808E2AE1; Wed, 19 Jun 2024 08:29:25 -0400 (EDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EC46EC68 for ; Wed, 19 Jun 2024 08:29:24 -0400 (EDT) Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JCTObk027829 for ; Wed, 19 Jun 2024 12:29:24 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yuyc4g01k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 19 Jun 2024 12:29:23 +0000 (GMT) Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45JCTNMa027819 for ; Wed, 19 Jun 2024 12:29:23 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yuyc4g01f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 12:29:23 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45JBgsjA019506; Wed, 19 Jun 2024 12:29:22 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ysnp1cfe6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 12:29:22 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45JCTIbf16384476 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2024 12:29:20 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3A7B20063; Wed, 19 Jun 2024 12:29:17 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D88FA2006A; Wed, 19 Jun 2024 12:29:17 +0000 (GMT) Received: from fiuczyvm.. (unknown [9.152.222.239]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Jun 2024 12:29:17 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:date:message-id:in-reply-to:references :content-transfer-encoding:mime-version; s=pp1; bh=aaMHmnv2UCPAe GuHq7GWCadMSyMQl0bMa9m+mQQUeuQ=; b=KB8zz7xZ4il1yWWCVu6VujO9RO9Wa jviqj51X1etDqYtvLccwuv27VYP7YH1ANtM/tKi8S6qbOTxiNtLLFaIzNOvAG/2B abZbJAQ2pck6Z1WgAA8UV2HiPNXXvys+PreOd+cryh2FDd/bj0nmWNZ4gtIb2Ay+ 1lT9tJ862OssomGsctLaqZCPfzrV52lnahU9IxqwLfiSSljS1pp21tLlaPq/1JpB 8FB4cKT0y9EfZIZ7e0oLeR9Od1HLiyPv5oZwdlJYgxQ5JirdyV10A8RuefwziSXx cS6FZ/Pp9rqqGRvkqbHsskq4v3bHBKyT1inmxsDmicVxChlr9MESngxyQ== From: Boris Fiuczynski To: devel@lists.libvirt.org Subject: [PATCH 3/4] nodedev: prevent invalid DASD node object creation Date: Wed, 19 Jun 2024 14:29:16 +0200 Message-ID: <20240619122917.45827-4-fiuczy@linux.ibm.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240619122917.45827-1-fiuczy@linux.ibm.com> References: <20240619122917.45827-1-fiuczy@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 0Pduen5DcJnMSQLWBO-mwGwJuIC4QA7h X-Proofpoint-ORIG-GUID: rjidEsRtbxJ5nfjzSFmZIMCLJaliJMuP X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 mlxlogscore=925 mlxscore=0 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190092 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CHK225NOYD7LCM77QGMB7CXT7VUBGZBA X-Message-ID-Hash: CHK225NOYD7LCM77QGMB7CXT7VUBGZBA X-MailFrom: fiuczy@linux.ibm.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: jjongsma@redhat.com, mhartmay@linux.ibm.com, mprivozn@redhat.com X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1718800255970100001 Content-Type: text/plain; charset="utf-8" Prevent the creation of a new DASD node object when the device does not exist. Resolves: https://issues.redhat.com/browse/RHEL-39497 Reviewed-by: Marc Hartmayer Signed-off-by: Boris Fiuczynski --- src/node_device/node_device_udev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_devi= ce_udev.c index c0e258fe9c..ad994ef0b2 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -958,6 +958,9 @@ udevProcessDASD(struct udev_device *device, =20 udevGetStringSysfsAttr(device, "device/uid", &storage->serial); =20 + if (!storage->serial) + return -1; + return udevProcessDisk(device, def); } =20 --=20 2.45.0