From nobody Mon Sep 16 19:06:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1718189719425390.803750907706; Wed, 12 Jun 2024 03:55:19 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 50AEDD78; Wed, 12 Jun 2024 06:55:18 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id DC2A9C90; Wed, 12 Jun 2024 06:55:02 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2B4F59CF; Wed, 12 Jun 2024 06:55:00 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B91D49CF for ; Wed, 12 Jun 2024 06:54:59 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-FcDtqdg0Mw6eadSgC3o5Fw-1; Wed, 12 Jun 2024 06:54:58 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3E9D21955D8E for ; Wed, 12 Jun 2024 10:54:57 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.115]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2F1CF300021B; Wed, 12 Jun 2024 10:54:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: *** X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718189699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CS0VkSzn2zwu1ARnVJPbvBUbxh6w6lbpJyAD8aj9Nqg=; b=jSJpLMzUEXprznpfmgjhWvWtIuvmenc5nsRumoKm4M3qrvwHE2iqrYRDrWnSycs1Ogp6Gh 0X14AlCHvcrSUD9ZgHNKvf58y0d52U1yGdfVhHgz46G35RLW6xMNTrij9ZmCteD8QuGK5l 6VXJ3Iyae9t/sQoL0Pww4Kzo1AnHUlQ= X-MC-Unique: FcDtqdg0Mw6eadSgC3o5Fw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH] tools: fix paths in PKI validation error messages Date: Wed, 12 Jun 2024 11:54:54 +0100 Message-ID: <20240612105454.1089115-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: POU4AX6KTGLRHHKPF6Y5VYMF6MOBRTLE X-Message-ID-Hash: POU4AX6KTGLRHHKPF6Y5VYMF6MOBRTLE X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1718189721300100001 Content-Type: text/plain; charset="utf-8" A couple of paths passed in the error messages, didnt match the paths that were actually being tested. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Pavel Hrdina --- tools/virt-pki-validate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virt-pki-validate.c b/tools/virt-pki-validate.c index 656f29fdc5..e693ffaed6 100644 --- a/tools/virt-pki-validate.c +++ b/tools/virt-pki-validate.c @@ -184,7 +184,7 @@ virPKIValidateIdentity(bool isServer, bool system, cons= t char *path) _("Checking system cert dir access"), 0, 0, 0755, _("The system cert dir %1$s must be accessible= to all users. As root, run: chown root.root; chmod 0755 %2$s"), - LIBVIRT_PKI_DIR, LIBVIRT_PKI_DIR); + LIBVIRT_CERT_DIR, LIBVIRT_CERT_DIR); =20 FILE_REQUIRE_EXISTS(scope, LIBVIRT_KEY_DIR, @@ -197,7 +197,7 @@ virPKIValidateIdentity(bool isServer, bool system, cons= t char *path) _("Checking system key dir access"), 0, 0, 0755, _("The system key dir %1$s must be accessible = to all users. As root, run: chown root.root; chmod 0755 %2$s"), - LIBVIRT_KEY_DIR, LIBVIRT_PKI_DIR); + LIBVIRT_KEY_DIR, LIBVIRT_KEY_DIR); } else if (path) { virNetTLSConfigCustomTrust(path, &cacert, --=20 2.45.1