From nobody Thu Sep 19 00:55:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1717772078013518.5513006766452; Fri, 7 Jun 2024 07:54:38 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4D5132691; Fri, 7 Jun 2024 10:54:36 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id A705A26A3; Fri, 7 Jun 2024 10:47:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5CA7025B5; Fri, 7 Jun 2024 10:47:17 -0400 (EDT) Received: from mx1.osci.io (polly.osci.io [8.43.85.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0BDD325D3 for ; Fri, 7 Jun 2024 10:44:54 -0400 (EDT) Received: by mx1.osci.io (Postfix, from userid 994) id ECCFE2254F; Fri, 7 Jun 2024 10:44:53 -0400 (EDT) Received: from mx3.osci.io (carla.osci.io [IPv6:2607:f0d0:1e02:35::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits)) (No client certificate requested) by mx1.osci.io (Postfix) with ESMTPS id 0E8762254B for ; Fri, 7 Jun 2024 10:44:46 -0400 (EDT) Received: by mx3.osci.io (Postfix, from userid 990) id 3BB2C30721DA; Fri, 7 Jun 2024 09:33:01 -0500 (CDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by mx3.osci.io (Postfix) with ESMTPS id 129BD30721D2 for ; Fri, 7 Jun 2024 09:33:00 -0500 (CDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-72aeA7BWPYWJ0BhiD243Hg-1; Fri, 07 Jun 2024 10:26:23 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C9DFD85A5B5 for ; Fri, 7 Jun 2024 14:26:22 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.39.193.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55923492BC6; Fri, 7 Jun 2024 14:26:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717770385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eo9d3bmZG8FVsPK25LHj1OvTAE7pwTBnxGWI89bOAaU=; b=L7RjAGWr71ISR/X6rMzOlKdKCS+PMSvCpBRQCouAetu96zqhGLjieY5LXYeLvqTNVdHnjs ZY6IwjvlefADWeyUHKvm2y0qube9N6iJcwSWluy3gizKPUD4LaUAnlUr97gp7+mxRR4Nu4 1duGcaPdkVvLh5pdxFqoEvtuXzQVKmI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717770517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eo9d3bmZG8FVsPK25LHj1OvTAE7pwTBnxGWI89bOAaU=; b=jAzXN7iIYFqS7E9Rs78r1buKNgnThAe5O40lG5PDmSNPsHH6i4GXobye1DfBTaUbejAzbO V8YGzg/LoVW7ZdP13YtgJ0Gnv8ZK/Gk/0+LcsN9XIdZ2zigRS9zIFsb0hLcIFRyVpZYQ0U HDCkV+7Os7Rk068vKDx4Z2HTRxUSsgg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717770648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eo9d3bmZG8FVsPK25LHj1OvTAE7pwTBnxGWI89bOAaU=; b=cRIsSIq9zsdXaK55qQhCNEqvsBZLOGt4ngYtpsKj4WA304cAuC9BrPo3+JudpGzcfYEx+K IMw/cYgom2okb39nlzYw2VmN7M3S76qaB/2ZF0/rcEPCNqCd7VV5P0Ylb9mP+674bw+tLJ YEgdyE/KRRqO5Ye5CRGTvMW0RYJqYxI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717770779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eo9d3bmZG8FVsPK25LHj1OvTAE7pwTBnxGWI89bOAaU=; b=RMcDowUur3La9Yr5XXCay4YLtu/0K3zo9CUrAyTaLhncvD36Wa2GatNwbVZY/5wcatdSVm eJH2dH784gxpeuMFWVySLiQuEzWlIA3u0drsEDmn6mq0McIuHcu8BcDMq9VvKafgPgnqnR LbqAhz/uau669QjXdEYCVie1tlaLtDA= X-MC-Unique: 72aeA7BWPYWJ0BhiD243Hg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 6/9] tools: drop unused --version argument Date: Fri, 7 Jun 2024 15:26:13 +0100 Message-ID: <20240607142616.749339-7-berrange@redhat.com> In-Reply-To: <20240607142616.749339-1-berrange@redhat.com> References: <20240607142616.749339-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZN7ETWC3ANJRTU7XL5TFAVL4CQ6UN5UN X-Message-ID-Hash: ZN7ETWC3ANJRTU7XL5TFAVL4CQ6UN5UN X-MailFrom: SRS0=RZ0v=NJ=redhat.com=berrange@osci.io X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (found 4 invalid signatures) X-ZM-MESSAGEID: 1717772078444100001 Content-Type: text/plain; charset="utf-8" These tools never supported passing an argument to --version, this is a copy+paste mistake from virsh, which did support an argument. Signed-off-by: Daniel P. Berrang=C3=A9 --- tools/virt-login-shell-helper.c | 2 +- tools/virt-pki-query-dn.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virt-login-shell-helper.c b/tools/virt-login-shell-helpe= r.c index 1627ba85e5..cb59b5dec0 100644 --- a/tools/virt-login-shell-helper.c +++ b/tools/virt-login-shell-helper.c @@ -180,7 +180,7 @@ main(int argc, char **argv) =20 struct option opt[] =3D { { "help", no_argument, NULL, 'h' }, - { "version", optional_argument, NULL, 'V' }, + { "version", no_argument, NULL, 'V' }, { NULL, 0, NULL, 0 }, }; if (virInitialize() < 0) { diff --git a/tools/virt-pki-query-dn.c b/tools/virt-pki-query-dn.c index c8196e32e3..5bf6717c4f 100644 --- a/tools/virt-pki-query-dn.c +++ b/tools/virt-pki-query-dn.c @@ -62,7 +62,7 @@ main(int argc, =20 struct option opt[] =3D { { "help", no_argument, NULL, 'h' }, - { "version", optional_argument, NULL, 'v' }, + { "version", no_argument, NULL, 'v' }, { NULL, 0, NULL, 0 }, }; =20 --=20 2.43.0