From nobody Fri Oct 18 06:22:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1717669302519102.05021519292859; Thu, 6 Jun 2024 03:21:42 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3B8572262; Thu, 6 Jun 2024 06:21:41 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id B7CC32236; Thu, 6 Jun 2024 06:21:04 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 56E872232; Thu, 6 Jun 2024 06:21:01 -0400 (EDT) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 67442222A for ; Thu, 6 Jun 2024 06:20:59 -0400 (EDT) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1f6ab88dfaeso6930015ad.2 for ; Thu, 06 Jun 2024 03:20:59 -0700 (PDT) Received: from localhost.localdomain ([49.47.195.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6bd75f873sm11106425ad.27.2024.06.06.03.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 03:20:57 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717669258; x=1718274058; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KCyyfdXprwuFZDtM5YqthS+PTz/yXxlmQ3f8plm3ua4=; b=UT1OznpU+FFY92K2HmhMLb0balRBfizB9jAcepZk/gBc0/3oJktL7F4LeNjZEeZP+x goMEWT+BwgysG4ig8qf7fj7A5gy+HeRkkX8MQoii6Gam+bsJDQqwKup97jh2iNZB0cBn fAuYX2DKeVkGypKYljWcNzLhTM2El92bIrVHHXliFQYpT1g5LBOl7xzBBfkK0SGQZX1F weImfmv37Y0SpDNJFEFA1jQ1VG/x+wS9Vun6vwc2meDSvnyapa4OVNHt4Gp7utk78Uoh 4XPd1FfdoUu85k/jdhqFp5xwfROD7tiDNo64EZD7RvEGE8mn7d4wgMGXu8P62XGceVhS hf5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717669258; x=1718274058; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KCyyfdXprwuFZDtM5YqthS+PTz/yXxlmQ3f8plm3ua4=; b=eUbR50M3ShqDHCMo5Q2Mgar7BY/tPIrzEsCDYwvq+orPKcAbkRcGpoE4U4sfXJdrJA wXY6BSk+gOn/xKBEdKFFjfJmAak/5/TX30DSDe++wg+rVUZVTUwmE6QdLok00dQQwujp KS9PWgFkaA8faoDlDquomCoZ9XCKOt96a8s7aXzktqINtEwsH9UmFEahmQ5iLz56DlFG ShUUwC5Z0UooLYXybbSrxpdWriIN17wmT61xAsE0yLV5rTg/sG6AXbLb+YVXZGjB1xLK IZqBj6kbTQhLJty1cmhv3MdQiG7+oVtkth2B6mwDgRtVGV5GNxwiSMgOwO2I3UQn+wcn yOOg== X-Gm-Message-State: AOJu0Yx4aNgrHQAvCj1QmO2BltX6412ULgkds9ObvMhwqPdwU763vAvI bcNiTg9JMgaabMEN4e+ZXAAG8Ic1H9MXFqwr0+9nV7V5kvvqOiVsfiER7A== X-Google-Smtp-Source: AGHT+IG6OIdKQByrr0z8kfEtH1JD2iyMXYWjzMGInE5owxdTAhwZiOtXtEbb+UfXbR4xker68sapGA== X-Received: by 2002:a17:903:230a:b0:1f2:f182:f616 with SMTP id d9443c01a7336-1f6a590183amr60654035ad.13.1717669257847; Thu, 06 Jun 2024 03:20:57 -0700 (PDT) From: Rayhan Faizel To: devel@lists.libvirt.org Subject: [PATCH] qemu_block: Validate number of hosts for iSCSI disk device Date: Thu, 6 Jun 2024 15:45:16 +0530 Message-Id: <20240606101516.587972-1-rayhan.faizel@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 42CLK6OORGTO4QAGTAHZQWSP252YOJTS X-Message-ID-Hash: 42CLK6OORGTO4QAGTAHZQWSP252YOJTS X-MailFrom: rayhan.faizel@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Rayhan Faizel X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1717669304507100001 Content-Type: text/plain; charset="utf-8" An iSCSI device with zero hosts will result in a segmentation fault. This p= atch adds a check for the number of hosts, which must be one in the case of iSCS= I. Minimal reproducing XML: MyGuest 4dea22b3-1d52-d8f3-2516-782e98ab3fa0 hvm 4096 Signed-off-by: Rayhan Faizel --- This crashing XML was detected by the WIP fuzzer which is being developed as part of Google Summer of Code 2024. src/qemu/qemu_block.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 738b72d7ea..d6cdf521c4 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -602,6 +602,12 @@ qemuBlockStorageSourceGetISCSIProps(virStorageSource *= src, * } */ =20 + if (src->nhosts !=3D 1) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("iSCSI protocol accepts only one host")); + return NULL; + } + target =3D g_strdup(src->path); =20 /* Separate the target and lun */ --=20 2.34.1