From nobody Mon Sep 16 19:11:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1717585499264419.3579639662415; Wed, 5 Jun 2024 04:04:59 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 456231E68; Wed, 5 Jun 2024 07:04:58 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D81041EED; Wed, 5 Jun 2024 07:04:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 50D2B1EAD; Wed, 5 Jun 2024 07:04:11 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 878241EAF for ; Wed, 5 Jun 2024 07:03:52 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-xbJgR6TUOca1WJ3_oiVqRg-1; Wed, 05 Jun 2024 07:03:50 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 143091954233 for ; Wed, 5 Jun 2024 11:03:50 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.39.193.183]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A8C101955DC0; Wed, 5 Jun 2024 11:03:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: ** X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717585432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8MKIRdBj9wBs9kaACPIMsbrTBTNlQXazrNcjeGatUd4=; b=H68BzDIM/orIF9UxVQRLRQhotwZBqFW/4orAtj2GGZHWs6UM4XsIuwJWZ0Urs0K0F+14OR RB19RRPEpdz/zTL2pYbPRKdJo9tVdf1FVyl1c0rbtwe9FotDK0VFkWKv4ch0VbZBIRKzw/ 9QemxtIkzDO43WizBukBvR1pJWUbqAA= X-MC-Unique: xbJgR6TUOca1WJ3_oiVqRg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH] rpm: fix setting of VIR_TEST_DEBUG Date: Wed, 5 Jun 2024 12:03:46 +0100 Message-ID: <20240605110346.336038-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JUIUJBWT6LPEPYLSGWFOZU24ZCQYDHXG X-Message-ID-Hash: JUIUJBWT6LPEPYLSGWFOZU24ZCQYDHXG X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1717585500068100001 Content-Type: text/plain; charset="utf-8" The %meson_test macro expands to have a newline at the start, so rather than expanding to VIR_TEST_DEBUG=3D1 meson test .... we get VIR_TEST_DEBUG=3D1 meson test .... which has no effect, since VIR_TEST_DEBUG isn't exported. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- libvirt.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5ca7b95e6c..0f3c882f05 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1592,7 +1592,8 @@ rm -rf $RPM_BUILD_ROOT%{mingw64_libexecdir}/libvirt-g= uests.sh %if %{with_native} # Building on slow archs, like emulated s390x in Fedora copr, requires # raising the test timeout -VIR_TEST_DEBUG=3D1 %meson_test --no-suite syntax-check --timeout-multiplie= r 10 +export VIR_TEST_DEBUG=3D1 +%meson_test --no-suite syntax-check --timeout-multiplier 10 %endif =20 %define libvirt_rpmstatedir %{_localstatedir}/lib/rpm-state/libvirt --=20 2.45.1