From nobody Sat Nov 23 16:29:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715848061485163.1163861058044; Thu, 16 May 2024 01:27:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5D11D18F5; Thu, 16 May 2024 04:27:40 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 80D23192B; Thu, 16 May 2024 04:25:08 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 94E9E1A15; Thu, 16 May 2024 04:25:00 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D55731A15 for ; Thu, 16 May 2024 04:24:38 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-rVNhZIGtNKu4u2AHZ_I1Rw-1; Thu, 16 May 2024 04:24:26 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70D4885A58C for ; Thu, 16 May 2024 08:24:26 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F245940C6EB7 for ; Thu, 16 May 2024 08:24:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715847878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U7lwG+SRJsYZX2rGHn5fZQqQETp61Pex6+lDIciVl1s=; b=TC6pSFzQo+05Ss2dR8hZhUGp5xAjTSy7R1QQKeDPVl7jVLrQrKjLXPpIw4tO3xfj8Ki3Yi nsS0xelb/puBqxdf/HFQqXnq0no6YSRLj5VnOUWMMq7tmfKQosOQVDvdGqa2b+HP1dURfR OBE06dH7tlH/gClW4qx3RuKxoovR5Ic= X-MC-Unique: rVNhZIGtNKu4u2AHZ_I1Rw-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [PATCH 2/4] rpm: Only Recommend ssh-proxy Date: Thu, 16 May 2024 10:24:20 +0200 Message-ID: <20240516082422.332693-3-abologna@redhat.com> In-Reply-To: <20240516082422.332693-1-abologna@redhat.com> References: <20240516082422.332693-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ODDADJY4ZPKEBHOORSYSJTRD6KONXKPY X-Message-ID-Hash: ODDADJY4ZPKEBHOORSYSJTRD6KONXKPY X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1715848062450100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The way things are implemented, installing the package not only makes the feature available but also enables it. Some admins might not want that to happen, so let's make the dependency a weak one to offer them a way out. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5cb19fa433..329b923e8f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -905,7 +905,7 @@ Requires: libvirt-daemon-driver-nwfilter =3D %{version}= -%{release} Requires: libvirt-daemon-driver-secret =3D %{version}-%{release} Requires: libvirt-daemon-driver-storage =3D %{version}-%{release} %if %{with_ssh_proxy} -Requires: libvirt-ssh-proxy =3D %{version}-%{release} +Recommends: libvirt-ssh-proxy =3D %{version}-%{release} %endif Requires: qemu =20 @@ -936,7 +936,7 @@ Requires: libvirt-daemon-driver-nwfilter =3D %{version}= -%{release} Requires: libvirt-daemon-driver-secret =3D %{version}-%{release} Requires: libvirt-daemon-driver-storage =3D %{version}-%{release} %if %{with_ssh_proxy} -Requires: libvirt-ssh-proxy =3D %{version}-%{release} +Recommends: libvirt-ssh-proxy =3D %{version}-%{release} %endif Requires: qemu-kvm =20 --=20 2.45.0