From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090412503548.7043646614833; Tue, 7 May 2024 07:00:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id EA5F41C93; Tue, 7 May 2024 10:00:10 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 12A821BA7; Tue, 7 May 2024 09:59:16 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 782BF1AD7; Tue, 7 May 2024 09:59:12 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D1A661ACF for ; Tue, 7 May 2024 09:59:11 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-6qZjuQHhMjqKQXoaR2CvIA-1; Tue, 07 May 2024 09:59:09 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 883BF185A783 for ; Tue, 7 May 2024 13:59:09 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id E003B1C060AE; Tue, 7 May 2024 13:59:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 6qZjuQHhMjqKQXoaR2CvIA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 01/12] scripts/rpcgen: skip tests if tirpc is not present Date: Tue, 7 May 2024 14:58:56 +0100 Message-ID: <20240507135907.1104087-2-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: TNVDU3JOAJZX6MYJPPTRDRN5JLESNYLP X-Message-ID-Hash: TNVDU3JOAJZX6MYJPPTRDRN5JLESNYLP X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090414450100001 This skips building tests which rely on tirpc when it is not present. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- scripts/rpcgen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/rpcgen/meson.build b/scripts/rpcgen/meson.build index 7fb32c0f91..bce652c7ad 100644 --- a/scripts/rpcgen/meson.build +++ b/scripts/rpcgen/meson.build @@ -1,6 +1,6 @@ subdir('rpcgen') =20 -if tests_enabled[0] +if tests_enabled[0] and xdr_dep.found() subdir('tests') =20 if pytest_prog.found() and host_machine.system() !=3D 'darwin' --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090525276384.0648455877532; Tue, 7 May 2024 07:02:05 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1550C1D42; Tue, 7 May 2024 10:02:04 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D05191DE8; Tue, 7 May 2024 09:59:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CAEFB1AD7; Tue, 7 May 2024 09:59:13 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E1EDD1ACB for ; Tue, 7 May 2024 09:59:12 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-iwa9bR7dMUKJrLakno3B6Q-1; Tue, 07 May 2024 09:59:10 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AC38B8015D7 for ; Tue, 7 May 2024 13:59:10 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id E957E1C060AE; Tue, 7 May 2024 13:59:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: iwa9bR7dMUKJrLakno3B6Q-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 02/12] tests: fix tests when test driver is disabled Date: Tue, 7 May 2024 14:58:57 +0100 Message-ID: <20240507135907.1104087-3-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: YJFSXMD7AWJ3PDGLNOXRSK33X4Q6C4Z5 X-Message-ID-Hash: YJFSXMD7AWJ3PDGLNOXRSK33X4Q6C4Z5 X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090528132100001 Various tests try to open a connection to 'test:///default' and must be skipped when the test driver is disabled. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tests/fchosttest.c | 9 ++++++--- tests/meson.build | 37 ++++++++++++++++++++++++------------- 2 files changed, 30 insertions(+), 16 deletions(-) diff --git a/tests/fchosttest.c b/tests/fchosttest.c index d050458a58..14f9975157 100644 --- a/tests/fchosttest.c +++ b/tests/fchosttest.c @@ -33,6 +33,7 @@ static char *fchost_prefix; #define TEST_FC_HOST_NUM 5 #define TEST_FC_HOST_NUM_NO_FAB 6 =20 +#ifdef WITH_TEST /* virNodeDeviceCreateXML using "" to find the vport capable HBA */ static const char test7_xml[] =3D "" @@ -85,7 +86,7 @@ static const char test11_xml[] =3D " /dev/disk/by-path" " " ""; - +#endif /* WITH_TEST */ =20 /* Test virIsVHBACapable */ static int @@ -222,7 +223,7 @@ test6(const void *data G_GNUC_UNUSED) } =20 =20 - +#ifdef WITH_TEST /* Test manageVHBAByNodeDevice * - Test both virNodeDeviceCreateXML and virNodeDeviceDestroy * - Create a node device vHBA allowing usage of various different @@ -313,7 +314,7 @@ manageVHBAByStoragePool(const void *data) virConnectClose(conn); return ret; } - +#endif =20 static int mymain(void) @@ -334,6 +335,7 @@ mymain(void) ret =3D -1; if (virTestRun("virVHBAGetConfig-empty-fabric_wwn", test6, NULL) < 0) ret =3D -1; +#ifdef WITH_TEST if (virTestRun("manageVHBAByNodeDevice-by-parent", manageVHBAByNodeDev= ice, test7_xml) < 0) ret =3D -1; @@ -349,6 +351,7 @@ mymain(void) if (virTestRun("manageVHBAByStoragePool-by-parent", manageVHBAByStorag= ePool, test11_xml) < 0) ret =3D -1; +#endif =20 VIR_FREE(fchost_prefix); return ret =3D=3D 0 ? EXIT_SUCCESS : EXIT_FAILURE; diff --git a/tests/meson.build b/tests/meson.build index 7270840428..73b87be2a0 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -74,7 +74,6 @@ endif =20 mock_libs =3D [ { 'name': 'domaincapsmock' }, - { 'name': 'shunload', 'sources': [ 'shunloadhelper.c' ] }, { 'name': 'vircgroupmock' }, { 'name': 'virdnsmasqmock' }, { 'name': 'virfilecachemock' }, @@ -106,6 +105,11 @@ if host_machine.system() !=3D 'windows' ] endif =20 +if conf.has('WITH_TEST') + mock_libs +=3D [ + { 'name': 'shunload', 'sources': [ 'shunloadhelper.c' ] }, + ] +endif =20 # build libraries used by tests =20 @@ -258,15 +262,11 @@ tests +=3D [ { 'name': 'domainconftest' }, { 'name': 'genericxml2xmltest' }, { 'name': 'interfacexml2xmltest' }, - { 'name': 'metadatatest' }, - { 'name': 'networkmetadatatest' }, { 'name': 'networkxml2xmlupdatetest' }, { 'name': 'nodedevxml2xmltest' }, { 'name': 'nwfilterxml2xmltest' }, - { 'name': 'objecteventtest' }, { 'name': 'seclabeltest' }, { 'name': 'secretxml2xmltest' }, - { 'name': 'shunloadtest', 'deps': [ thread_dep ] }, { 'name': 'sockettest' }, { 'name': 'storagevolxml2xmltest' }, { 'name': 'sysinfotest' }, @@ -298,7 +298,6 @@ tests +=3D [ { 'name': 'virportallocatortest' }, { 'name': 'virrotatingfiletest' }, { 'name': 'virschematest' }, - { 'name': 'virshtest', 'depends': [ virsh_prog ] }, { 'name': 'virstringtest' }, { 'name': 'virsystemdtest' }, { 'name': 'virtimetest' }, @@ -333,6 +332,17 @@ if host_machine.system() =3D=3D 'linux' endif endif =20 +if conf.has('WITH_TEST') + tests +=3D [ + { 'name': 'fdstreamtest' }, + { 'name': 'metadatatest' }, + { 'name': 'networkmetadatatest' }, + { 'name': 'objecteventtest' }, + { 'name': 'shunloadtest', 'deps': [ thread_dep ] }, + { 'name': 'virshtest', 'depends': [ virsh_prog ] }, + ] +endif + if conf.has('WITH_BHYVE') tests +=3D [ { 'name': 'bhyveargv2xmltest', 'link_with': [ bhyve_driver_impl ] }, @@ -364,7 +374,6 @@ endif if conf.has('WITH_LIBVIRTD') tests +=3D [ { 'name': 'eventtest', 'deps': [ thread_dep ] }, - { 'name': 'fdstreamtest' }, { 'name': 'virdriverconnvalidatetest' }, { 'name': 'virdrivermoduletest' }, ] @@ -619,12 +628,14 @@ test( suite: 'script', ) =20 -# vsh based client self-test, which can be run directly from meson -test('virsh self-test', - virsh_prog, - args: [ '-q', '-c', 'test:///default', 'self-test' ], - suite: 'bin', -) +if conf.has('WITH_TEST') + # vsh based client self-test, which can be run directly from meson + test('virsh self-test', + virsh_prog, + args: [ '-q', '-c', 'test:///default', 'self-test' ], + suite: 'bin', + ) +endif =20 if conf.has('WITH_REMOTE') test('virt-admin self-test', --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090637210911.129015205236; Tue, 7 May 2024 07:03:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 165BF1D06; Tue, 7 May 2024 10:03:56 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9DCCA1C83; Tue, 7 May 2024 09:59:29 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 477E11AD6; Tue, 7 May 2024 09:59:14 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 70F3B1ACF for ; Tue, 7 May 2024 09:59:13 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-9tls5ec6O7aCH7BvB5ZLZA-1; Tue, 07 May 2024 09:59:11 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F5C585A58C for ; Tue, 7 May 2024 13:59:11 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id F24D71C060AE; Tue, 7 May 2024 13:59:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 9tls5ec6O7aCH7BvB5ZLZA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 03/12] meson: record which other options are a pre-requisite Date: Tue, 7 May 2024 14:58:58 +0100 Message-ID: <20240507135907.1104087-4-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: KT44OFKMOKNIORUI2BUGQMK4633VELAX X-Message-ID-Hash: KT44OFKMOKNIORUI2BUGQMK4633VELAX X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090637810100001 Several meson options cannot be enabled, without first enabling another option. This adds a small comment prior to an optino to record its mandatory dependencies. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- meson_options.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/meson_options.txt b/meson_options.txt index ed91d97abf..9d729b3e1f 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -4,6 +4,7 @@ option('packager_version', type: 'string', value: '', descr= iption: 'Extra packag option('system', type: 'boolean', value: false, description: 'Set install = paths to system ones') option('runstatedir', type: 'string', value: '', description: 'State direc= tory for temporary sockets, pid files, etc') option('initconfdir', type: 'string', value: '', description: 'directory f= or init script configuration files') +# dep:tests option('expensive_tests', type: 'feature', value: 'auto', description: 'se= t the default for enabling expensive tests (long timeouts)') option('test_coverage', type: 'boolean', value: false, description: 'turn = on code coverage instrumentation') option('git_werror', type: 'feature', value: 'auto', description: 'use -We= rror if building from GIT') @@ -17,6 +18,7 @@ option('tests', type: 'feature', value: 'auto', descripti= on: 'whether to build a option('apparmor', type: 'feature', value: 'auto', description: 'apparmor = support') option('attr', type: 'feature', value: 'auto', description: 'attr support') option('audit', type: 'feature', value: 'auto', description: 'audit suppor= t') +# dep:readline option('bash_completion', type: 'feature', value: 'auto', description: 'ba= sh-completion support') option('bash_completion_dir', type: 'string', value: '', description: 'dir= ectory containing bash completion scripts') option('blkid', type: 'feature', value: 'auto', description: 'blkid suppor= t') @@ -40,7 +42,9 @@ option('sanlock', type: 'feature', value: 'auto', descrip= tion: 'sanlock support' option('sasl', type: 'feature', value: 'auto', description: 'sasl support') option('selinux', type: 'feature', value: 'auto', description: 'selinux su= pport') option('selinux_mount', type: 'string', value: '', description: 'set SELin= ux mount point') +# dep:pciaccess option('udev', type: 'feature', value: 'auto', description: 'udev support') +# dep:driver_remote option('wireshark_dissector', type: 'feature', value: 'auto', description:= 'wireshark support') option('wireshark_plugindir', type: 'string', value: '', description: 'wir= eshark plugins directory for use when installing wireshark plugin') option('yajl', type: 'feature', value: 'auto', description: 'yajl support') @@ -48,17 +52,26 @@ option('yajl', type: 'feature', value: 'auto', descript= ion: 'yajl support') =20 # build driver options option('driver_bhyve', type: 'feature', value: 'auto', description: 'bhyve= driver') +# dep:curl option('driver_esx', type: 'feature', value: 'auto', description: 'esx dri= ver') +# dep:openwsman option('driver_hyperv', type: 'feature', value: 'auto', description: 'Hype= r-V driver') +# dep:pciaccess dep:udev dep:driver_remote dep:driver_libvirtd option('driver_interface', type: 'feature', value: 'auto', description: 'h= ost interface driver') +# dep:driver_remote option('driver_libvirtd', type: 'feature', value: 'auto', description: 'li= bvirtd driver') +# dep:driver_remote dep:driver_libvirtd option('driver_libxl', type: 'feature', value: 'auto', description: 'libxe= nlight driver') +# dep:driver_remote dep:driver_libvirtd option('driver_lxc', type: 'feature', value: 'auto', description: 'Linux C= ontainer driver') +# dep:curl dep:yajl dep:driver_remote dep:driver_libvirtd option('driver_ch', type: 'feature', value: 'auto', description: 'Cloud-Hy= pervisor driver') option('ch_user', type: 'string', value: '', description: 'username to run= Cloud-Hypervisor system instance as') option('ch_group', type: 'string', value: '', description: 'groupname to r= un Cloud-Hypervisor system instance as') +# dep:driver_remote dep:driver_libvirtd option('driver_network', type: 'feature', value: 'auto', description: 'vir= tual network driver') option('driver_openvz', type: 'feature', value: 'auto', description: 'Open= VZ driver') +# dep:yajl dep:driver_remote dep:driver_libvirtd option('driver_qemu', type: 'feature', value: 'auto', description: 'QEMU/K= VM driver') option('qemu_user', type: 'string', value: '', description: 'username to r= un QEMU system instance as') option('qemu_group', type: 'string', value: '', description: 'groupname to= run QEMU system instance as') @@ -74,7 +87,9 @@ option('driver_vmware', type: 'feature', value: 'auto', d= escription: 'VMware dri option('driver_vz', type: 'feature', value: 'auto', description: 'Virtuozz= o driver') =20 option('secdriver_apparmor', type: 'feature', value: 'auto', description: = 'use AppArmor security driver') +# dep:secdriver_apparmor option('apparmor_profiles', type: 'feature', value: 'auto', description: '= install apparmor profiles') +# dep:selinux option('secdriver_selinux', type: 'feature', value: 'auto', description: '= use SELinux security driver') =20 =20 @@ -97,16 +112,21 @@ option('storage_zfs', type: 'feature', value: 'auto', = description: 'ZFS backend option('chrdev_lock_files', type: 'string', value: '', description: 'locat= ion for UUCP style lock files for character devices (leave empty for defaul= t paths on some platforms)') option('dtrace', type: 'feature', value: 'auto', description: 'use dtrace = for static probing') option('firewalld', type: 'feature', value: 'auto', description: 'firewall= d support') +# dep:firewalld option('firewalld_zone', type: 'feature', value: 'auto', description: 'whe= ther to install firewalld libvirt zone') option('host_validate', type: 'feature', value: 'auto', description: 'buil= d virt-host-validate') option('init_script', type: 'combo', choices: ['systemd', 'openrc', 'check= ', 'none'], value: 'check', description: 'Style of init script to install') option('loader_nvram', type: 'string', value: '', description: 'Pass list = of pairs of : paths. Both pairs and list items are separated= by a colon.') option('login_shell', type: 'feature', value: 'auto', description: 'build = virt-login-shell') +# dep:yajl dep:driver_network dep:libvirtd option('nss', type: 'feature', value: 'auto', description: 'enable Name Se= rvice Switch plugin for resolving guest IP addresses') +# dep:numactl option('numad', type: 'feature', value: 'auto', description: 'use numad to= manage CPU placement dynamically') option('nbdkit', type: 'feature', value: 'auto', description: 'Build nbdki= t storage backend') +# dep:nbdkit option('nbdkit_config_default', type: 'feature', value: 'auto', descriptio= n: 'Whether to use nbdkit storage backend for network disks by default (con= figurable)') option('pm_utils', type: 'feature', value: 'auto', description: 'use pm-ut= ils for power management') option('sysctl_config', type: 'feature', value: 'auto', description: 'Whet= her to install sysctl configs') +# dep:sysctl_config option('userfaultfd_sysctl', type: 'feature', value: 'auto', description: = 'Whether to install sysctl config for enabling unprivileged userfaultfd') option('tls_priority', type: 'string', value: 'NORMAL', description: 'set = the default TLS session priority string') --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090686131484.29837307710716; Tue, 7 May 2024 07:04:46 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8F9D81DC1; Tue, 7 May 2024 10:04:44 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C696F1D4B; Tue, 7 May 2024 09:59:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3C7A11AD7; Tue, 7 May 2024 09:59:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B33051ACB for ; Tue, 7 May 2024 09:59:14 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-7YXGr6eIM1CBAipwzi96EA-1; Tue, 07 May 2024 09:59:12 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6FC0A801189 for ; Tue, 7 May 2024 13:59:12 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC1BF1C060AE; Tue, 7 May 2024 13:59:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 7YXGr6eIM1CBAipwzi96EA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 04/12] docs: ensure HTML/images are built before running reference tests Date: Tue, 7 May 2024 14:58:59 +0100 Message-ID: <20240507135907.1104087-5-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: EIB25ODR6P4VQCHXUUWEG7CWSXFQ2QPY X-Message-ID-Hash: EIB25ODR6P4VQCHXUUWEG7CWSXFQ2QPY X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090688216100001 The 'check-html-references' test will process the built HTML files, so they must exist before it is run, along with any images that they point to. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- docs/images/meson.build | 5 +++-- docs/logos/meson.build | 5 +++-- docs/meson.build | 1 + 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/images/meson.build b/docs/images/meson.build index b9ab30fc91..cccd351f05 100644 --- a/docs/images/meson.build +++ b/docs/images/meson.build @@ -18,10 +18,11 @@ foreach file : docs_image_files # This hack enables us to view the web pages # from within the uninstalled build tree if meson.version().version_compare('>=3D0.64.0') - fs.copyfile(file) + imgfile =3D fs.copyfile(file) else - configure_file(input: file, output: file, copy: true) + imgfile =3D configure_file(input: file, output: file, copy: true) endif =20 + install_web_deps +=3D [imgfile] install_web_files +=3D '@0@:@1@'.format(meson.current_source_dir() / fil= e, docs_html_dir / 'images') endforeach diff --git a/docs/logos/meson.build b/docs/logos/meson.build index c3f4c9f522..b4ea070a34 100644 --- a/docs/logos/meson.build +++ b/docs/logos/meson.build @@ -26,11 +26,12 @@ foreach file : docs_logo_files # This hack enables us to view the web pages # from within the uninstalled build tree if meson.version().version_compare('>=3D0.64.0') - fs.copyfile(file) + logofile =3D fs.copyfile(file) else - configure_file(input: file, output: file, copy: true) + logofile =3D configure_file(input: file, output: file, copy: true) endif =20 + install_web_deps +=3D [logofile] install_web_files +=3D '@0@:@1@'.format(meson.current_source_dir() / fil= e, docs_html_dir / 'logos') endforeach =20 diff --git a/docs/meson.build b/docs/meson.build index 87d728213c..2dfe98ef62 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -360,6 +360,7 @@ if tests_enabled[0] '--webroot', meson.project_build_root() / 'docs' ], + depends: install_web_deps, env: runutf8, suite: 'script' ) --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090766051447.57541293262943; Tue, 7 May 2024 07:06:06 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4A4AB12C; Tue, 7 May 2024 10:06:04 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id AC04F1E2B; Tue, 7 May 2024 09:59:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5BCFC1D2D; Tue, 7 May 2024 09:59:33 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0DF4C1C42 for ; Tue, 7 May 2024 09:59:17 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-ja9FdlGAM66KfXX96NusTA-1; Tue, 07 May 2024 09:59:15 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D633D3803523 for ; Tue, 7 May 2024 13:59:13 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id DEF3A1C060AE; Tue, 7 May 2024 13:59:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: ja9FdlGAM66KfXX96NusTA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 05/12] src: ensure augeas test file is generated before running test Date: Tue, 7 May 2024 14:59:00 +0100 Message-ID: <20240507135907.1104087-6-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 4SFR5MLHKCH4W7HP7US7KOGLLLZRTIJY X-Message-ID-Hash: 4SFR5MLHKCH4W7HP7US7KOGLLLZRTIJY X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090766557100001 We fail to express an ordering between the custom target that generates the combined augeas test input file, and the meson test command. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/meson.build b/src/meson.build index a51f40fe16..17e6feafba 100644 --- a/src/meson.build +++ b/src/meson.build @@ -1048,7 +1048,8 @@ if tests_enabled[0] '-I', data['builddir'], data['file'].full_path(), ], - suite: 'script' + suite: 'script', + depends: [data['file']] ) endforeach endif --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090726098942.5036532738237; Tue, 7 May 2024 07:05:26 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C856C1A0F; Tue, 7 May 2024 10:05:24 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 145C51E12; Tue, 7 May 2024 09:59:41 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B3A5C1E0E; Tue, 7 May 2024 09:59:31 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AE5B21C20 for ; Tue, 7 May 2024 09:59:16 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-uljyFJyWP7eAQIGepM2KuQ-1; Tue, 07 May 2024 09:59:15 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4F391C3F0E9 for ; Tue, 7 May 2024 13:59:14 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 134231C051F5; Tue, 7 May 2024 13:59:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: uljyFJyWP7eAQIGepM2KuQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 06/12] tests: build 'virsh' before running virsh-auth test Date: Tue, 7 May 2024 14:59:01 +0100 Message-ID: <20240507135907.1104087-7-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: KRFXMZMR67EWXBT3XW5IZH3BAJTEDWHD X-Message-ID-Hash: KRFXMZMR67EWXBT3XW5IZH3BAJTEDWHD X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090726353100001 The 'virsh-auth' test needs to be able to invoke the 'virsh' binary Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tests/meson.build | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 73b87be2a0..68fe00d0c1 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -720,17 +720,23 @@ if conf.has('WITH_LIBVIRTD') ) =20 test_scripts +=3D [ - 'virsh-auth', + { 'name': 'virsh-auth', 'depends': [virsh_prog] } ] =20 if conf.has('WITH_SECDRIVER_APPARMOR') - test_scripts +=3D 'virt-aa-helper-test' + test_scripts +=3D { 'name': 'virt-aa-helper-test' } endif endif =20 -foreach name : test_scripts - script =3D find_program(name) - test(name, script, env: tests_env, suite: 'script') +foreach data : test_scripts + script =3D find_program(data['name']) + test(data['name'], + script, + env: tests_env, + depends: [ + data.get('depends', []), + ], + suite: 'script') endforeach =20 testenv =3D runutf8 --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090803798929.7234398248243; Tue, 7 May 2024 07:06:43 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9ED081F13; Tue, 7 May 2024 10:06:42 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3868B1E23; Tue, 7 May 2024 09:59:51 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0180D1C42; Tue, 7 May 2024 09:59:34 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 190B71C9B for ; Tue, 7 May 2024 09:59:17 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-AcIq2Pq0NLGwbQjuaC2ElA-1; Tue, 07 May 2024 09:59:15 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AAA6D8015D7 for ; Tue, 7 May 2024 13:59:15 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E6241C060AE; Tue, 7 May 2024 13:59:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: AcIq2Pq0NLGwbQjuaC2ElA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 07/12] tests: build driver modules before virdrivermoduletest Date: Tue, 7 May 2024 14:59:02 +0100 Message-ID: <20240507135907.1104087-8-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 7SL7XIRMB2VJBVZWYVN5R3QF7XCAK3UP X-Message-ID-Hash: 7SL7XIRMB2VJBVZWYVN5R3QF7XCAK3UP X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090804758100001 The virdrivermoduletest will attempt to dlopen() each driver module, so they must be build before the test can run. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/meson.build | 3 +++ tests/meson.build | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/meson.build b/src/meson.build index 17e6feafba..fead0de998 100644 --- a/src/meson.build +++ b/src/meson.build @@ -578,6 +578,8 @@ endif =20 # build libvirt shared modules =20 +virt_module_deps =3D [] + foreach module : virt_modules mod =3D shared_module( module['name'], @@ -607,6 +609,7 @@ foreach module : virt_modules install_rpath: libvirt_rpath, ) set_variable('@0@_module'.format(module['name'].underscorify()), mod) + virt_module_deps +=3D [mod] endforeach =20 =20 diff --git a/tests/meson.build b/tests/meson.build index 68fe00d0c1..76c05b9fed 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -375,7 +375,7 @@ if conf.has('WITH_LIBVIRTD') tests +=3D [ { 'name': 'eventtest', 'deps': [ thread_dep ] }, { 'name': 'virdriverconnvalidatetest' }, - { 'name': 'virdrivermoduletest' }, + { 'name': 'virdrivermoduletest', 'depends': virt_module_deps }, ] endif =20 --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090843303832.3597960719746; Tue, 7 May 2024 07:07:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 2446B1C9F; Tue, 7 May 2024 10:07:22 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 87BA21BD0; Tue, 7 May 2024 09:59:56 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 189F21CE7; Tue, 7 May 2024 09:59:36 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 148F91D30 for ; Tue, 7 May 2024 09:59:19 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-ctHyU56EMmypUbQV3wp3MA-1; Tue, 07 May 2024 09:59:16 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D8EA101A553 for ; Tue, 7 May 2024 13:59:16 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 185D51C060AE; Tue, 7 May 2024 13:59:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: ctHyU56EMmypUbQV3wp3MA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 08/12] test: conditionalize 'virsh-auth' on test driver Date: Tue, 7 May 2024 14:59:03 +0100 Message-ID: <20240507135907.1104087-9-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: XBHFBJ2LCYZ4DTH7WMHGRRUEKE3FKQRI X-Message-ID-Hash: XBHFBJ2LCYZ4DTH7WMHGRRUEKE3FKQRI X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090844975100001 The 'virsh-auth' test is mistakenly conditionalized on the libvirtd daemon build, however, it just uses the 'test:///default' driver URI, so does not require a daemon. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tests/meson.build | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 76c05b9fed..bb244d6c61 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -711,6 +711,12 @@ endforeach # list of test scripts to run test_scripts =3D [] =20 +if conf.has('WITH_TEST') + test_scripts +=3D [ + { 'name': 'virsh-auth', 'depends': [virsh_prog] } + ] +endif + if conf.has('WITH_LIBVIRTD') test('libvirtd fail with missing config', libvirtd_prog, @@ -719,10 +725,6 @@ if conf.has('WITH_LIBVIRTD') suite: 'bin', ) =20 - test_scripts +=3D [ - { 'name': 'virsh-auth', 'depends': [virsh_prog] } - ] - if conf.has('WITH_SECDRIVER_APPARMOR') test_scripts +=3D { 'name': 'virt-aa-helper-test' } endif --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090932081897.2576368122411; Tue, 7 May 2024 07:08:52 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DCF1B1C01; Tue, 7 May 2024 10:08:50 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 312631E25; Tue, 7 May 2024 10:00:12 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D4C3A1C20; Tue, 7 May 2024 09:59:58 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 034911DCA for ; Tue, 7 May 2024 09:59:21 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-T0ZRwPZ0OfKvydT4YRBIOA-1; Tue, 07 May 2024 09:59:18 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B8AFC380351C for ; Tue, 7 May 2024 13:59:17 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1405E1C060AE; Tue, 7 May 2024 13:59:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: T0ZRwPZ0OfKvydT4YRBIOA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 09/12] tests: always build securityselinuxhelper if libselinux is present Date: Tue, 7 May 2024 14:59:04 +0100 Message-ID: <20240507135907.1104087-10-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: PU7KCP2FWUVU3S4D4OXOGT5NX6SOSAQB X-Message-ID-Hash: PU7KCP2FWUVU3S4D4OXOGT5NX6SOSAQB X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090933553100005 The securityselinuxhelper build is conditionalized on the SELinux security driver feature. It is also needed, however, by viridentitytest whenever libselinux is present. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tests/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/meson.build b/tests/meson.build index bb244d6c61..027567d25c 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -508,7 +508,9 @@ if conf.has('WITH_SECDRIVER_SELINUX') ] endif endif +endif =20 +if conf.has('WITH_SELINUX') mock_libs +=3D [ { 'name': 'securityselinuxhelper' }, ] --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 171509089856157.64724115430977; Tue, 7 May 2024 07:08:18 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6E88A1EF5; Tue, 7 May 2024 10:08:17 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id BA2B11B1D; Tue, 7 May 2024 10:00:06 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 663861C1D; Tue, 7 May 2024 09:59:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BF99C1DB6 for ; Tue, 7 May 2024 09:59:21 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-CpH7F-JsO8mtr3MHKCeSwQ-1; Tue, 07 May 2024 09:59:19 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB3028029EB for ; Tue, 7 May 2024 13:59:18 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26B8E1C060AE; Tue, 7 May 2024 13:59:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: CpH7F-JsO8mtr3MHKCeSwQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 10/12] test: drop bogus check for YAJL from libxl test/mock Date: Tue, 7 May 2024 14:59:05 +0100 Message-ID: <20240507135907.1104087-11-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: NWMGWLKSSOUQXE3TZJGDSYNJFK23E3KV X-Message-ID-Hash: NWMGWLKSSOUQXE3TZJGDSYNJFK23E3KV X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090899317100001 The libxlmock.c conditionalizes on WITH_YAJL, but this mock is used from other tests which only conditionalize on WITH_LIBXL. The libxl code does not have any dependancy on YAJL, so the bogus condition can be removed from the mock and also from libxlxml2domconfigtest.c Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tests/libxlmock.c | 4 ++-- tests/libxlxml2domconfigtest.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/libxlmock.c b/tests/libxlmock.c index f564a0ef72..8b697702b5 100644 --- a/tests/libxlmock.c +++ b/tests/libxlmock.c @@ -20,7 +20,7 @@ =20 #include =20 -#if defined(WITH_LIBXL) && defined(WITH_YAJL) +#if defined(WITH_LIBXL) # include "virmock.h" # include # include @@ -168,4 +168,4 @@ libxlDomainGetEmulatorType(const virDomainDef *def G_GN= UC_UNUSED) return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN; } =20 -#endif /* WITH_LIBXL && WITH_YAJL */ +#endif /* WITH_LIBXL */ diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c index 6418341564..21c4e7d149 100644 --- a/tests/libxlxml2domconfigtest.c +++ b/tests/libxlxml2domconfigtest.c @@ -28,7 +28,7 @@ =20 #include "testutils.h" =20 -#if defined(WITH_LIBXL) && defined(WITH_YAJL) +#if defined(WITH_LIBXL) =20 # include "internal.h" # include "libxl/libxl_conf.h" @@ -224,4 +224,4 @@ int main(void) return EXIT_AM_SKIP; } =20 -#endif /* WITH_LIBXL && WITH_YAJL */ +#endif /* WITH_LIBXL */ --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090961500304.66932879095305; Tue, 7 May 2024 07:09:21 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 260271AFC; Tue, 7 May 2024 10:09:20 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 646A71E7C; Tue, 7 May 2024 10:00:15 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 88C421D7D; Tue, 7 May 2024 09:59:59 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4705A1DD9 for ; Tue, 7 May 2024 09:59:22 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-c1ba4DadMqmq7VqEULr1Yw-1; Tue, 07 May 2024 09:59:20 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 23B141C0007D for ; Tue, 7 May 2024 13:59:20 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E61A1C060AE; Tue, 7 May 2024 13:59:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: c1ba4DadMqmq7VqEULr1Yw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 11/12] tests: don't run mdevctl test if lacking YAJL Date: Tue, 7 May 2024 14:59:06 +0100 Message-ID: <20240507135907.1104087-12-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: BALBVZQTWIDZFKPMZDY7KEMQ6X7M3D2L X-Message-ID-Hash: BALBVZQTWIDZFKPMZDY7KEMQ6X7M3D2L X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090961637100001 The mdev code requires YAJL in order to convert from node dev XML to mdev's config format. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 027567d25c..0d83dd445a 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -402,7 +402,7 @@ if conf.has('WITH_NETWORK') ] endif =20 -if conf.has('WITH_NODE_DEVICES') +if conf.has('WITH_NODE_DEVICES') and conf.has('WITH_YAJL') tests +=3D [ { 'name': 'nodedevmdevctltest', 'link_with': [ node_device_driver_impl= ] }, ] --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Tue Feb 10 00:03:15 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1715090991827199.0673900844606; Tue, 7 May 2024 07:09:51 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B0FAB1C80; Tue, 7 May 2024 10:09:50 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 1C93A1E85; Tue, 7 May 2024 10:00:18 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4AEC51D4D; Tue, 7 May 2024 10:00:01 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id DA5051DAF for ; Tue, 7 May 2024 09:59:23 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-8X9902ZhN8y8cZ3CbOMJig-1; Tue, 07 May 2024 09:59:21 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95F7B857A83 for ; Tue, 7 May 2024 13:59:21 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7EEE01C060AE; Tue, 7 May 2024 13:59:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 8X9902ZhN8y8cZ3CbOMJig-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: devel@lists.libvirt.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 12/12] src/node_device: don't overwrite error messages Date: Tue, 7 May 2024 14:59:07 +0100 Message-ID: <20240507135907.1104087-13-berrange@redhat.com> In-Reply-To: <20240507135907.1104087-1-berrange@redhat.com> References: <20240507135907.1104087-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 3TFW454YCGMCWJCRLINYNQMTXJKRCBJU X-Message-ID-Hash: 3TFW454YCGMCWJCRLINYNQMTXJKRCBJU X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1715090993791100001 The nodedev code unhelpfully reports couldn't convert node device def to mdevctl JSON which hides the actual error message No JSON parser implementation is available Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/node_device/node_device_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index d99b48138e..700776c90c 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -774,8 +774,6 @@ nodeDeviceGetMdevctlCommand(virNodeDeviceDef *def, } =20 if (nodeDeviceDefToMdevctlConfig(def, &inbuf, true) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("couldn't convert node device def to mdevctl = JSON")); return NULL; } =20 --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org