From nobody Mon May 13 13:25:14 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710769056027113.5290942075834; Mon, 18 Mar 2024 06:37:36 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9EC9D1D71; Mon, 18 Mar 2024 09:37:34 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 948A11C1B; Mon, 18 Mar 2024 09:37:01 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8D2A11B82; Mon, 18 Mar 2024 09:31:26 -0400 (EDT) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 988251B86 for ; Mon, 18 Mar 2024 09:31:24 -0400 (EDT) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dd10ae77d8so26834995ad.0 for ; Mon, 18 Mar 2024 06:31:24 -0700 (PDT) Received: from localhost.localdomain ([111.108.111.133]) by smtp.gmail.com with ESMTPSA id jx18-20020a170903139200b001dcc2847655sm9225213plb.176.2024.03.18.06.31.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2024 06:31:22 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710768683; x=1711373483; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CTPj8lHWLp0dH59naW4O/aMl6r9aufVnYhGcR38AM3Y=; b=HQmr4TqutiTBzAbqor6f1Fdk0xOFHZRLXSjiZllXRTutXyiuTFILup0iJ9YB1MQaJE XRYX5f1UIoex1/P3i2buJB5qgiR9fSE26UoWdnJ6A9YVyBfNl9nLzRbzj1ObU6SH9xvw k9JzkV/IB1WI4hjX7Mb34Aa4OKOi3rgSZyDOdD9BbjdGGmquKA9Sef65rx7cH0zSN9ka VKrQ7dgk+SYKAX7RCKQS7qdNH8rBvRrzP9e9FSydNWzkrY2FSaXjBZ1kTL4Vo6oz97Ch h0JZsp4hIOMgH8TiL3/WHk6usyH1X9ACg0Ap6pBEWNlt4sl/VgfFOUhkUyfKdAQz7ZcB lSLg== X-Gm-Message-State: AOJu0YyOoFascYqudAAQ62o4bAUEHbm/RsSMjk2fS8g0RcxTQfA1mUgl Mk7sJj8jpWrl2rCLVD84u3s1ow007rjYVy6Lc9pcSCZ/6MRvXQRwe5KmYJWS1162AQ== X-Google-Smtp-Source: AGHT+IFwQx5AZZObVEAFtvPoCPc9tH5QW3OVeMq8Fm5v27aO1HVvF+qQ7Vi7h24GAzvp6jvAHncAvg== X-Received: by 2002:a17:902:b78b:b0:1dd:819f:9503 with SMTP id e11-20020a170902b78b00b001dd819f9503mr12092894pls.12.1710768682651; Mon, 18 Mar 2024 06:31:22 -0700 (PDT) From: Wei Gong To: devel@lists.libvirt.org, mprivozn@redhat.com Subject: [PATCH v2] virthreadpool: create threads from the newly expanded workers Date: Mon, 18 Mar 2024 21:31:14 +0800 Message-Id: <20240318133114.45715-1-gongwei833x@gmail.com> X-Mailer: git-send-email 2.32.1 (Apple Git-133) MIME-Version: 1.0 X-MailFrom: gongwei833x@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: 6GYASUKG2TWNOANHOY2UKBYPH4SWTJDU X-Message-ID-Hash: 6GYASUKG2TWNOANHOY2UKBYPH4SWTJDU X-Mailman-Approved-At: Mon, 18 Mar 2024 13:36:59 -0400 CC: Wei Gong X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710769057764100001 when the thread pool is dynamically expanded, threads should not be created from the existing workers; they should be created from the newly expanded workers Signed-off-by: Wei Gong Reviewed-by: Michal Privoznik --- src/util/virthreadpool.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/util/virthreadpool.c b/src/util/virthreadpool.c index d45fa92061..de8113df81 100644 --- a/src/util/virthreadpool.c +++ b/src/util/virthreadpool.c @@ -184,7 +184,8 @@ virThreadPoolExpand(virThreadPool *pool, size_t gain, b= ool priority) size_t i =3D 0; struct virThreadPoolWorkerData *data =3D NULL; =20 - VIR_EXPAND_N(*workers, *curWorkers, gain); + VIR_REALLOC_N(*workers, *curWorkers + gain); + memset(&(*workers)[*curWorkers], 0, sizeof(virThread) * gain); =20 for (i =3D 0; i < gain; i++) { g_autofree char *name =3D NULL; @@ -199,7 +200,7 @@ virThreadPoolExpand(virThreadPool *pool, size_t gain, b= ool priority) else name =3D g_strdup(pool->jobName); =20 - if (virThreadCreateFull(&(*workers)[i], + if (virThreadCreateFull(&(*workers)[*curWorkers], false, virThreadPoolWorker, name, @@ -207,15 +208,13 @@ virThreadPoolExpand(virThreadPool *pool, size_t gain,= bool priority) data) < 0) { VIR_FREE(data); virReportSystemError(errno, "%s", _("Failed to create thread")= ); - goto error; + return -1; } + + (*curWorkers)++; } =20 return 0; - - error: - *curWorkers -=3D gain - i; - return -1; } =20 virThreadPool * --=20 2.32.1 (Apple Git-133) _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org