From nobody Sun May 12 18:20:05 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710753050079738.6646728218581; Mon, 18 Mar 2024 02:10:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id DF8702183; Mon, 18 Mar 2024 05:10:48 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 21DC01EA1; Mon, 18 Mar 2024 05:03:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D8F211A90; Sun, 17 Mar 2024 11:20:37 -0400 (EDT) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9E5571AAB for ; Sun, 17 Mar 2024 11:20:36 -0400 (EDT) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4140a9f25adso4935165e9.2 for ; Sun, 17 Mar 2024 08:20:36 -0700 (PDT) Received: from karim.localdomain ([197.39.159.115]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c4f4800b00413ea26f942sm14716012wmq.14.2024.03.17.08.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 08:20:33 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710688834; x=1711293634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OJ6pHXNyEzEBu1HmE0jUuDvk+7rg/FIvnyxbUL8Ey7g=; b=Dvo0+peCuHO9IPX3rhMnlFzoEbA3josDTp5X0hZYMXVmFEpuykpkccNw+XgCbzDIN7 vJM6y0WWua3U+uhclFPBZTsBAiDnvepLppezeqcOqbNJo/GeM2NHET44r/zZ0XvdSL4W t5Ycs+g5Hm2A9TJjJH1vproTNXbWzu4Z2xCa5V7b+i1uiObBe1DXU44XsokAyRRK678V UrxHc+B6rcH1rgIAx7LW5cHHLwt/TZW10wb0/aopJSs0cBRs/kfIZof6ES9C0EETc1wj 7EbxX4ivdvNO44ILC8oeqVSlcUbbVDACPoiYvPzldJiziU7DxWufNxQ0S+vexe5ZrXlf mZlw== X-Gm-Message-State: AOJu0Yxsbnum9IZElk0XjG9IuT13MGZmraJn6Cn8Ui3J6zo/+SbGT9xn RQw4FtvnR1uf3Pmbb5bgeYoOsfXlLf/JhuqKCiKNuynn/nf/1e58Af85rZ4h X-Google-Smtp-Source: AGHT+IF0TNpYghUcsjzMLf0UpdYkN9FsOxdlEvnUspNSKTruxclVSynbhJE/N+aSLzHVKxoFN7oXCA== X-Received: by 2002:a05:600c:1992:b0:414:c48:a90 with SMTP id t18-20020a05600c199200b004140c480a90mr1345690wmq.24.1710688834586; Sun, 17 Mar 2024 08:20:34 -0700 (PDT) From: Karim Taha To: devel@lists.libvirt.org Subject: [PATCH 1/2] openvz_driver: use g_autofree instead of VIR_FREE in openvz_driver.c Date: Sun, 17 Mar 2024 17:19:20 +0200 Message-ID: <20240317151921.233537-2-kariem.taha2.7@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240317151921.233537-1-kariem.taha2.7@gmail.com> References: <20240317151921.233537-1-kariem.taha2.7@gmail.com> MIME-Version: 1.0 X-MailFrom: kariem.taha2.7@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: UN37RTDUIIHOBE7Z3EWT4WQHR43KKRUN X-Message-ID-Hash: UN37RTDUIIHOBE7Z3EWT4WQHR43KKRUN X-Mailman-Approved-At: Mon, 18 Mar 2024 09:02:54 -0400 CC: mprivozn@redhat.com, Karim Taha X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710753051096100001 Signed-off-by: Karim Taha Reviewed-by: Michal Privoznik --- src/openvz/openvz_driver.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 1bd96dfb56..fd3c25a393 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -615,7 +615,7 @@ openvzGenerateVethName(int veid, char *dev_name_ve) static char * openvzGenerateContainerVethName(int veid) { - char *temp =3D NULL; + g_autofree char *temp =3D NULL; char *name =3D NULL; /* try to get line "^NETIF=3D..." from config */ @@ -638,8 +638,6 @@ openvzGenerateContainerVethName(int veid) name =3D g_strdup_printf("eth%d", max + 1); } - VIR_FREE(temp); - return name; } @@ -750,7 +748,7 @@ openvzDomainSetNetworkConfig(virConnectPtr conn, { size_t i; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; - char *param; + g_autofree char *param =3D NULL; int first =3D 1; struct openvz_driver *driver =3D conn->privateData; @@ -774,12 +772,10 @@ openvzDomainSetNetworkConfig(virConnectPtr conn, param =3D virBufferContentAndReset(&buf); if (param) { if (openvzWriteVPSConfigParam(strtoI(def->name), "NETIF", para= m) < 0) { - VIR_FREE(param); virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot replace NETIF config")); return -1; } - VIR_FREE(param); } } @@ -1075,7 +1071,7 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autos= tart) { struct openvz_driver *driver =3D dom->conn->privateData; virDomainObj *vm; - char *value =3D NULL; + g_autofree char *value =3D NULL; int ret =3D -1; if (!(vm =3D openvzDomObjFromDomain(driver, dom->uuid))) @@ -1093,8 +1089,6 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autos= tart) ret =3D 0; cleanup: - VIR_FREE(value); - virDomainObjEndAPI(&vm); return ret; } @@ -1405,7 +1399,7 @@ static int openvzConnectListDefinedDomains(virConnect= Ptr conn G_GNUC_UNUSED, static int openvzGetProcessInfo(unsigned long long *cpuTime, int vpsid) { FILE *fp; - char *line =3D NULL; + g_autofree char *line =3D NULL; size_t line_size =3D 0; unsigned long long usertime, systime, nicetime; int readvps =3D vpsid + 1; /* ensure readvps is initially different */ @@ -1442,7 +1436,6 @@ Version: 2.2 } } - VIR_FREE(line); VIR_FORCE_FCLOSE(fp); if (err) return -1; -- 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Sun May 12 18:20:05 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710753083662334.6038893446507; Mon, 18 Mar 2024 02:11:23 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9B8241B22; Mon, 18 Mar 2024 05:11:22 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 22CE11EAE; Mon, 18 Mar 2024 05:03:35 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A011E1A90; Sun, 17 Mar 2024 11:20:39 -0400 (EDT) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0E9AD1A90 for ; Sun, 17 Mar 2024 11:20:38 -0400 (EDT) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-414025406d7so14042975e9.2 for ; Sun, 17 Mar 2024 08:20:38 -0700 (PDT) Received: from karim.localdomain ([197.39.159.115]) by smtp.gmail.com with ESMTPSA id m8-20020a05600c4f4800b00413ea26f942sm14716012wmq.14.2024.03.17.08.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 08:20:35 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710688836; x=1711293636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=up51k0jI5aLsUYnyMMfG7qqbNMkee0eR2+AQxf+7Tro=; b=emdl1AC2QwohSMp6P0GHE89JkBDM/nJUV3eeQHxT+kcrDFM30frQVLUa2BFo7kScJX 71QzBs8HjBBzDfDl2xtqXYp6n0XTFEZ4+SQ4dzfI2tBduda5EWnyYoUFt2bvA6hxwz7Z QImYDtICFhkfiGqEYIfMPlyeAn0rTmLOwH20lVb25oYoPxii7eDTMo3mxgNulaC5V5h+ vQC0djMzZBMmsZ37150q80fJfOA0OQ+LErG8rH69Of5PWQlFf2vf3DMzMDeROFhJCTGj datRLL8dWw9i09bPKB9umygHxlPm3gT6klINhbcDNAoaniJ1ZhjFqYryQZXXM63tNtQ1 0JjA== X-Gm-Message-State: AOJu0YwnE3InIRbAplQ7bODqqEfFEjkQw9I/B5v7zkayKIZgEU2unYAK 2/eOGjRL9IePKe/mG46SGnkb/4NhHjwir0MLNuIJwdPh3w/YADz+lQBGBsef X-Google-Smtp-Source: AGHT+IGkm7H5CxXeJaS8RPMBQtOJj+a6xnHn7kfLxexfG8jVwwEVJJHTrsQUM1u4qvcCuwNZReSs9g== X-Received: by 2002:a05:600c:4f56:b0:413:eee2:96a3 with SMTP id m22-20020a05600c4f5600b00413eee296a3mr6813372wmq.1.1710688836331; Sun, 17 Mar 2024 08:20:36 -0700 (PDT) From: Karim Taha To: devel@lists.libvirt.org Subject: [PATCH 2/2] node_device: use g_autofree instead of VIR_FREE in node_device_driver.c Date: Sun, 17 Mar 2024 17:19:21 +0200 Message-ID: <20240317151921.233537-3-kariem.taha2.7@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240317151921.233537-1-kariem.taha2.7@gmail.com> References: <20240317151921.233537-1-kariem.taha2.7@gmail.com> MIME-Version: 1.0 X-MailFrom: kariem.taha2.7@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: O6I2UCZ3IJI2QHNNM6H3GNKQIOYCLZXH X-Message-ID-Hash: O6I2UCZ3IJI2QHNNM6H3GNKQIOYCLZXH X-Mailman-Approved-At: Mon, 18 Mar 2024 09:03:02 -0400 CC: mprivozn@redhat.com, Karim Taha X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710753085190100001 Signed-off-by: Karim Taha Reviewed-by: Michal Privoznik --- src/node_device/node_device_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index ce42b1ca63..d99b48138e 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -439,7 +439,7 @@ nodeDeviceListCaps(virNodeDevicePtr device, { virNodeDeviceObj *obj; virNodeDeviceDef *def; - virNodeDevCapType *list =3D NULL; + g_autofree virNodeDevCapType *list =3D NULL; int ncaps =3D 0; int ret =3D -1; size_t i =3D 0; @@ -472,8 +472,6 @@ nodeDeviceListCaps(virNodeDevicePtr device, for (j =3D 0; j < i; j++) VIR_FREE(names[j]); } - - VIR_FREE(list); return ret; } -- 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org