From nobody Fri May 10 19:04:17 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710752901207574.8244193172995; Mon, 18 Mar 2024 02:08:21 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id F365F1B1D; Mon, 18 Mar 2024 05:08:19 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id BB4DD1E54; Mon, 18 Mar 2024 05:03:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 787011AA7; Sun, 17 Mar 2024 10:28:58 -0400 (EDT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A239F198E for ; Sun, 17 Mar 2024 10:28:55 -0400 (EDT) Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-34169f28460so292752f8f.2 for ; Sun, 17 Mar 2024 07:28:55 -0700 (PDT) Received: from karim.localdomain ([197.39.159.115]) by smtp.gmail.com with ESMTPSA id dd12-20020a0560001e8c00b0033eab3520a9sm7624414wrb.43.2024.03.17.07.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 07:28:52 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710685733; x=1711290533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OJ6pHXNyEzEBu1HmE0jUuDvk+7rg/FIvnyxbUL8Ey7g=; b=BXzc6wSHb7oHlCqRcorArV7nLq721r3kKxJXappkNxY/9XpppAR8LDr/PFCxhaZ95c yeutxrBfMYWrYoI2xxoe591VKAXduk/0Zy+vKK1YXm3NBMgc0+00E6CFOs0bukjUajGJ WcRkPd7A+zr0o5VpUguYHN44FGYWIoua+xz5SY9sDRMCWy10yxpF2tRRtaaXdhBlf1vy D7HE/+rXUBLjBK1axNGhbYZkkd/JWthC6xRtX0TfZfCdyJlMFwfhfswt64Ts+gQWHn8w jK5qMYtToRiYyrq0QTcCKBU3gikJRCa54Ut58yLYUjAmCivrkECu11lfnLTm3d4Hv9ix BllQ== X-Gm-Message-State: AOJu0Yzfpxi36jEEgNQvs2MWshoxWqEQ/62KeCIeiYlcDqecAYKBq/PI jD0bhew2YVObaodehrBIhILnIX5yXlXAOPg6KX4qjEEesin1eltqSN/vMYvj X-Google-Smtp-Source: AGHT+IF6xz+Vf1iXZ8qa9Q5z7PMesxh/W/kgmtwk6PFjrN2oT4RKWoRjdRwvzQwbXsLLEwS3bPEAfg== X-Received: by 2002:a05:6000:889:b0:33e:66d8:95c1 with SMTP id cs9-20020a056000088900b0033e66d895c1mr7192879wrb.25.1710685733531; Sun, 17 Mar 2024 07:28:53 -0700 (PDT) From: Karim Taha To: devel@lists.libvirt.org Subject: [PATCH 1/2] openvz_driver: use g_autofree instead of VIR_FREE in openvz_driver.c Date: Sun, 17 Mar 2024 16:24:34 +0200 Message-ID: <20240317142658.228736-3-kariem.taha2.7@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240317142658.228736-1-kariem.taha2.7@gmail.com> References: <20240317142658.228736-1-kariem.taha2.7@gmail.com> MIME-Version: 1.0 X-MailFrom: kariem.taha2.7@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: Z4ILHX3GUVUPKCZNZ7JOGDKY7R5NOUFD X-Message-ID-Hash: Z4ILHX3GUVUPKCZNZ7JOGDKY7R5NOUFD X-Mailman-Approved-At: Mon, 18 Mar 2024 09:02:54 -0400 CC: mprivozn@redhat.com, Karim Taha X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710752902702100001 Signed-off-by: Karim Taha --- src/openvz/openvz_driver.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 1bd96dfb56..fd3c25a393 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -615,7 +615,7 @@ openvzGenerateVethName(int veid, char *dev_name_ve) static char * openvzGenerateContainerVethName(int veid) { - char *temp =3D NULL; + g_autofree char *temp =3D NULL; char *name =3D NULL; =20 /* try to get line "^NETIF=3D..." from config */ @@ -638,8 +638,6 @@ openvzGenerateContainerVethName(int veid) name =3D g_strdup_printf("eth%d", max + 1); } =20 - VIR_FREE(temp); - return name; } =20 @@ -750,7 +748,7 @@ openvzDomainSetNetworkConfig(virConnectPtr conn, { size_t i; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; - char *param; + g_autofree char *param =3D NULL; int first =3D 1; struct openvz_driver *driver =3D conn->privateData; =20 @@ -774,12 +772,10 @@ openvzDomainSetNetworkConfig(virConnectPtr conn, param =3D virBufferContentAndReset(&buf); if (param) { if (openvzWriteVPSConfigParam(strtoI(def->name), "NETIF", para= m) < 0) { - VIR_FREE(param); virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot replace NETIF config")); return -1; } - VIR_FREE(param); } } =20 @@ -1075,7 +1071,7 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autos= tart) { struct openvz_driver *driver =3D dom->conn->privateData; virDomainObj *vm; - char *value =3D NULL; + g_autofree char *value =3D NULL; int ret =3D -1; =20 if (!(vm =3D openvzDomObjFromDomain(driver, dom->uuid))) @@ -1093,8 +1089,6 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autos= tart) ret =3D 0; =20 cleanup: - VIR_FREE(value); - virDomainObjEndAPI(&vm); return ret; } @@ -1405,7 +1399,7 @@ static int openvzConnectListDefinedDomains(virConnect= Ptr conn G_GNUC_UNUSED, static int openvzGetProcessInfo(unsigned long long *cpuTime, int vpsid) { FILE *fp; - char *line =3D NULL; + g_autofree char *line =3D NULL; size_t line_size =3D 0; unsigned long long usertime, systime, nicetime; int readvps =3D vpsid + 1; /* ensure readvps is initially different */ @@ -1442,7 +1436,6 @@ Version: 2.2 } } =20 - VIR_FREE(line); VIR_FORCE_FCLOSE(fp); if (err) return -1; --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Fri May 10 19:04:17 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 171075293452480.20914728572188; Mon, 18 Mar 2024 02:08:54 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 617EE1B31; Mon, 18 Mar 2024 05:08:53 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8D0E91C02; Mon, 18 Mar 2024 05:03:17 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4A3B81AA7; Sun, 17 Mar 2024 10:29:11 -0400 (EDT) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9ADBA198E for ; Sun, 17 Mar 2024 10:29:10 -0400 (EDT) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-33e162b1b71so3236547f8f.1 for ; Sun, 17 Mar 2024 07:29:10 -0700 (PDT) Received: from karim.localdomain ([197.39.159.115]) by smtp.gmail.com with ESMTPSA id dd12-20020a0560001e8c00b0033eab3520a9sm7624414wrb.43.2024.03.17.07.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 07:29:08 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710685749; x=1711290549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=up51k0jI5aLsUYnyMMfG7qqbNMkee0eR2+AQxf+7Tro=; b=E57b8PvsC/EHnQ7fpRIYATyKHkVZGudg926p7V7NuEnluyBoF6G0yzT/k5/z1qRXQr Wja6qDsGFcn4ZQOiNTReusCU7YATwQDeQyo2sDaPyrJJXmDAY1M7ybQwkVlwCgGLuyzQ a83NA1y6Aqp7/ShVMJ5O3SvEH+y4opUn9hgd1D+CjVj1gZSdyC2tSpdOe2FEyDOS97lr mI7KvprtJh9Fi6pFj0g+19dTk5D0JRTcsOq5upzamVEkHQ1jgjqw1Lk/DE4D1Z5lEddi bboxDgo50cb/COr4uCE6KHTpwo57CO8ykELBsmcA+G/sON2NFCp+VElYM9Vao8tePYDX k2Fw== X-Gm-Message-State: AOJu0Ywh66ZIbixvNwK6EsiLQNCytFRs5k69ZQroCLnhj8zjGxfDqTOj Fsi3obFGoi4jFgQTZjqdECRN9l1R/SnQacW29t2fIFGq6FfZU6gzopxf4s25 X-Google-Smtp-Source: AGHT+IHS70bRsOlMT5nWq4XyIpZKe77tZ//PENKJOvnel0C/DJx+cNGX1thb56stPAq+GEnqUvkVvg== X-Received: by 2002:a5d:5270:0:b0:33e:c8f2:9633 with SMTP id l16-20020a5d5270000000b0033ec8f29633mr6015210wrc.28.1710685748896; Sun, 17 Mar 2024 07:29:08 -0700 (PDT) From: Karim Taha To: devel@lists.libvirt.org Subject: [PATCH 2/2] node_device: use g_autofree instead of VIR_FREE in node_device_driver.c Date: Sun, 17 Mar 2024 16:24:36 +0200 Message-ID: <20240317142658.228736-5-kariem.taha2.7@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240317142658.228736-1-kariem.taha2.7@gmail.com> References: <20240317142658.228736-1-kariem.taha2.7@gmail.com> MIME-Version: 1.0 X-MailFrom: kariem.taha2.7@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: BZVDCG6P2IBYRV2TAHTSJQHHO7NSZLDD X-Message-ID-Hash: BZVDCG6P2IBYRV2TAHTSJQHHO7NSZLDD X-Mailman-Approved-At: Mon, 18 Mar 2024 09:02:54 -0400 CC: mprivozn@redhat.com, Karim Taha X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710752934759100001 Signed-off-by: Karim Taha --- src/node_device/node_device_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index ce42b1ca63..d99b48138e 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -439,7 +439,7 @@ nodeDeviceListCaps(virNodeDevicePtr device, { virNodeDeviceObj *obj; virNodeDeviceDef *def; - virNodeDevCapType *list =3D NULL; + g_autofree virNodeDevCapType *list =3D NULL; int ncaps =3D 0; int ret =3D -1; size_t i =3D 0; @@ -472,8 +472,6 @@ nodeDeviceListCaps(virNodeDevicePtr device, for (j =3D 0; j < i; j++) VIR_FREE(names[j]); } - - VIR_FREE(list); return ret; } =20 --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org