From nobody Wed May 15 10:02:01 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710752789143354.4404133937645; Mon, 18 Mar 2024 02:06:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 0CEA91C76; Mon, 18 Mar 2024 05:06:28 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 16D401DAA; Mon, 18 Mar 2024 05:03:01 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CD97A1986; Sun, 17 Mar 2024 10:20:40 -0400 (EDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 1149B1986 for ; Sun, 17 Mar 2024 10:20:40 -0400 (EDT) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-513da1c1f26so3312954e87.3 for ; Sun, 17 Mar 2024 07:20:40 -0700 (PDT) Received: from karim.localdomain ([197.39.159.115]) by smtp.gmail.com with ESMTPSA id h10-20020a05600c350a00b00412ee8e2f2asm15088865wmq.9.2024.03.17.07.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 07:20:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710685238; x=1711290038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G8DH5Tp5kCW9ZCiMR08ThxhCa4cWHLLOTriQ+2n4qbc=; b=WMsbrQt/Z3+HzP/nEkUy/JMy+DExlelQGc7FSszujsMVPssw7UkJepkYvShpSKHQwI RtRrPODm+jQDUde9iMBiPSMn3BM8lyMHwRUVhEQUdgXK1qErZZGSOPtS80t0Zu3JFi7u Zu2KXgj5iwbbNGKbjEPbUn2shKN4FbyuLWnRo0GBSongTS1KD8k9Kc+M39BmIuMmJ6vV A8CAH5vDUruPR5tobpz7OiTuUahjySWaaFR2wRSD9bTdIFsHx6/9zUTmgrm+a3Yq1nBF bHqckiC/xdKzzraB84mc741s4Ss/YBlcgAVrosnR6a19Ee48K5VLKZ3DwMWMKgEfhuuI VhNQ== X-Gm-Message-State: AOJu0YwnqQf9QfKBf97M3NQ5tu1/sUNYWbvEXAdPVYUqKvSku3I2gSYn 81EJji7ddaqpDgYEaEdPA797VryksK5cyFUHLjSC59uvefGTOT5gsccgL29g X-Google-Smtp-Source: AGHT+IGPRjBqIwofn3hpDu4DnxIhLR2flYM5M03Ni8e6uoF94DV+bOR+SbyhVxMa+DZ2LaNs40jYkw== X-Received: by 2002:a19:ca11:0:b0:513:dda5:a38d with SMTP id a17-20020a19ca11000000b00513dda5a38dmr3032034lfg.25.1710685237642; Sun, 17 Mar 2024 07:20:37 -0700 (PDT) From: Karim Taha To: devel@lists.libvirt.org Subject: [PATCH 1/2] openvz_driver: use g_autofree instead of VIR_FREE in openvz_driver.c Date: Sun, 17 Mar 2024 16:18:28 +0200 Message-ID: <20240317141851.227873-2-kariem.taha2.7@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240317141851.227873-1-kariem.taha2.7@gmail.com> References: <20240317141851.227873-1-kariem.taha2.7@gmail.com> MIME-Version: 1.0 X-MailFrom: kariem.taha2.7@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: Y4CHH3INPCB7EWFQK6ON7QYVLXW7ZZ6M X-Message-ID-Hash: Y4CHH3INPCB7EWFQK6ON7QYVLXW7ZZ6M X-Mailman-Approved-At: Mon, 18 Mar 2024 09:02:54 -0400 CC: mprivozin@redhat.com, Kariiem , Karim Taha X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710752790318100001 From: Kariiem Signed-off-by: Karim Taha --- src/openvz/openvz_driver.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 1bd96dfb56..fd3c25a393 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -615,7 +615,7 @@ openvzGenerateVethName(int veid, char *dev_name_ve) static char * openvzGenerateContainerVethName(int veid) { - char *temp =3D NULL; + g_autofree char *temp =3D NULL; char *name =3D NULL; =20 /* try to get line "^NETIF=3D..." from config */ @@ -638,8 +638,6 @@ openvzGenerateContainerVethName(int veid) name =3D g_strdup_printf("eth%d", max + 1); } =20 - VIR_FREE(temp); - return name; } =20 @@ -750,7 +748,7 @@ openvzDomainSetNetworkConfig(virConnectPtr conn, { size_t i; g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; - char *param; + g_autofree char *param =3D NULL; int first =3D 1; struct openvz_driver *driver =3D conn->privateData; =20 @@ -774,12 +772,10 @@ openvzDomainSetNetworkConfig(virConnectPtr conn, param =3D virBufferContentAndReset(&buf); if (param) { if (openvzWriteVPSConfigParam(strtoI(def->name), "NETIF", para= m) < 0) { - VIR_FREE(param); virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot replace NETIF config")); return -1; } - VIR_FREE(param); } } =20 @@ -1075,7 +1071,7 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autos= tart) { struct openvz_driver *driver =3D dom->conn->privateData; virDomainObj *vm; - char *value =3D NULL; + g_autofree char *value =3D NULL; int ret =3D -1; =20 if (!(vm =3D openvzDomObjFromDomain(driver, dom->uuid))) @@ -1093,8 +1089,6 @@ openvzDomainGetAutostart(virDomainPtr dom, int *autos= tart) ret =3D 0; =20 cleanup: - VIR_FREE(value); - virDomainObjEndAPI(&vm); return ret; } @@ -1405,7 +1399,7 @@ static int openvzConnectListDefinedDomains(virConnect= Ptr conn G_GNUC_UNUSED, static int openvzGetProcessInfo(unsigned long long *cpuTime, int vpsid) { FILE *fp; - char *line =3D NULL; + g_autofree char *line =3D NULL; size_t line_size =3D 0; unsigned long long usertime, systime, nicetime; int readvps =3D vpsid + 1; /* ensure readvps is initially different */ @@ -1442,7 +1436,6 @@ Version: 2.2 } } =20 - VIR_FREE(line); VIR_FORCE_FCLOSE(fp); if (err) return -1; --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Wed May 15 10:02:01 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1710752824729972.3587629462684; Mon, 18 Mar 2024 02:07:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 637DA1B90; Mon, 18 Mar 2024 05:07:03 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 5A16B1E17; Mon, 18 Mar 2024 05:03:03 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8CBFA1AA7; Sun, 17 Mar 2024 10:20:44 -0400 (EDT) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 07A201AA7 for ; Sun, 17 Mar 2024 10:20:44 -0400 (EDT) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4140eb3aeb9so1855345e9.3 for ; Sun, 17 Mar 2024 07:20:43 -0700 (PDT) Received: from karim.localdomain ([197.39.159.115]) by smtp.gmail.com with ESMTPSA id h10-20020a05600c350a00b00412ee8e2f2asm15088865wmq.9.2024.03.17.07.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Mar 2024 07:20:41 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710685242; x=1711290042; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cOHBg34pgw9FZiragsvvcozM2X7vIZkQt/WGLjd+/0I=; b=Wo1xGXffpAfnRDGL9D+7uVUg/+Kfx8pgeWqjEbRNXOY0vzXoTjIYOSaWs6KOU7+5Zb 5aPhR7Lfl4Hrf3oijKiX5CsuzdxvlkYmR9bB99bBv6MxWF8F/EsBmXdWoQgni+XbMdfP wH84IFUIoxMsfCuspd/YuuALCGzftA6mKo3u2Ow4Nif55xKvMPWv6ViHzOZZ+49ms96Q QRQFC/SFV6188/volbsjh0m4C4/4ZSRRVnnlqEwQ8jhLKM7F8DiT2iCE1GkI6WNyqt9i YHfPrb5E4vlLbsKNSaDUj5IK/JJQsO8NRtlt7f8QdJNzS1H0uEtuHX4+B6YVYA7gGbmI 2eyA== X-Gm-Message-State: AOJu0YxNiPbMKz/gsfvHfz2SU/Lkra+err+aMWwL/NDUPf0CvufkTUMz kUfqx1Toug1tRo1qjBxR5DNviU+tC02JI6aeXwRDBfVUa7ZA/E3IiUnIGrAm X-Google-Smtp-Source: AGHT+IGvtW6pNLwe2nwudRzaHrfVGcrAxs4CI9ZKdnA1X80yr9FWhZBjZebr191oFprNvZWrduNgWA== X-Received: by 2002:a05:600c:3516:b0:414:6f7:cbdc with SMTP id h22-20020a05600c351600b0041406f7cbdcmr2913153wmq.13.1710685242382; Sun, 17 Mar 2024 07:20:42 -0700 (PDT) From: Karim Taha To: devel@lists.libvirt.org Subject: [PATCH 2/2] node_device: use g_autofree instead of VIR_FREE in node_device_driver.c Date: Sun, 17 Mar 2024 16:18:29 +0200 Message-ID: <20240317141851.227873-3-kariem.taha2.7@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240317141851.227873-1-kariem.taha2.7@gmail.com> References: <20240317141851.227873-1-kariem.taha2.7@gmail.com> MIME-Version: 1.0 X-MailFrom: kariem.taha2.7@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: MQRKLYUKQBHYDBHUCSVKZGHK6SX4PVYS X-Message-ID-Hash: MQRKLYUKQBHYDBHUCSVKZGHK6SX4PVYS X-Mailman-Approved-At: Mon, 18 Mar 2024 09:02:54 -0400 CC: mprivozin@redhat.com, Kariiem , Karim Taha X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1710752826439100001 From: Kariiem Signed-off-by: Karim Taha --- src/node_device/node_device_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index ce42b1ca63..d99b48138e 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -439,7 +439,7 @@ nodeDeviceListCaps(virNodeDevicePtr device, { virNodeDeviceObj *obj; virNodeDeviceDef *def; - virNodeDevCapType *list =3D NULL; + g_autofree virNodeDevCapType *list =3D NULL; int ncaps =3D 0; int ret =3D -1; size_t i =3D 0; @@ -472,8 +472,6 @@ nodeDeviceListCaps(virNodeDevicePtr device, for (j =3D 0; j < i; j++) VIR_FREE(names[j]); } - - VIR_FREE(list); return ret; } =20 --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org