From nobody Tue Feb 10 19:15:38 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1709204535534995.5582639817097; Thu, 29 Feb 2024 03:02:15 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6AAE81C55; Thu, 29 Feb 2024 06:02:14 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 29CC21A99; Thu, 29 Feb 2024 05:57:51 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 73E051A5E; Thu, 29 Feb 2024 05:57:26 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E0F851A53 for ; Thu, 29 Feb 2024 05:57:25 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-r3Awj_cPM5-KlU1jkrA00g-1; Thu, 29 Feb 2024 05:57:23 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B5E5E868A20 for ; Thu, 29 Feb 2024 10:57:23 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E8952026D0A for ; Thu, 29 Feb 2024 10:57:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: r3Awj_cPM5-KlU1jkrA00g-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [RFC 3/4] syntax-check: Ensure WITH_ macros are used correctly Date: Thu, 29 Feb 2024 11:57:18 +0100 Message-ID: <20240229105719.2045276-4-abologna@redhat.com> In-Reply-To: <20240229105719.2045276-1-abologna@redhat.com> References: <20240229105719.2045276-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: ER5K7ZNOXTB3KKLXEG2T6F6FRM4RYL6D X-Message-ID-Hash: ER5K7ZNOXTB3KKLXEG2T6F6FRM4RYL6D X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709204536383100001 They are supposed to always be defined, with their value reflecting the availability of the corresponding feature, so using #ifdef or #if defined() with them is incorrect. Signed-off-by: Andrea Bolognani --- build-aux/syntax-check.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 2ac8c5760f..067f47ac03 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1347,6 +1347,11 @@ sc_rst_since: halt=3D'format :since: correctly' \ $(_sc_search_regexp) =20 +sc_with_ifdef: + @prohibit=3D'^# *(ifdef +|ifndef +|if.*defined\()WITH_' \ + halt=3D'do not use #ifdef or #if defined() for WITH_ macros' \ + $(_sc_search_regexp) + =20 ## ---------- ## ## Exceptions ## --=20 2.43.2 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org