From nobody Tue Feb 10 03:37:49 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=oracle.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1709189707905668.0767035613069; Wed, 28 Feb 2024 22:55:07 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id D2DC01AAC; Thu, 29 Feb 2024 01:54:59 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 004291A49; Thu, 29 Feb 2024 01:53:38 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 77D6D1A49; Thu, 29 Feb 2024 01:53:34 -0500 (EST) Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BD0021987 for ; Thu, 29 Feb 2024 01:53:31 -0500 (EST) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41T1xxZ1004267 for ; Thu, 29 Feb 2024 06:47:01 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wf90vchk2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 29 Feb 2024 06:47:00 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41T5VZCs001763 for ; Thu, 29 Feb 2024 06:46:59 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wf6wa2trp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 29 Feb 2024 06:46:59 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:421::12) by CH2PR10MB4150.namprd10.prod.outlook.com (2603:10b6:610:ac::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Thu, 29 Feb 2024 06:46:57 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::64bd:3256:48da:16cc]) by SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::64bd:3256:48da:16cc%7]) with mapi id 15.20.7316.039; Thu, 29 Feb 2024 06:46:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qo/tG0aLMxQbt3VAsB7d0YkhPK3K8nqOQvou/GGKKYzJj/pueIGrokjAyKn9rp4zHdHifsMV+M5LZ3hEMkphEOhcWGMcMrIhg9walY80f0UKPOABsSbsPpi/Sr/iLcD00pwJTpxaYCYJPMrqQckawUPbEcmi8i6Rtjrd5P1gb3KzTciVEFd7L0XoIL4AOSib6S1iBrxXjx2nEZgvs3JNvEWJAKITCgu+8rA44WkM+x9FQhxmUkA/GYbpppasftM9f7CtEO9AuAupgZecuzRjmF/DlkqMkwO/LfOc36Koo+cJiyhowBrR+03U/P0doeVbd0zKHq0j0SKTbeaBKEI2UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rfpiM8bgMj9zOtajmfgfzxcPE/Z/1/TBrUAmTetwUIk=; b=MJ7lgtDrm6htwoPwbkUO3lKHKHLZyOsWWFsM6j53QakIc/5YADTBXaihGpTZS529iHlJP9KccRJUi9OJhg0UzUa9oRvLNXVm4Mq4XdPZbCw/vhpmKNQCMA40DVXZA7c+4Ij635Odr7m6gizq33MMVewYHQ0auWX/RtGQupuWQmH7rELJP+I6+dHhOKcW/0utF6mJK031fJb1sun/PPIHEU8Pi1L/58tmvjX0tTzCA03srESymSbhxS+mpB3JWQcKDakKFJ2FTDJGG86zZ12fprME3iuglFfOlgRCQVOAQDHBX54N5SoejOjYoVuoI0TYsGMa35b0UaqoFOLDPzbDOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none From: Shaleen Bathla To: devel@lists.libvirt.org Subject: [libvirt] [PATCH 1/4] logging: virtlogd: Add option to append timestamp to domain logs Date: Thu, 29 Feb 2024 12:16:36 +0530 Message-Id: <20240229064639.1731653-2-shaleen.bathla@oracle.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240229064639.1731653-1-shaleen.bathla@oracle.com> References: <20240229064639.1731653-1-shaleen.bathla@oracle.com> X-ClientProxiedBy: BY5PR17CA0041.namprd17.prod.outlook.com (2603:10b6:a03:167::18) To SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:421::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5768:EE_|CH2PR10MB4150:EE_ X-MS-Office365-Filtering-Correlation-Id: f596e8a8-e030-41f5-43ef-08dc38f23979 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eolqVuLRW8CkHCEeukmPTWM4ubQnbsClqGbuO+TEMsSl2J1yUBZ08/v3UWE3tnuzHcdnboUGArQNFFI/O0afRRTAwNkX5SmbOh1+fBai/T02X7dCgl49ReA5nsCdkWZTbjumNWGPrj0rsslS78kG3Zn/ujjx1Id0eGTMDYGXLL1u9ga0QpsjOB6MufUlzJOYjhl7Ku9ue25Z5xjD/OZopcRCz3nhqt5dTe3Ku5D5snBvtE7Gj4qO/dPVKlcCkEDysN26C9vFRU5j1injzTZ7cRbWhlpldXTcKBe4Bn03B1vehJCj+YWDHZn83XXf2NKkDrGqZsyM09bRPv0tt9IBFE65b+9rcvTwP3jVIekgSFkMMQUpVMHmtZPPHfn/zdV8ALTtcPZYesOMGt3E1UlZuxcqyxV1z6DhElko5N9fqeHlJx+AeAN/x2U+kp9woeDBCsCwJqhhImEON8xx2LjOfZIPUsfLhrEFe7dbf8uNy42sK6IJ3yNGf3GSn1wU4gBzXgz33uuZKYN5k/sZ5BFf1bLpwjkWdLl4tqkn9Y1KvUDgMpqgZdre7iqkSnuy2TQymPuhDbOhaWFZj4lr/j6cl0dJDdGvZyZ0Q39+HsPzmHxanWW1ANj9GXMTd2U/VJ4BkxCGxZbKhpEAuHGo3jYYeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5768.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YUJMNV4VPVvzDSjAh8ScmELJouh66iUe1CZjp05WDwdifv79Sxbj8PQGKDtD?= =?us-ascii?Q?gM9WqW/wcurSH4s8j75aXoNuPawIhc+ZCQvw/Zjlx/zD+Jx+oBhhTDznuVyS?= =?us-ascii?Q?mR+QnwMX/qjq9HHBQofnZpMhYmAHh7Vz0lVSfW+NLOW0lVlQrUqeDR8QIF6s?= =?us-ascii?Q?GKPOJKwmXd9MGUbh/Vb0nEczyLe+ut7l9tevGtzPNamg+o49iEe+PY18yaL2?= =?us-ascii?Q?YsQrknP8QibUW/CHSqU+XEzI3kP4pUdjIbX89N2Z11q9aIswxbdruX/cjanW?= =?us-ascii?Q?DZTqAMfraZbLiLzt9dPqg3xiSYavWw6hEdR+w2JyXdQPrafCWwEGFJEZDUL7?= =?us-ascii?Q?WHg1LF0y1+iOJw5gqgihJhN1MmZyDj2G5L7frtX1vifNIFy2XqVE1GRE80xz?= =?us-ascii?Q?/KGptPvvc01CTtpom93K5fhuRzktLvY2Pgxe65c4QRMVUbYmqZIGHJuGw/Vh?= =?us-ascii?Q?kNKB4I1I7A6ZDfMNkI1+nQpWihs+mXEH/LEN6Uj/aL+yyiHA4LohAVan4xhU?= =?us-ascii?Q?JgBWEjokgN5XfiBOtOSwzuC3LQF/gt4twx4e4Agaj62r705C0U4KoxqPC7/q?= =?us-ascii?Q?11QGxkonOD9ZCuSfZ/mF7YnIem6iDiYPG2Y1TpPnNy99grUUgsJDzb/4vxBm?= =?us-ascii?Q?4Emsnwyu7wsYvWfmQMA2FA/qVzHGpW5POwtMVBRzVxl2oRMrBbP4Yi4gqKPa?= =?us-ascii?Q?Em18+4NnE6fuvE/RuwCAiqaRjE/JA1NQKfNfYvQ16r0olC9wnt0LYw+TKFTq?= =?us-ascii?Q?eRdmsCE5KMfmHLZT+M7XEhDAQCXbnApEpRsIBDykqajEzjmZYEd0aMnU2+TN?= =?us-ascii?Q?+Xrr3CMKoMrKlXllw9kr8AMSKbHdJi+89Gq712kDGYgaDCtDhwjAa5CH2/aQ?= =?us-ascii?Q?t6GZWT3X7wTnJNC3lQrW4iU9AxgsdFWmrhwFzpyz0bxhHczm7hSVm8NxjcvL?= =?us-ascii?Q?d0dVNpcgNCGm47e1mYntXTcFX0wDpedzn3Z/r3W4uOCx2NmaO7lNVhCnWuTg?= =?us-ascii?Q?KVH7T9G+znM95urAppR493vlKVWaNVyTckeZpf6szoAXm6nH4RdvuM7j/nRv?= =?us-ascii?Q?cWIiMLK4BK+FAab7yyky/gSIZDanRpVylmPc6+ZW3K9oZLpi723CMkggIyqR?= =?us-ascii?Q?3bw0JIMjxWSLcQUiB1CqUWDqfnOXReWEnZ+TM5yilpPc4ttzARJWBMtFBN/N?= =?us-ascii?Q?RV6erbJeErTvsxUEi7cKVWYafaFfN/EQS52+MrVaNRA1ZBVWHd6VNpP4ZwAL?= =?us-ascii?Q?zE5AKMsN59TmWAsHCPsFXv9v7fcxogZMpJVG9D0f31IFt9Pb0jZNfZAAXaHb?= =?us-ascii?Q?+jf2Pb7cTHs76ii7pd5VjZ1tzkdmPlEtwa54EqHtyrDtP4XGJzhDAkIGTVPd?= =?us-ascii?Q?7T2lqio9MnkWUNbwiNn/8dt0Vy6YTRub2KnexMbrymtOazHzWcClE8EtqGLT?= =?us-ascii?Q?zkbHDqhiuOprKADlXKbzDeRj0G+sGkqSWu8K0GdltyPGHpIgZGbShKrwmazH?= =?us-ascii?Q?+eAU4jQaaaltyYunpVETBWkuFz7SWdtK0U6eMCLWeWXqklA5tw5AhqnA1mLl?= =?us-ascii?Q?s+X4M0TniN6LrQpEQAjilGnYUWt1zlB4jHuKVBEQQpMFr+/jgi8RqkPsPsVC?= =?us-ascii?Q?QA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DizqaGt3zoyoXMFjw79KOfzUmSPVQf14PgOyY77iBCaRVO9i0DzAx84ved0l97Jaft6xeoauhr2puAh4loOj5ercfFam+ayNAJhW1A6NYtHrbwI2qkzEewqLHNGCPk7dTETj2MvSqC3Y00dhsImAFVls++3Zx5Z41CrFbvPCTPdrsjIWRoInfAlN7P8qZT92aGUjPET50X/bqRmoBFcrp3KR/yASiHgSkgzPnf6f8GoWYCvpUhFc598KyqbOgRiAiJy3NIrzxat0JQGP0Sjno0u+BI2la2sipUQHUMWxioMQKHvZ1G1yqpVU6UvXwcIbE8uuN7KhKWFoJJFgVh1LFbPc0ZQtDA8+wQg12sW2qlDsCxmwKIncFAosTL+QGV+s4mKRaXYP3nr19hHFZI6Ob0qqYh57CHC2hehJoCtPyOkZvics4pFfDscHHfv1Sd4Je3t7K/sB+vOc7S9A01GXUcoHB7d0JuPIlpxkOvIVqCgpkrFLT9Fni1L0zvb9fqbw+OFaw2DbODN69NU4gMWqxLTaQdIQjJPHpY0pIRL0Af4pajRaFAYJQsTpDu5mRS+44JgieeqznfwJvV2AMLNnDdkjEB58UP+c9TTz08KSxBE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f596e8a8-e030-41f5-43ef-08dc38f23979 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5768.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 06:46:57.8045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0tlj3F0TdoLMsnSCSPGae1DTPlO8jMI+92SIqUf38KswvDkSA9M0AXsRNVguxhTWMHcO1O7vgi9zivzw7sZSuYscGqddzEenhCaRDUU884Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4150 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-28_08,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402290051 X-Proofpoint-GUID: WCwRPt8vlwQQt5iikDI3vOigYFDmnpiM X-Proofpoint-ORIG-GUID: WCwRPt8vlwQQt5iikDI3vOigYFDmnpiM Message-ID-Hash: APGBA7KWOCEA6PFEPI73GWSRYHFF6NO5 X-Message-ID-Hash: APGBA7KWOCEA6PFEPI73GWSRYHFF6NO5 X-MailFrom: shaleen.bathla@oracle.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1709189709323100001 In virtlogd.conf, introduce a new timestamp option. When set to 1, timestamp is appended after \n in serial console logs. Signed-off-by: Shaleen Bathla --- src/logging/log_daemon_config.c | 3 +++ src/logging/log_daemon_config.h | 1 + src/logging/test_virtlogd.aug.in | 1 + src/logging/virtlogd.aug | 1 + src/logging/virtlogd.conf | 4 ++++ 5 files changed, 10 insertions(+) diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_confi= g.c index 248bd927d3f0..278e4c0a7832 100644 --- a/src/logging/log_daemon_config.c +++ b/src/logging/log_daemon_config.c @@ -62,6 +62,7 @@ virLogDaemonConfigNew(bool privileged G_GNUC_UNUSED) data->max_size =3D 1024 * 1024 * 2; data->max_backups =3D 3; data->max_age_days =3D 0; + data->timestamp =3D 0; =20 return data; } @@ -101,6 +102,8 @@ virLogDaemonConfigLoadOptions(virLogDaemonConfig *data, return -1; if (virConfGetValueString(conf, "log_root", &data->log_root) < 0) return -1; + if (virConfGetValueBool(conf, "timestamp", &data->timestamp) < 0) + return -1; if (!data->log_root) data->log_root =3D g_strdup(DEFAULT_LOG_ROOT); =20 diff --git a/src/logging/log_daemon_config.h b/src/logging/log_daemon_confi= g.h index 43922feedf6e..8fe3ac460cb8 100644 --- a/src/logging/log_daemon_config.h +++ b/src/logging/log_daemon_config.h @@ -36,6 +36,7 @@ struct _virLogDaemonConfig { =20 char *log_root; size_t max_age_days; + bool timestamp; }; =20 =20 diff --git a/src/logging/test_virtlogd.aug.in b/src/logging/test_virtlogd.a= ug.in index 8dfad3950608..dfae4fff15fd 100644 --- a/src/logging/test_virtlogd.aug.in +++ b/src/logging/test_virtlogd.aug.in @@ -11,3 +11,4 @@ module Test_virtlogd =3D { "max_backups" =3D "3" } { "max_age_days" =3D "0" } { "log_root" =3D "/var/log/libvirt" } + { "timestamp" =3D "0" } diff --git a/src/logging/virtlogd.aug b/src/logging/virtlogd.aug index bdf61dea6eb5..a1e5c09bbb04 100644 --- a/src/logging/virtlogd.aug +++ b/src/logging/virtlogd.aug @@ -33,6 +33,7 @@ module Virtlogd =3D | int_entry "max_backups" | int_entry "max_age_days" | str_entry "log_root" + | bool_entry "timestamp" =20 (* Each entry in the config is one of the following three ... *) let entry =3D logging_entry diff --git a/src/logging/virtlogd.conf b/src/logging/virtlogd.conf index 5214e96121a1..2c45f3da2e3d 100644 --- a/src/logging/virtlogd.conf +++ b/src/logging/virtlogd.conf @@ -115,3 +115,7 @@ # WARNING: all files under this location potentially can be GC-ed. See the # warning for max_age_days. #log_root =3D "/var/log/libvirt" + +# Append timestamp to serial console logs after every '\n' character +# Defaults to 0 i.e. turned off +#timestamp =3D 0 --=20 2.39.3 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org