From nobody Fri Oct 18 04:27:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1706947420; cv=none; d=zohomail.com; s=zohoarc; b=GaxPTR0+V5ZFtpvvo63/p2MeR13WEdUZ+gU6tC85SJUtf0RtPxstf0nXKmj9iegpnaCWl9zEPC8PwNLziSR95ibXPBNcSB2utfq2uGsQzDNOe+f9SW/9wB2HOMDg7L9r8fuUf/9NuusWeSIAq/l9RkgAonP/rrquT/1ZL/dLCvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706947420; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gAhVpQ6CazB2erF7VMaPN47/vqDQtUf1vrvl2TGeyUE=; b=DvFz77gWOqX1f193rzRUIW64hItoq9CiADZDmSutAgneni38we6vn8yV4aGr8tHzPU8gdNzosPdY1jmVAuTagx6RgbuPUDyNLgMqkvJ1mXNJuGSAXxdsIjDh9voxrEYOClIyGcA6vChrXY3m+1Cv8qRFhQ4/usO9RoIGWGG3xZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1706947420255121.52555411961703; Sat, 3 Feb 2024 00:03:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rWAz3-0003a6-26; Sat, 03 Feb 2024 03:02:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWAz1-0003Za-Nc for qemu-devel@nongnu.org; Sat, 03 Feb 2024 03:02:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWAz0-00081L-BG for qemu-devel@nongnu.org; Sat, 03 Feb 2024 03:02:39 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-70-6UxLDW5aODS4nAhkwUg7wg-1; Sat, 03 Feb 2024 03:02:34 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EAF2C800074; Sat, 3 Feb 2024 08:02:33 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B30DAC259DD; Sat, 3 Feb 2024 08:02:33 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C4BD021E66F2; Sat, 3 Feb 2024 09:02:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706947357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gAhVpQ6CazB2erF7VMaPN47/vqDQtUf1vrvl2TGeyUE=; b=NBzuoX53KokYGvk/iaPbo+KUR1I9xGtVtkRldfw9uKq6YwVN7C4e0JmWDCUxphvJ+Ap2By Vgix0zh4lgYklRT8vvAKyVRn9Qn9W2G4LXgycCmq0SE1uA4kDnRm3T5WEVHYfjEdf2hu72 hFhWDVtC5/QGMnjmuPhvWf24MUAlclE= X-MC-Unique: 6UxLDW5aODS4nAhkwUg7wg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, pbonzini@redhat.com, devel@lists.libvirt.org, eblake@redhat.com Subject: [PATCH 2/4] tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check Date: Sat, 3 Feb 2024 09:02:26 +0100 Message-ID: <20240203080228.2766159-3-armbru@redhat.com> In-Reply-To: <20240203080228.2766159-1-armbru@redhat.com> References: <20240203080228.2766159-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.276, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1706947421872100005 Content-Type: text/plain; charset="utf-8" qemu_socket() and make_udp_socket() return a file descriptor on success, -1 on failure. The check misinterprets 0 as failure. Fix that. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/unit/test-char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-char.c b/tests/unit/test-char.c index 76946e6f90..e3b783c06b 100644 --- a/tests/unit/test-char.c +++ b/tests/unit/test-char.c @@ -556,7 +556,7 @@ static int make_udp_socket(int *port) socklen_t alen =3D sizeof(addr); int ret, sock =3D qemu_socket(PF_INET, SOCK_DGRAM, 0); =20 - g_assert_cmpint(sock, >, 0); + g_assert_cmpint(sock, >=3D, 0); addr.sin_family =3D AF_INET ; addr.sin_addr.s_addr =3D htonl(INADDR_ANY); addr.sin_port =3D 0; @@ -1401,7 +1401,7 @@ static void char_hotswap_test(void) =20 int port; int sock =3D make_udp_socket(&port); - g_assert_cmpint(sock, >, 0); + g_assert_cmpint(sock, >=3D, 0); =20 chr_args =3D g_strdup_printf("udp:127.0.0.1:%d", port); =20 --=20 2.43.0