From nobody Mon Sep 16 18:49:45 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1706634136916997.0975413302643; Tue, 30 Jan 2024 09:02:16 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id CC27E1CB9; Tue, 30 Jan 2024 12:02:15 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 58C8B1C35; Tue, 30 Jan 2024 11:58:21 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id CC55C1BB0; Tue, 30 Jan 2024 11:57:59 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2C5EA1BB0 for ; Tue, 30 Jan 2024 11:57:59 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-DhG2GjdUOoSxuiwZDYTkaA-1; Tue, 30 Jan 2024 11:57:57 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D583837225 for ; Tue, 30 Jan 2024 16:57:57 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B34741121306 for ; Tue, 30 Jan 2024 16:57:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: DhG2GjdUOoSxuiwZDYTkaA-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [PATCH 3/3] qemu: Use virDomainControllerDefNew() more Date: Tue, 30 Jan 2024 17:57:52 +0100 Message-ID: <20240130165752.1118388-4-abologna@redhat.com> In-Reply-To: <20240130165752.1118388-1-abologna@redhat.com> References: <20240130165752.1118388-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: ZUO2LXWEINFLPCLW35O4TPPSYOKOMIFS X-Message-ID-Hash: ZUO2LXWEINFLPCLW35O4TPPSYOKOMIFS X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1706634170750100001 Instead of open-coding a partial version of it. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_hotplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 137904034d..0f7ffb6506 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -873,9 +873,9 @@ qemuDomainFindOrCreateSCSIDiskController(virDomainObj *= vm, =20 /* No SCSI controller present, for backward compatibility we * now hotplug a controller */ - cont =3D g_new0(virDomainControllerDef, 1); - cont->type =3D VIR_DOMAIN_CONTROLLER_TYPE_SCSI; + cont =3D virDomainControllerDefNew(VIR_DOMAIN_CONTROLLER_TYPE_SCSI); cont->idx =3D controller; + if (model =3D=3D VIR_DOMAIN_CONTROLLER_MODEL_SCSI_DEFAULT) cont->model =3D qemuDomainGetSCSIControllerModel(vm->def, cont, pr= iv->qemuCaps); else --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org