From nobody Thu May 9 03:05:53 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1706634231179917.7266490618448; Tue, 30 Jan 2024 09:03:51 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 1F7D21C18; Tue, 30 Jan 2024 12:03:50 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 168EC1CC5; Tue, 30 Jan 2024 11:58:36 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id CC5481C47; Tue, 30 Jan 2024 11:58:24 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2E5E91BFA for ; Tue, 30 Jan 2024 11:58:04 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-HvstW5v0PYCsSofrdtzqJg-1; Tue, 30 Jan 2024 11:57:55 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF0D58B27AB for ; Tue, 30 Jan 2024 16:57:55 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15B621121306 for ; Tue, 30 Jan 2024 16:57:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: HvstW5v0PYCsSofrdtzqJg-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [PATCH 1/3] tests: Add controller-scsi-auto Date: Tue, 30 Jan 2024 17:57:50 +0100 Message-ID: <20240130165752.1118388-2-abologna@redhat.com> In-Reply-To: <20240130165752.1118388-1-abologna@redhat.com> References: <20240130165752.1118388-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: BKE4PCABXSSGM7MHUE4I75A2J3H6ZISD X-Message-ID-Hash: BKE4PCABXSSGM7MHUE4I75A2J3H6ZISD X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1706634265994100001 The "auto" SCSI controller model was introduced for use in the ESX driver, but the QEMU driver doesn't reject the value. Add a test case showing the behavior when such a configuration is encountered. Signed-off-by: Andrea Bolognani Reviewed-by: Jonathon Jongsma --- .../controller-scsi-auto.x86_64-latest.args | 32 +++++++++++++++++++ .../controller-scsi-auto.x86_64-latest.xml | 30 +++++++++++++++++ .../qemuxmlconfdata/controller-scsi-auto.xml | 15 +++++++++ tests/qemuxmlconftest.c | 1 + 4 files changed, 78 insertions(+) create mode 100644 tests/qemuxmlconfdata/controller-scsi-auto.x86_64-lates= t.args create mode 100644 tests/qemuxmlconfdata/controller-scsi-auto.x86_64-lates= t.xml create mode 100644 tests/qemuxmlconfdata/controller-scsi-auto.xml diff --git a/tests/qemuxmlconfdata/controller-scsi-auto.x86_64-latest.args = b/tests/qemuxmlconfdata/controller-scsi-auto.x86_64-latest.args new file mode 100644 index 0000000000..9283d9ab19 --- /dev/null +++ b/tests/qemuxmlconfdata/controller-scsi-auto.x86_64-latest.args @@ -0,0 +1,32 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-guest \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.local/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.cache \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.config \ +/usr/bin/qemu-system-x86_64 \ +-name guest=3Dguest,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ +-machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Doff \ +-accel tcg \ +-cpu qemu64 \ +-m size=3D219136k \ +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ +-overcommit mem-lock=3Doff \ +-smp 8,sockets=3D8,cores=3D1,threads=3D1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-device '{"driver":"lsi","id":"scsi0","bus":"pci.0","addr":"0x2"}' \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/controller-scsi-auto.x86_64-latest.xml b= /tests/qemuxmlconfdata/controller-scsi-auto.x86_64-latest.xml new file mode 100644 index 0000000000..311f9ae8db --- /dev/null +++ b/tests/qemuxmlconfdata/controller-scsi-auto.x86_64-latest.xml @@ -0,0 +1,30 @@ + + guest + c7a5fdbd-edaf-9455-926a-d65c16db1809 + 219136 + 219136 + 8 + + hvm + + + + qemu64 + + + destroy + restart + destroy + + /usr/bin/qemu-system-x86_64 + +
+ + + + + +