From nobody Fri Oct 18 06:13:37 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 170612947467427.801769711919064; Wed, 24 Jan 2024 12:51:14 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 7580E1BBF; Wed, 24 Jan 2024 15:51:13 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C87B01A5E; Wed, 24 Jan 2024 14:44:00 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 2B0331A06; Wed, 24 Jan 2024 14:39:58 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2B53D19B3 for ; Wed, 24 Jan 2024 14:38:22 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-zyl8YVyONSKyCGciqDFmvg-1; Wed, 24 Jan 2024 14:38:20 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E0A821C068CF for ; Wed, 24 Jan 2024 19:38:19 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.130]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6DB21492BC6 for ; Wed, 24 Jan 2024 19:38:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: zyl8YVyONSKyCGciqDFmvg-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [PATCH 31/33] qemu: Don't add memballoon by default on RISC-V Date: Wed, 24 Jan 2024 20:37:51 +0100 Message-ID: <20240124193753.1265454-32-abologna@redhat.com> In-Reply-To: <20240124193753.1265454-1-abologna@redhat.com> References: <20240124193753.1265454-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: HEABEW35TVGWHVW4D2ANMRTKFG2VUBJJ X-Message-ID-Hash: HEABEW35TVGWHVW4D2ANMRTKFG2VUBJJ X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1706129475447100001 The idea of adding devices such as USB controllers or memory balloons by default comes from attempting to match QEMU's own defaults at a time when x86 was the only game in town. The unfortunate consequence of this is that, if the user does NOT want the device in question to be present, they have to create a special XML element with model=3Dnone to stop libvirt. This is counter-intuitive. For architectures for which we've added support more recently, such as aarch64, we've generally chosen to do the sensible thing and create very minimal guests by default. The user is of course still able to ask for additional hardware if they so desire. When adding RISC-V support, we accidentally forgot to skip the creation of the default memory balloon. Address that oversight. This is technically a breaking change, but it's fairly safe to apply it because: * it doesn't affect existing guests; * virt-manager will automatically add the memballoon device by default anyway; * RISC-V is still not widely used. Signed-off-by: Andrea Bolognani Reviewed-by: Peter Krempa --- src/qemu/qemu_domain.c | 1 - .../riscv64-virt-minimal.riscv64-latest.args | 3 --- .../riscv64-virt-minimal.riscv64-latest.xml | 13 ------------- 3 files changed, 17 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 506f03831c..bf45198c09 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4517,7 +4517,6 @@ qemuDomainDefAddDefaultDevices(virQEMUDriver *driver, =20 case VIR_ARCH_RISCV32: case VIR_ARCH_RISCV64: - addDefaultMemballoon =3D true; if (qemuDomainIsRISCVVirt(def)) addPCIeRoot =3D true; break; diff --git a/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.args= b/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.args index fcb80b009e..c38dddb5fa 100644 --- a/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.args +++ b/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.args @@ -25,9 +25,6 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.= config \ -rtc base=3Dutc \ -no-shutdown \ -boot strict=3Don \ --device '{"driver":"pcie-root-port","port":8,"chassis":1,"id":"pci.1","bus= ":"pcie.0","multifunction":true,"addr":"0x1"}' \ --device '{"driver":"pcie-root-port","port":9,"chassis":2,"id":"pci.2","bus= ":"pcie.0","addr":"0x1.0x1"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.1","add= r":"0x0"}' \ -sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ -msg timestamp=3Don diff --git a/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.xml = b/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.xml index 54363bb426..a96af29587 100644 --- a/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.xml +++ b/tests/qemuxmlconfdata/riscv64-virt-minimal.riscv64-latest.xml @@ -15,19 +15,6 @@ /usr/bin/qemu-system-riscv64 - - - -
- - - - -
-