From nobody Mon Sep 16 19:22:09 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1706126274672324.61825121968775; Wed, 24 Jan 2024 11:57:54 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8F8651A54; Wed, 24 Jan 2024 14:57:53 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D41161909; Wed, 24 Jan 2024 14:39:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id C195E18FA; Wed, 24 Jan 2024 14:38:08 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6182918E5 for ; Wed, 24 Jan 2024 14:38:05 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-8BMz1LwFMjCTlvSp5g4z2A-1; Wed, 24 Jan 2024 14:38:03 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 11D3929AA3A5 for ; Wed, 24 Jan 2024 19:38:03 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.130]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9350D492BC6 for ; Wed, 24 Jan 2024 19:38:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 8BMz1LwFMjCTlvSp5g4z2A-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [PATCH 09/33] qemu: Fix a few comments Date: Wed, 24 Jan 2024 20:37:29 +0100 Message-ID: <20240124193753.1265454-10-abologna@redhat.com> In-Reply-To: <20240124193753.1265454-1-abologna@redhat.com> References: <20240124193753.1265454-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: G3LJUXTHJ63GG5NSPQWKQGMFA6EDBI3F X-Message-ID-Hash: G3LJUXTHJ63GG5NSPQWKQGMFA6EDBI3F X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1706126274863100001 They reference functions that have since been renamed. Signed-off-by: Andrea Bolognani Reviewed-by: Peter Krempa --- src/qemu/qemu_command.c | 6 +++--- src/qemu/qemu_domain.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b8f071ff2a..4aad7066e9 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2817,7 +2817,7 @@ qemuBuildControllerPCIDevProps(virDomainControllerDef= *def, =20 =20 /** - * qemuBuildControllerDevStr: + * qemuBuildControllerDevProps: * @domainDef: domain definition * @def: controller definition * @qemuCaps: QEMU binary capabilities @@ -3070,10 +3070,10 @@ qemuBuildControllersByTypeCommandLine(virCommand *c= md, * * Note that we *don't* want to end up with the legacy USB * controller for q35 and virt machines, so we go ahead and - * fail in qemuBuildControllerDevStr(); on the other hand, + * fail in qemuBuildControllerDevProps(); on the other hand, * for s390 machines we want to ignore any USB controller * (see 548ba43028 for the full story), so we skip - * qemuBuildControllerDevStr() but we don't ultimately end + * qemuBuildControllerDevProps() but we don't ultimately end * up adding the legacy USB controller */ continue; } diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index de36641137..7292739d1f 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5597,7 +5597,7 @@ qemuDomainControllerDefPostParse(virDomainControllerD= ef *cont, * chance we will get away with using the legacy USB controller * when the relevant device is not available. * - * See qemuBuildControllerDevCommandLine() */ + * See qemuBuildControllersCommandLine() */ =20 /* Default USB controller is piix3-uhci if available. */ if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX3_USB_UHCI)) --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org