[PATCH 04/33] tests: Drop existing <title> and <description> tags

Andrea Bolognani posted 33 patches 10 months, 3 weeks ago
There is a newer version of this series
[PATCH 04/33] tests: Drop existing <title> and <description> tags
Posted by Andrea Bolognani 10 months, 3 weeks ago
Now that we have an explicit test case for the feature, we can
drop a bunch of duplicated accidental coverage.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 tests/qemuxmlconfdata/440fx-wrong-root.xml                   | 5 -----
 .../cpu-host-model-features.x86_64-latest.xml                | 5 -----
 tests/qemuxmlconfdata/cpu-host-model-features.xml            | 5 -----
 .../cpu-host-passthrough-features.x86_64-latest.xml          | 5 -----
 tests/qemuxmlconfdata/cpu-host-passthrough-features.xml      | 5 -----
 tests/qemuxmlconfdata/cpu-tsc-frequency.x86_64-latest.xml    | 5 -----
 tests/qemuxmlconfdata/cpu-tsc-frequency.xml                  | 5 -----
 tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.xml | 1 -
 tests/qemuxmlconfdata/disk-cdrom-bus-other.xml               | 1 -
 tests/qemuxmlconfdata/minimal.x86_64-latest.xml              | 5 -----
 tests/qemuxmlconfdata/minimal.xml                            | 5 -----
 tests/qemuxmlconfdata/missing-machine.xml                    | 1 -
 12 files changed, 48 deletions(-)

diff --git a/tests/qemuxmlconfdata/440fx-wrong-root.xml b/tests/qemuxmlconfdata/440fx-wrong-root.xml
index 803f28d569..9197b21c06 100644
--- a/tests/qemuxmlconfdata/440fx-wrong-root.xml
+++ b/tests/qemuxmlconfdata/440fx-wrong-root.xml
@@ -1,11 +1,6 @@
 <domain type='qemu'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <os>
diff --git a/tests/qemuxmlconfdata/cpu-host-model-features.x86_64-latest.xml b/tests/qemuxmlconfdata/cpu-host-model-features.x86_64-latest.xml
index 0d4b236371..dd927e1075 100644
--- a/tests/qemuxmlconfdata/cpu-host-model-features.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/cpu-host-model-features.x86_64-latest.xml
@@ -1,11 +1,6 @@
 <domain type='kvm'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/cpu-host-model-features.xml b/tests/qemuxmlconfdata/cpu-host-model-features.xml
index 6a00b34136..c13ae375d6 100644
--- a/tests/qemuxmlconfdata/cpu-host-model-features.xml
+++ b/tests/qemuxmlconfdata/cpu-host-model-features.xml
@@ -1,11 +1,6 @@
 <domain type='kvm'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/cpu-host-passthrough-features.x86_64-latest.xml b/tests/qemuxmlconfdata/cpu-host-passthrough-features.x86_64-latest.xml
index 35c99b533a..02bddfb145 100644
--- a/tests/qemuxmlconfdata/cpu-host-passthrough-features.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/cpu-host-passthrough-features.x86_64-latest.xml
@@ -1,11 +1,6 @@
 <domain type='kvm'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/cpu-host-passthrough-features.xml b/tests/qemuxmlconfdata/cpu-host-passthrough-features.xml
index d8bd36c1f2..e87b5fe2f1 100644
--- a/tests/qemuxmlconfdata/cpu-host-passthrough-features.xml
+++ b/tests/qemuxmlconfdata/cpu-host-passthrough-features.xml
@@ -1,11 +1,6 @@
 <domain type='kvm'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/cpu-tsc-frequency.x86_64-latest.xml b/tests/qemuxmlconfdata/cpu-tsc-frequency.x86_64-latest.xml
index ad889ca691..068a2d6c54 100644
--- a/tests/qemuxmlconfdata/cpu-tsc-frequency.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/cpu-tsc-frequency.x86_64-latest.xml
@@ -1,11 +1,6 @@
 <domain type='kvm'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/cpu-tsc-frequency.xml b/tests/qemuxmlconfdata/cpu-tsc-frequency.xml
index afaef6e8e5..2acafe8f13 100644
--- a/tests/qemuxmlconfdata/cpu-tsc-frequency.xml
+++ b/tests/qemuxmlconfdata/cpu-tsc-frequency.xml
@@ -1,11 +1,6 @@
 <domain type='kvm'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.xml b/tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.xml
index 8da45000d2..312e735947 100644
--- a/tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.xml
@@ -1,7 +1,6 @@
 <domain type='qemu'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <description>This test is meant for testing CDROMS with buses which don&apos;t really support them</description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/disk-cdrom-bus-other.xml b/tests/qemuxmlconfdata/disk-cdrom-bus-other.xml
index 2f3efec61f..9564dc11be 100644
--- a/tests/qemuxmlconfdata/disk-cdrom-bus-other.xml
+++ b/tests/qemuxmlconfdata/disk-cdrom-bus-other.xml
@@ -1,7 +1,6 @@
 <domain type='qemu'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <description>This test is meant for testing CDROMS with buses which don't really support them</description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/minimal.x86_64-latest.xml b/tests/qemuxmlconfdata/minimal.x86_64-latest.xml
index 5f26f47508..ffa03532bd 100644
--- a/tests/qemuxmlconfdata/minimal.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/minimal.x86_64-latest.xml
@@ -1,11 +1,6 @@
 <domain type='qemu'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/minimal.xml b/tests/qemuxmlconfdata/minimal.xml
index 8854059ab1..a77240d87c 100644
--- a/tests/qemuxmlconfdata/minimal.xml
+++ b/tests/qemuxmlconfdata/minimal.xml
@@ -1,11 +1,6 @@
 <domain type='qemu'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
-  <description>
-      A test of qemu&apos;s minimal configuration.
-      This test also tests the description and title elements.
-  </description>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
diff --git a/tests/qemuxmlconfdata/missing-machine.xml b/tests/qemuxmlconfdata/missing-machine.xml
index d9935d3338..9170667568 100644
--- a/tests/qemuxmlconfdata/missing-machine.xml
+++ b/tests/qemuxmlconfdata/missing-machine.xml
@@ -1,7 +1,6 @@
 <domain type='qemu'>
   <name>QEMUGuest1</name>
   <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-  <title>A description of the test machine.</title>
   <memory unit='KiB'>219100</memory>
   <currentMemory unit='KiB'>219100</currentMemory>
   <vcpu placement='static' cpuset='1'>1</vcpu>
-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 04/33] tests: Drop existing <title> and <description> tags
Posted by Peter Krempa 10 months, 3 weeks ago
On Wed, Jan 24, 2024 at 20:37:24 +0100, Andrea Bolognani wrote:
> Now that we have an explicit test case for the feature, we can
> drop a bunch of duplicated accidental coverage.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  tests/qemuxmlconfdata/440fx-wrong-root.xml                   | 5 -----
>  .../cpu-host-model-features.x86_64-latest.xml                | 5 -----
>  tests/qemuxmlconfdata/cpu-host-model-features.xml            | 5 -----
>  .../cpu-host-passthrough-features.x86_64-latest.xml          | 5 -----
>  tests/qemuxmlconfdata/cpu-host-passthrough-features.xml      | 5 -----
>  tests/qemuxmlconfdata/cpu-tsc-frequency.x86_64-latest.xml    | 5 -----
>  tests/qemuxmlconfdata/cpu-tsc-frequency.xml                  | 5 -----
>  tests/qemuxmlconfdata/disk-cdrom-bus-other.x86_64-latest.xml | 1 -
>  tests/qemuxmlconfdata/disk-cdrom-bus-other.xml               | 1 -
>  tests/qemuxmlconfdata/minimal.x86_64-latest.xml              | 5 -----
>  tests/qemuxmlconfdata/minimal.xml                            | 5 -----
>  tests/qemuxmlconfdata/missing-machine.xml                    | 1 -
>  12 files changed, 48 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org