[PATCH 03/33] tests: Add title-and-description

Andrea Bolognani posted 33 patches 8 months, 2 weeks ago
There is a newer version of this series
[PATCH 03/33] tests: Add title-and-description
Posted by Andrea Bolognani 8 months, 2 weeks ago
We have a few test cases that cover the ability to set <title>
and <description> for a guest as a side effect. Introduce an
explicit test case for the functionality.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 .../title-and-description.x86_64-latest.args  | 31 ++++++++++++++++++
 .../title-and-description.x86_64-latest.xml   | 32 +++++++++++++++++++
 .../qemuxmlconfdata/title-and-description.xml | 19 +++++++++++
 tests/qemuxmlconftest.c                       |  1 +
 4 files changed, 83 insertions(+)
 create mode 100644 tests/qemuxmlconfdata/title-and-description.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/title-and-description.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/title-and-description.xml

diff --git a/tests/qemuxmlconfdata/title-and-description.x86_64-latest.args b/tests/qemuxmlconfdata/title-and-description.x86_64-latest.args
new file mode 100644
index 0000000000..e12f137233
--- /dev/null
+++ b/tests/qemuxmlconfdata/title-and-description.x86_64-latest.args
@@ -0,0 +1,31 @@
+LC_ALL=C \
+PATH=/bin \
+HOME=/var/lib/libvirt/qemu/domain--1-guest \
+USER=test \
+LOGNAME=test \
+XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-guest/.local/share \
+XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-guest/.cache \
+XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-guest/.config \
+/usr/bin/qemu-system-x86_64 \
+-name guest=guest,debug-threads=on \
+-S \
+-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \
+-machine pc,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
+-accel tcg \
+-cpu qemu64 \
+-m size=219136k \
+-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}' \
+-overcommit mem-lock=off \
+-smp 1,sockets=1,cores=1,threads=1 \
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
+-display none \
+-no-user-config \
+-nodefaults \
+-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \
+-mon chardev=charmonitor,id=monitor,mode=control \
+-rtc base=utc \
+-no-shutdown \
+-boot strict=on \
+-audiodev '{"id":"audio1","driver":"none"}' \
+-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \
+-msg timestamp=on
diff --git a/tests/qemuxmlconfdata/title-and-description.x86_64-latest.xml b/tests/qemuxmlconfdata/title-and-description.x86_64-latest.xml
new file mode 100644
index 0000000000..2418893a6d
--- /dev/null
+++ b/tests/qemuxmlconfdata/title-and-description.x86_64-latest.xml
@@ -0,0 +1,32 @@
+<domain type='qemu'>
+  <name>guest</name>
+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+  <title>this is the guest title</title>
+  <description>
+    this is the
+    guest description
+  </description>
+  <memory unit='KiB'>219100</memory>
+  <currentMemory unit='KiB'>219100</currentMemory>
+  <vcpu placement='static'>1</vcpu>
+  <os>
+    <type arch='x86_64' machine='pc'>hvm</type>
+    <boot dev='hd'/>
+  </os>
+  <cpu mode='custom' match='exact' check='none'>
+    <model fallback='forbid'>qemu64</model>
+  </cpu>
+  <clock offset='utc'/>
+  <on_poweroff>destroy</on_poweroff>
+  <on_reboot>restart</on_reboot>
+  <on_crash>destroy</on_crash>
+  <devices>
+    <emulator>/usr/bin/qemu-system-x86_64</emulator>
+    <controller type='usb' index='0' model='none'/>
+    <controller type='pci' index='0' model='pci-root'/>
+    <input type='mouse' bus='ps2'/>
+    <input type='keyboard' bus='ps2'/>
+    <audio id='1' type='none'/>
+    <memballoon model='none'/>
+  </devices>
+</domain>
diff --git a/tests/qemuxmlconfdata/title-and-description.xml b/tests/qemuxmlconfdata/title-and-description.xml
new file mode 100644
index 0000000000..7be1316b07
--- /dev/null
+++ b/tests/qemuxmlconfdata/title-and-description.xml
@@ -0,0 +1,19 @@
+<domain type='qemu'>
+  <name>guest</name>
+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+  <title>this is the guest title</title>
+  <description>
+    this is the
+    guest description
+  </description>
+  <memory unit='KiB'>219100</memory>
+  <vcpu placement='static'>1</vcpu>
+  <os>
+    <type arch='x86_64' machine='pc'>hvm</type>
+  </os>
+  <devices>
+    <emulator>/usr/bin/qemu-system-x86_64</emulator>
+    <controller type='usb' model='none'/>
+    <memballoon model='none'/>
+  </devices>
+</domain>
diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
index 33c4448414..bd4e2c59fe 100644
--- a/tests/qemuxmlconftest.c
+++ b/tests/qemuxmlconftest.c
@@ -1228,6 +1228,7 @@ mymain(void)
 
     DO_TEST_CAPS_LATEST("minimal");
     DO_TEST_CAPS_LATEST_PARSE_ERROR("minimal-no-memory");
+    DO_TEST_CAPS_LATEST("title-and-description");
 
     DO_TEST_CAPS_LATEST("genid");
     DO_TEST_CAPS_LATEST("genid-auto");
-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 03/33] tests: Add title-and-description
Posted by Peter Krempa 8 months, 2 weeks ago
On Wed, Jan 24, 2024 at 20:37:23 +0100, Andrea Bolognani wrote:
> We have a few test cases that cover the ability to set <title>
> and <description> for a guest as a side effect. Introduce an
> explicit test case for the functionality.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  .../title-and-description.x86_64-latest.args  | 31 ++++++++++++++++++
>  .../title-and-description.x86_64-latest.xml   | 32 +++++++++++++++++++
>  .../qemuxmlconfdata/title-and-description.xml | 19 +++++++++++
>  tests/qemuxmlconftest.c                       |  1 +
>  4 files changed, 83 insertions(+)
>  create mode 100644 tests/qemuxmlconfdata/title-and-description.x86_64-latest.args
>  create mode 100644 tests/qemuxmlconfdata/title-and-description.x86_64-latest.xml
>  create mode 100644 tests/qemuxmlconfdata/title-and-description.xml

This one, since it has no impact on the commandline, would qualify also
for genericxml2xmltest.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org