[PATCH 09/33] qemu: Fix a few comments

Andrea Bolognani posted 33 patches 8 months, 2 weeks ago
There is a newer version of this series
[PATCH 09/33] qemu: Fix a few comments
Posted by Andrea Bolognani 8 months, 2 weeks ago
They reference functions that have since been renamed.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 src/qemu/qemu_command.c | 6 +++---
 src/qemu/qemu_domain.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index b8f071ff2a..4aad7066e9 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2817,7 +2817,7 @@ qemuBuildControllerPCIDevProps(virDomainControllerDef *def,
 
 
 /**
- * qemuBuildControllerDevStr:
+ * qemuBuildControllerDevProps:
  * @domainDef: domain definition
  * @def: controller definition
  * @qemuCaps: QEMU binary capabilities
@@ -3070,10 +3070,10 @@ qemuBuildControllersByTypeCommandLine(virCommand *cmd,
              *
              * Note that we *don't* want to end up with the legacy USB
              * controller for q35 and virt machines, so we go ahead and
-             * fail in qemuBuildControllerDevStr(); on the other hand,
+             * fail in qemuBuildControllerDevProps(); on the other hand,
              * for s390 machines we want to ignore any USB controller
              * (see 548ba43028 for the full story), so we skip
-             * qemuBuildControllerDevStr() but we don't ultimately end
+             * qemuBuildControllerDevProps() but we don't ultimately end
              * up adding the legacy USB controller */
             continue;
         }
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index de36641137..7292739d1f 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -5597,7 +5597,7 @@ qemuDomainControllerDefPostParse(virDomainControllerDef *cont,
              * chance we will get away with using the legacy USB controller
              * when the relevant device is not available.
              *
-             * See qemuBuildControllerDevCommandLine() */
+             * See qemuBuildControllersCommandLine() */
 
             /* Default USB controller is piix3-uhci if available. */
             if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX3_USB_UHCI))
-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH 09/33] qemu: Fix a few comments
Posted by Peter Krempa 8 months, 2 weeks ago
On Wed, Jan 24, 2024 at 20:37:29 +0100, Andrea Bolognani wrote:
> They reference functions that have since been renamed.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  src/qemu/qemu_command.c | 6 +++---
>  src/qemu/qemu_domain.c  | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org