From nobody Wed Jan 15 12:06:26 2025 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=quarantine dis=quarantine) header.from=swemel.ru Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1704898197059504.0349606553881; Wed, 10 Jan 2024 06:49:57 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id D62401CE6; Wed, 10 Jan 2024 09:49:55 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 140FF1C80; Wed, 10 Jan 2024 09:24:59 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 4D92B1C08; Wed, 10 Jan 2024 09:24:37 -0500 (EST) Received: from mx.swemel.ru (mx.swemel.ru [95.143.211.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8C7D71C2B for ; Wed, 10 Jan 2024 09:21:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 From: Dmitry Frolov To: devel@lists.libvirt.org Subject: [PATCH v4 15/19] libxl: change type to void xenParseXLNamespaceData() Date: Wed, 10 Jan 2024 17:21:30 +0300 Message-Id: <20240110142134.915450-16-frolov@swemel.ru> In-Reply-To: <20240110142134.915450-1-frolov@swemel.ru> References: <47d3cbc0-003b-4829-8038-8e00bbdb5c85@redhat.com> <20240110142134.915450-1-frolov@swemel.ru> MIME-Version: 1.0 Message-ID-Hash: 7LHKMS56EZLBEKADLJJ67NVC7Z363N46 X-Message-ID-Hash: 7LHKMS56EZLBEKADLJJ67NVC7Z363N46 X-MailFrom: frolov@swemel.ru X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: sdl.libvirt@linuxtesting.org, Dmitry Frolov X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1704898198244100001 xenParseXLNamespaceData() returns nothing except 0. Changing return type to void. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov --- src/libxl/xen_xl.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 553aa77896..ea825e85bd 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -1017,7 +1017,7 @@ xenParseXLChannel(virConf *conf, virDomainDef *def) return -1; } =20 -static int +static void xenParseXLNamespaceData(virConf *conf, virDomainDef *def) { virConfValue *list =3D virConfGetValue(conf, "device_model_args"); @@ -1027,7 +1027,7 @@ xenParseXLNamespaceData(virConf *conf, virDomainDef *= def) size_t n =3D 0; =20 if (!list || list->type !=3D VIR_CONF_LIST) - return 0; + return; =20 list =3D list->list; =20 @@ -1039,7 +1039,7 @@ xenParseXLNamespaceData(virConf *conf, virDomainDef *= def) } =20 if (nargs =3D=3D 0) - return 0; + return; =20 nsdata =3D g_new0(libxlDomainXmlNsDef, 1); def->namespaceData =3D nsdata; @@ -1052,8 +1052,6 @@ xenParseXLNamespaceData(virConf *conf, virDomainDef *= def) =20 nsdata->args[n++] =3D g_strdup(next->str); } - - return 0; } =20 virDomainDef * @@ -1104,8 +1102,7 @@ xenParseXL(virConf *conf, if (xenParseXLChannel(conf, def) < 0) return NULL; =20 - if (xenParseXLNamespaceData(conf, def) < 0) - return NULL; + xenParseXLNamespaceData(conf, def); =20 if (virDomainDefPostParse(def, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, xmlopt, NULL) < 0) --=20 2.34.1 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org