From nobody Sat May 11 20:46:56 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1699032290343192.89062267906058; Fri, 3 Nov 2023 10:24:50 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 17B1D1811; Fri, 3 Nov 2023 13:24:49 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2FC9718A9; Fri, 3 Nov 2023 13:22:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id D521A18A4; Fri, 3 Nov 2023 13:22:53 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 142591866 for ; Fri, 3 Nov 2023 13:22:50 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-7WhXPzn1OZGR3W0SsPPixA-1; Fri, 03 Nov 2023 13:22:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4864885A59D for ; Fri, 3 Nov 2023 17:22:48 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.32.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id 150AE40C6EBC; Fri, 3 Nov 2023 17:22:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 7WhXPzn1OZGR3W0SsPPixA-1 From: Laine Stump To: devel@lists.libvirt.org Subject: [PATCH] build: suppress "ignoring duplicate libraries" warning on macOS Date: Fri, 3 Nov 2023 13:22:32 -0400 Message-ID: <20231103172247.540784-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: D2RNYLGH6STHSIUKYQM4ELVFN5TGMKZ2 X-Message-ID-Hash: D2RNYLGH6STHSIUKYQM4ELVFN5TGMKZ2 X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Andrea Bolognani X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1699032292287100001 Xcode 15, which provides the compiler toolchain for building libvirt on macOS has switched to a new linker that warns about duplicated "-lblah" options on the ld commandline. In practice this is impossible to prevent in a large project, and also harmless. Fortunately the new ld command also has an option, -no_warn_duplicate_libraries, that supresses this harmless/pointless warning, meson has a simple way to check if that option is supported, and libvirt's meson.build files already have examples of adding an option to the ld commandline if it's available. Signed-off-by: Laine Stump Reviewed-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- meson.build | 4 ++++ src/meson.build | 1 + tests/meson.build | 1 + tools/meson.build | 1 + 4 files changed, 7 insertions(+) diff --git a/meson.build b/meson.build index dc0969abcc..a39f942617 100644 --- a/meson.build +++ b/meson.build @@ -542,6 +542,10 @@ libvirt_no_indirect =3D cc.get_supported_link_argument= s([ '-Wl,--no-copy-dt-needed-entries', ]) =20 +libvirt_no_warn_duplicate_libraries =3D cc.get_supported_link_arguments([ + '-Wl,-no_warn_duplicate_libraries', +]) + if host_machine.system() =3D=3D 'windows' version_script_flags =3D '-Wl,' elif host_machine.system() =3D=3D 'darwin' diff --git a/src/meson.build b/src/meson.build index 5fc4d03b4a..6538c43628 100644 --- a/src/meson.build +++ b/src/meson.build @@ -18,6 +18,7 @@ src_dep =3D declare_dependency( link_args: ( libvirt_relro + libvirt_no_indirect + + libvirt_no_warn_duplicate_libraries + coverage_flags + driver_modules_flags + win32_link_flags diff --git a/tests/meson.build b/tests/meson.build index b235c5f4dd..e1cd57654a 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -28,6 +28,7 @@ tests_dep =3D declare_dependency( ], link_args: ( libvirt_export_dynamic + + libvirt_no_warn_duplicate_libraries + libvirt_flat_namespace + coverage_flags ), diff --git a/tools/meson.build b/tools/meson.build index f2d58cfdcb..c72f760a1d 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -16,6 +16,7 @@ tools_dep =3D declare_dependency( libvirt_relro + libvirt_no_indirect + libvirt_no_undefined + + libvirt_no_warn_duplicate_libraries ), ) =20 --=20 2.41.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org