From nobody Mon May 13 13:04:29 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1698968467869423.825000336063; Thu, 2 Nov 2023 16:41:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id CF1751854; Thu, 2 Nov 2023 19:41:06 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id E0712182A; Thu, 2 Nov 2023 19:37:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9353A17CE; Thu, 2 Nov 2023 19:37:27 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5769E17E7 for ; Thu, 2 Nov 2023 19:37:23 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-wMytcqwlMmWnPLm80qGdzg-1; Thu, 02 Nov 2023 19:37:21 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2633728AC1D3 for ; Thu, 2 Nov 2023 23:37:21 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.224.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0B1A2026D4C for ; Thu, 2 Nov 2023 23:37:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: wMytcqwlMmWnPLm80qGdzg-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [libvirt PATCH 1/2] rpc: Drop support for portable-rpcgen Date: Fri, 3 Nov 2023 00:37:17 +0100 Message-ID: <20231102233718.540731-2-abologna@redhat.com> In-Reply-To: <20231102233718.540731-1-abologna@redhat.com> References: <20231102233718.540731-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 3OPAQLM4MF72ACALSLLKEP3BVLZVQ5RG X-Message-ID-Hash: 3OPAQLM4MF72ACALSLLKEP3BVLZVQ5RG X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1698968468902100001 We use the native version of rpcgen everywhere. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- meson.build | 12 +----------- src/rpc/genprotocol.pl | 3 --- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/meson.build b/meson.build index dc0969abcc..158a7cae01 100644 --- a/meson.build +++ b/meson.build @@ -779,14 +779,11 @@ endif required_programs =3D [ 'perl', 'python3', + 'rpcgen', 'xmllint', 'xsltproc', ] =20 -required_programs_groups =3D [ - { 'name': 'rpcgen', 'prog': [ 'rpcgen', 'portable-rpcgen' ] }, -] - if host_machine.system() =3D=3D 'freebsd' required_programs +=3D 'ifconfig' endif @@ -798,13 +795,6 @@ foreach name : required_programs set_variable('@0@_prog'.format(varname), prog) endforeach =20 -foreach item : required_programs_groups - prog =3D find_program(item.get('prog'), dirs: libvirt_sbin_path) - varname =3D item.get('name').underscorify() - conf.set_quoted(varname.to_upper(), prog.full_path()) - set_variable('@0@_prog'.format(varname), prog) -endforeach - # optional programs =20 optional_programs =3D [ diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl index adf3991d7a..6c664f48e7 100755 --- a/src/rpc/genprotocol.pl +++ b/src/rpc/genprotocol.pl @@ -39,9 +39,6 @@ my $target =3D shift; =20 unlink $target; =20 -if ($rpcgen =3D~ /portable-rpcgen/) { - $rpcgen =3D "$rpcgen -o -"; -} open RPCGEN, "-|", "$rpcgen $mode $xdrdef" or die "cannot run $rpcgen $mode $xdrdef: $!"; open TARGET, ">$target" --=20 2.41.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org From nobody Mon May 13 13:04:29 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1698968572346248.0833411762285; Thu, 2 Nov 2023 16:42:52 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 4CF7E17F7; Thu, 2 Nov 2023 19:42:51 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 613D518BA; Thu, 2 Nov 2023 19:37:41 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C7DD4180E; Thu, 2 Nov 2023 19:37:30 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9BCD417F6 for ; Thu, 2 Nov 2023 19:37:24 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-XkrsTBtvOeyW2wDMSMQ6kw-1; Thu, 02 Nov 2023 19:37:22 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF4EE101A529 for ; Thu, 2 Nov 2023 23:37:21 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.224.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 667CC2026D4C for ; Thu, 2 Nov 2023 23:37:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: XkrsTBtvOeyW2wDMSMQ6kw-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [libvirt PATCH 2/2] rpc: Make rpcgen produce ANSI C code Date: Fri, 3 Nov 2023 00:37:18 +0100 Message-ID: <20231102233718.540731-3-abologna@redhat.com> In-Reply-To: <20231102233718.540731-1-abologna@redhat.com> References: <20231102233718.540731-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 3ZQNMAGYRSVNRHWIQK52BFSM4YLWV4OT X-Message-ID-Hash: 3ZQNMAGYRSVNRHWIQK52BFSM4YLWV4OT X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1698968573203100001 This is the default for the version of rpcgen shipped with Linux distributions, but the one in macOS and possibly others default to K&R C, which modern compilers don't appreciate. Luckily, all versions of rpcgen shipped with our target platforms seem to support the -C option. Signed-off-by: Andrea Bolognani Reviewed-by: Laine Stump --- src/rpc/genprotocol.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl index 6c664f48e7..5eb654cb7c 100755 --- a/src/rpc/genprotocol.pl +++ b/src/rpc/genprotocol.pl @@ -39,6 +39,8 @@ my $target =3D shift; =20 unlink $target; =20 +$rpcgen =3D "$rpcgen -C"; + open RPCGEN, "-|", "$rpcgen $mode $xdrdef" or die "cannot run $rpcgen $mode $xdrdef: $!"; open TARGET, ">$target" --=20 2.41.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org