From nobody Mon Feb 9 17:35:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1698253654; cv=none; d=zohomail.com; s=zohoarc; b=CLe7meAuHoi7E7LVYq07zdOIF2kDoIlgBpUCNQUBe/jpU6EvStIv0qbsaY5UJhaQ616UOzXoE/C2a3JGg3rHgSBleURr1Aswkd11CG9aNTJsstH7/ImvDG91xH3FazCK8PdV2EJ5Y0q2xGrUvjPXHoD3XaS0mxm8M9Hq28tynMA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698253654; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ojxQqoHHuf2hzmk770A1dZaC90tW5eih8P4lcVm+5wY=; b=HppCrlU8lwn8aEmyGi+RuTvR2VFI4zR9ooRa3p3EVb4ffPmHs5VnvR5Z/KIJ92rTrXOXFZDuViCrMSY7wDMRJrRu94PeY7QaH0dQkPyy6+bgbICBk2KeZwVOH2rfqCxNnmAVi9xdXkY4Ao3mYaG+095oiOQq+fMnxhFJ61gDPHg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1698253654084706.8652691041274; Wed, 25 Oct 2023 10:07:34 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-iLDq7CdrMmqeKciYAz1neQ-1; Wed, 25 Oct 2023 13:07:28 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DA982811E92; Wed, 25 Oct 2023 17:07:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C48B9C15983; Wed, 25 Oct 2023 17:07:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 86846194658D; Wed, 25 Oct 2023 17:07:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6655D194658D for ; Wed, 25 Oct 2023 17:07:20 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 551B7492BE7; Wed, 25 Oct 2023 17:07:20 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.90]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5352D492BE8 for ; Wed, 25 Oct 2023 17:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698253652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ojxQqoHHuf2hzmk770A1dZaC90tW5eih8P4lcVm+5wY=; b=GcAlXqFXqbkYcDlbQTHKcmrFUfOdQcDyYLs16Qe9EnLnfCVtQt54ckYqrtK6YbcMuI0Spq lhR2B3b8rvBfHkBz/Lz7+PN+smoBIt+3UbjeW3FBhQceK0OtU7/CIyhSqFQpVzqSSoEC+P /1GpGqUHAeQgYLhgAjiLlfgZq7ok+Tc= X-MC-Unique: iLDq7CdrMmqeKciYAz1neQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 8/8] meson: Rename build_tests -> tests_enabled Date: Wed, 25 Oct 2023 19:07:01 +0200 Message-ID: <20231025170701.239137-9-abologna@redhat.com> In-Reply-To: <20231025170701.239137-1-abologna@redhat.com> References: <20231025170701.239137-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1698253655446100013 Content-Type: text/plain; charset="utf-8"; x-default="true" Given that this variable now controls not just whether C tests are built, but also whether any test at all is executed, the new name is more appropriate. Update the description for the corresponding meson option accordingly. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- build-aux/meson.build | 2 +- docs/html/meson.build | 2 +- docs/meson.build | 2 +- meson.build | 14 +++++++------- meson_options.txt | 2 +- src/access/meson.build | 2 +- src/meson.build | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/build-aux/meson.build b/build-aux/meson.build index 84405c5ec8..f96d46c445 100644 --- a/build-aux/meson.build +++ b/build-aux/meson.build @@ -1,6 +1,6 @@ # Skip syntax-check if not building from git because we get the list of fi= les # to check using git commands and it fails if we are not in git repository. -if git and build_tests[0] +if git and tests_enabled[0] flake8_path =3D '' if flake8_prog.found() flake8_path =3D flake8_prog.full_path() diff --git a/docs/html/meson.build b/docs/html/meson.build index b4e81f8501..e2758ed177 100644 --- a/docs/html/meson.build +++ b/docs/html/meson.build @@ -119,7 +119,7 @@ html_xslt_gen =3D [] =20 # --- end of XSLT processing --- =20 -if build_tests[0] +if tests_enabled[0] test( 'check-html', xmllint_prog, diff --git a/docs/meson.build b/docs/meson.build index 52763a8597..87d728213c 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -351,7 +351,7 @@ run_target( depends: install_web_deps, ) =20 -if build_tests[0] +if tests_enabled[0] test( 'check-html-references', python3_prog, diff --git a/meson.build b/meson.build index b30150d605..e51ba9231e 100644 --- a/meson.build +++ b/meson.build @@ -2027,8 +2027,8 @@ conf.set_quoted('TLS_PRIORITY', get_option('tls_prior= ity')) =20 # test options =20 -build_tests =3D [ not get_option('tests').disabled() ] -if build_tests[0] and \ +tests_enabled =3D [ not get_option('tests').disabled() ] +if tests_enabled[0] and \ cc.get_id() =3D=3D 'clang' and \ not supported_cc_flags.contains('-fsemantic-interposition') \ and get_option('optimization') !=3D '0' @@ -2039,14 +2039,14 @@ if build_tests[0] and \ if get_option('tests').enabled() error(msg) endif - build_tests =3D [ false, '!!! @0@ !!!'.format(msg) ] + tests_enabled =3D [ false, '!!! @0@ !!!'.format(msg) ] endif =20 if get_option('expensive_tests').auto() - use_expensive_tests =3D not git and build_tests[0] + use_expensive_tests =3D not git and tests_enabled[0] else use_expensive_tests =3D get_option('expensive_tests').enabled() - if use_expensive_tests and not build_tests[0] + if use_expensive_tests and not tests_enabled[0] error('cannot enable expensive tests when tests are disabled') endif endif @@ -2083,7 +2083,7 @@ subdir('src') =20 subdir('tools') =20 -if build_tests[0] +if tests_enabled[0] subdir('tests') else # Ensure that 'meson test' fails when tests are disabled, as opposed to @@ -2307,7 +2307,7 @@ endif misc_summary =3D { 'Warning Flags': supported_cc_flags, 'docs': gen_docs, - 'tests': build_tests, + 'tests': tests_enabled, 'DTrace': conf.has('WITH_DTRACE_PROBES'), 'firewalld': conf.has('WITH_FIREWALLD'), 'firewalld-zone': conf.has('WITH_FIREWALLD_ZONE'), diff --git a/meson_options.txt b/meson_options.txt index 7c428a9eb0..a0928102bf 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -10,7 +10,7 @@ option('git_werror', type: 'feature', value: 'auto', desc= ription: 'use -Werror i option('rpath', type: 'feature', value: 'auto', description: 'whether to i= nclude rpath information in installed binaries and libraries') option('docdir', type: 'string', value: '', description: 'documentation in= stallation directory') option('docs', type: 'feature', value: 'auto', description: 'whether to ge= nerate documentation') -option('tests', type: 'feature', value: 'auto', description: 'whether to b= uild tests') +option('tests', type: 'feature', value: 'auto', description: 'whether to b= uild and run tests') =20 =20 # build dependencies options diff --git a/src/access/meson.build b/src/access/meson.build index 6ca953c932..fc5ba5b342 100644 --- a/src/access/meson.build +++ b/src/access/meson.build @@ -105,7 +105,7 @@ access_dep =3D declare_dependency( =20 generated_sym_files +=3D access_gen_sym =20 -if build_tests[0] +if tests_enabled[0] test( 'check-aclperms', python3_prog, diff --git a/src/meson.build b/src/meson.build index e25b3e5980..5fc4d03b4a 100644 --- a/src/meson.build +++ b/src/meson.build @@ -946,7 +946,7 @@ meson.add_install_script( =20 # Check driver files =20 -if build_tests[0] +if tests_enabled[0] if host_machine.system() =3D=3D 'linux' test( 'check-symfile', --=20 2.41.0