From nobody Mon Feb 9 12:43:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695835657; cv=none; d=zohomail.com; s=zohoarc; b=dW7lGmv4ZqmlyfaLZjqYuYXIOfY9RJZQiRqYYCC/eITnu4zKyEQChK6vTUNcqPzaQCXgA6B7ZwnOnm965jRNUGZctz746JWZhxf7uo6/JmXCNDe6lEWcvwD3WpgiExOVrn0PZpgCbXqYB0Hn+amnpIq1ln6USFuYdS1qyer7CZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695835657; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TpFRWvdv8BistnQSQEBbpMyd0KK3NTe8Hvvd7pzvNh4=; b=H6wRou1V+B1EiD93HWftHHMXr92jYdU+GuQgNWG8UOVsdn1vNDbSc4h0eoZ/uErHBabOOEYDYzND6oQ0qxgL7sZF14qAvLRxM0Vfp8xKRMSWVEOZohbHxjIZ0aBZzF+8Wsaa0Ah6t0lo4adZlnWJ9l9NzfMvYKpH4KYVRqKuPpo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1695835657183977.2193129807562; Wed, 27 Sep 2023 10:27:37 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-88-kYg-1GV7PeazVSzDnwknbA-1; Wed, 27 Sep 2023 13:27:33 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FCF53C17711; Wed, 27 Sep 2023 17:27:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A94214171B6; Wed, 27 Sep 2023 17:27:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B03111946A42; Wed, 27 Sep 2023 17:26:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C51B519466FA for ; Wed, 27 Sep 2023 16:20:56 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 815291054F86; Wed, 27 Sep 2023 16:20:00 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14DC61054F85 for ; Wed, 27 Sep 2023 16:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695835656; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TpFRWvdv8BistnQSQEBbpMyd0KK3NTe8Hvvd7pzvNh4=; b=Ud9JFtA9zbChogwMt5etJR/UYZVmikUPG3I/aBJREjrpmLenFOGyp9g6KaOQXGKST22Ypr MjkottedFAeEFAJenIgYBYZbqnueIvMs2jLkprzjYe9P5Mmcm6RubjvHMEFyYfg8w1N/Ou eX2AR0Lfgk+7b9QG6vxJG9AS40xENgA= X-MC-Unique: kYg-1GV7PeazVSzDnwknbA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 33/33] systemd: Move Documentation lines Date: Wed, 27 Sep 2023 18:19:34 +0200 Message-ID: <20230927161934.181728-34-abologna@redhat.com> In-Reply-To: <20230927161934.181728-1-abologna@redhat.com> References: <20230927161934.181728-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695835657425100001 Like the Description, these are intended to be displayed to the user, so it makes sense to have them towards the top of the file before all the information that systemd will parse to calculate dependencies. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/locking/virtlockd.service.in | 4 ++-- src/logging/virtlogd.service.in | 4 ++-- src/remote/libvirtd.service.in | 4 ++-- src/virtd.service.in | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.servi= ce.in index 290a2887a5..ce00b6def9 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -1,11 +1,11 @@ [Unit] Description=3Dlibvirt locking daemon +Documentation=3Dman:virtlockd(8) +Documentation=3Dhttps://libvirt.org/ BindsTo=3Dvirtlockd.socket Wants=3Dvirtlockd-admin.socket After=3Dvirtlockd.socket After=3Dvirtlockd-admin.socket -Documentation=3Dman:virtlockd(8) -Documentation=3Dhttps://libvirt.org =20 [Service] Type=3Dnotify diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service= .in index 4289ef1cb4..52c9e5bb9e 100644 --- a/src/logging/virtlogd.service.in +++ b/src/logging/virtlogd.service.in @@ -1,11 +1,11 @@ [Unit] Description=3Dlibvirt logging daemon +Documentation=3Dman:virtlogd(8) +Documentation=3Dhttps://libvirt.org/ BindsTo=3Dvirtlogd.socket Wants=3Dvirtlogd-admin.socket After=3Dvirtlogd.socket After=3Dvirtlogd-admin.socket -Documentation=3Dman:virtlogd(8) -Documentation=3Dhttps://libvirt.org =20 [Service] Type=3Dnotify diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in index 9e303f29c8..24a6712b75 100644 --- a/src/remote/libvirtd.service.in +++ b/src/remote/libvirtd.service.in @@ -1,5 +1,7 @@ [Unit] Description=3Dlibvirt legacy monolithic daemon +Documentation=3Dman:libvirtd(8) +Documentation=3Dhttps://libvirt.org/ # Use Wants instead of Requires so that users # can disable these three .socket units to revert # to a traditional non-activation deployment setup @@ -22,8 +24,6 @@ After=3Dremote-fs.target After=3Dsystemd-machined.service After=3Dxencommons.service Conflicts=3Dxendomains.service -Documentation=3Dman:libvirtd(8) -Documentation=3Dhttps://libvirt.org =20 [Service] Type=3Dnotify diff --git a/src/virtd.service.in b/src/virtd.service.in index 91ac4478bd..651a8d82d7 100644 --- a/src/virtd.service.in +++ b/src/virtd.service.in @@ -1,5 +1,7 @@ [Unit] Description=3Dlibvirt @name@ daemon +Documentation=3Dman:@service@(8) +Documentation=3Dhttps://libvirt.org/ BindsTo=3D@service@.socket Wants=3D@service@-ro.socket Wants=3D@service@-admin.socket @@ -11,8 +13,6 @@ After=3Dlibvirtd.service After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -Documentation=3Dman:@service@(8) -Documentation=3Dhttps://libvirt.org =20 [Service] Type=3Dnotify --=20 2.41.0