From nobody Mon Feb 9 21:37:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695835664; cv=none; d=zohomail.com; s=zohoarc; b=NLIrk+T8pNv3KZBVX4pspq+lJ8g9eme/kktToLb/6SxhtQJW+/gTkeEIut5YlI8HB7MEimbP75Xdwk5/b9WFN723kVyTEVat8CupI9ftB76WbRf7bYrvx1v2/5lhe50HJcyLTn0yVUgQYGW5h5czRQjmN97wCzohmqBzByy0msk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695835664; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=c17pQu5c9q8nAaX62P9jkyOB8ffDrZwjWn3lakx76B4=; b=mot/AsYxx4oePXs2/eY/Jzcop7LdGq9bdb9nJ60WuWsFEEj7yunK6eIGm66AS3emfqkiqtqNxUPWqsOejQo47ePggkR4AfKO6WYcQFKWMfUNy2k3L61LVSNdsR/pVbpOvQiaB2Zp0cOw3Tkzwhhk9ozYb99sdWEywpidahbNAV0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1695835664610561.0055910239531; Wed, 27 Sep 2023 10:27:44 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-184-qHIufdIUNEKI-Q34tShVqA-1; Wed, 27 Sep 2023 13:27:41 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70CB2185A78E; Wed, 27 Sep 2023 17:27:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CB0040C2064; Wed, 27 Sep 2023 17:27:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EEB7C194658D; Wed, 27 Sep 2023 17:27:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C4AC219466ED for ; Wed, 27 Sep 2023 16:20:56 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id E1F5E1054FD3; Wed, 27 Sep 2023 16:19:56 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 758F11054FD7 for ; Wed, 27 Sep 2023 16:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695835663; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=c17pQu5c9q8nAaX62P9jkyOB8ffDrZwjWn3lakx76B4=; b=AssOtUsUNsnznRFCjEpxYs8a0+VHpCBCU0Xx77bT1RCXhbS4FDR3AvfaIP8IWjeA7isPTs CisaDTQvrbFGvtxvUF8OjKlu5+ks6K0o8BofmkEEaSqzMzMn20yGga6ig02m8sFfBPmJE/ utbHAXlvC1qGU3czG6+dOGXVNk9+tkU= X-MC-Unique: qHIufdIUNEKI-Q34tShVqA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2 28/33] systemd: Drop Before=libvirtd from virtlogd/virtlockd Date: Wed, 27 Sep 2023 18:19:29 +0200 Message-ID: <20230927161934.181728-29-abologna@redhat.com> In-Reply-To: <20230927161934.181728-1-abologna@redhat.com> References: <20230927161934.181728-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695835665633100001 We have already declared the mirror relationship, so this one is now redundant. Moreover, this version was incomplete: it only ever worked for the monolithic daemon, but the modular daemons for QEMU and Xen also want the sockets to be active. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/locking/virtlockd-admin.socket.in | 1 - src/locking/virtlockd.service.in | 1 - src/locking/virtlockd.socket.in | 1 - src/logging/virtlogd-admin.socket.in | 1 - src/logging/virtlogd.service.in | 1 - src/logging/virtlogd.socket.in | 1 - 6 files changed, 6 deletions(-) diff --git a/src/locking/virtlockd-admin.socket.in b/src/locking/virtlockd-= admin.socket.in index c66e0f9693..d5ebd7f60b 100644 --- a/src/locking/virtlockd-admin.socket.in +++ b/src/locking/virtlockd-admin.socket.in @@ -1,6 +1,5 @@ [Unit] Description=3DVirtual machine lock manager admin socket -Before=3Dlibvirtd.service BindsTo=3Dvirtlockd.socket After=3Dvirtlockd.socket =20 diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.servi= ce.in index e0a7040ad3..20b4b26f35 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -4,7 +4,6 @@ BindsTo=3Dvirtlockd.socket Wants=3Dvirtlockd-admin.socket After=3Dvirtlockd.socket After=3Dvirtlockd-admin.socket -Before=3Dlibvirtd.service Documentation=3Dman:virtlockd(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/locking/virtlockd.socket.in b/src/locking/virtlockd.socket= .in index 4ce75391ae..d2cc2a06a3 100644 --- a/src/locking/virtlockd.socket.in +++ b/src/locking/virtlockd.socket.in @@ -1,6 +1,5 @@ [Unit] Description=3DVirtual machine lock manager socket -Before=3Dlibvirtd.service =20 [Socket] ListenStream=3D@runstatedir@/libvirt/virtlockd-sock diff --git a/src/logging/virtlogd-admin.socket.in b/src/logging/virtlogd-ad= min.socket.in index 5c0fb1880e..67259803ca 100644 --- a/src/logging/virtlogd-admin.socket.in +++ b/src/logging/virtlogd-admin.socket.in @@ -1,6 +1,5 @@ [Unit] Description=3DVirtual machine log manager socket -Before=3Dlibvirtd.service BindsTo=3Dvirtlogd.socket After=3Dvirtlogd.socket =20 diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service= .in index eab0d2c27c..776d753e9a 100644 --- a/src/logging/virtlogd.service.in +++ b/src/logging/virtlogd.service.in @@ -4,7 +4,6 @@ BindsTo=3Dvirtlogd.socket Wants=3Dvirtlogd-admin.socket After=3Dvirtlogd.socket After=3Dvirtlogd-admin.socket -Before=3Dlibvirtd.service Documentation=3Dman:virtlogd(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/logging/virtlogd.socket.in b/src/logging/virtlogd.socket.in index ff3e66e09b..7b3fc73773 100644 --- a/src/logging/virtlogd.socket.in +++ b/src/logging/virtlogd.socket.in @@ -1,6 +1,5 @@ [Unit] Description=3DVirtual machine log manager socket -Before=3Dlibvirtd.service =20 [Socket] ListenStream=3D@runstatedir@/libvirt/virtlogd-sock --=20 2.41.0