From nobody Mon Feb 9 16:02:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695668455; cv=none; d=zohomail.com; s=zohoarc; b=UqNcQE13xahHsSajH0sWTIKO+zE48JerXJgJWnIA7BqlI37YJgTx0onyQ/GajNPAl8xFt30JN/apOvYLmEw46Msbh9GH6Gx9whNNP4R2c2fKuJmvzU7K9vkLyR7ivUWC6Q1BkMh3us3+9DPGCWYTXq5VF9yhqrfXnGrgJ16FeMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695668455; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uK6BgVs0CCvPlN7cq3wBXTZGDCllcpCalhj9q/KO/68=; b=duZ8w+QLHW4+5OJJDCoJhBxZlSKxXO8i3jZMkdoCJTAUJP9qrTEOWy0ACV9Qp2o4nwUvfmrtUGw1TxfZUD2IYbyqpRSF7yiSh8uE3ar/btpDUkyaIMC8mWEVFngLFwhl9su/kTlWyxlMdjtp0PFFZY9tcD4zIX2ngSny6he+kVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1695668455110995.5346702488182; Mon, 25 Sep 2023 12:00:55 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-681-NcFaTXZHMfydcicRtCAqLA-1; Mon, 25 Sep 2023 15:00:47 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BC25118162C8; Mon, 25 Sep 2023 19:00:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id A18C8C15BB8; Mon, 25 Sep 2023 19:00:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 04D851946A42; Mon, 25 Sep 2023 19:00:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 36C89194658F for ; Mon, 25 Sep 2023 18:59:56 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 28D83711295; Mon, 25 Sep 2023 18:59:56 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B091C711293 for ; Mon, 25 Sep 2023 18:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695668454; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uK6BgVs0CCvPlN7cq3wBXTZGDCllcpCalhj9q/KO/68=; b=UwPur6eLKlb5sCXXqSzaK1y8Utenss7IBROx1/OC6mDcnKqS2KJcQrfMeaeIU98dyK7jT3 7YLJnD2cHfRucN5VRzz0Ns2ZMClJR5fuNLhBZAXJ6wffZhkTGLQgIbqyiiyfFcfI9Qy127 ariJli0yZ0tVg1Ejeq8TIGxYRwutSUg= X-MC-Unique: NcFaTXZHMfydcicRtCAqLA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 42/42] systemd: Move Documentation lines Date: Mon, 25 Sep 2023 20:58:40 +0200 Message-ID: <20230925185840.880191-43-abologna@redhat.com> In-Reply-To: <20230925185840.880191-1-abologna@redhat.com> References: <20230925185840.880191-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695668456598100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Like the Description, these are intended to be displayed to the user, so it makes sense to have them towards the top of the file before all the information that systemd will parse to calculate dependencies. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/locking/virtlockd.service.in | 4 ++-- src/logging/virtlogd.service.in | 4 ++-- src/remote/libvirtd.service.in | 4 ++-- src/virtd.service.in | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.servi= ce.in index d1ebbda2b7..ed3b7c7792 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -1,11 +1,11 @@ [Unit] Description=3Dlibvirt @name@ daemon +Documentation=3Dman:virtlockd(8) +Documentation=3Dhttps://libvirt.org/ BindsTo=3Dvirtlockd.socket BindsTo=3Dvirtlockd-admin.socket After=3Dvirtlockd.socket After=3Dvirtlockd-admin.socket -Documentation=3Dman:virtlockd(8) -Documentation=3Dhttps://libvirt.org =20 [Service] Type=3Dnotify diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service= .in index bfcc43d1b7..417770b139 100644 --- a/src/logging/virtlogd.service.in +++ b/src/logging/virtlogd.service.in @@ -1,11 +1,11 @@ [Unit] Description=3Dlibvirt @name@ daemon +Documentation=3Dman:virtlogd(8) +Documentation=3Dhttps://libvirt.org/ BindsTo=3Dvirtlogd.socket BindsTo=3Dvirtlogd-admin.socket After=3Dvirtlogd.socket After=3Dvirtlogd-admin.socket -Documentation=3Dman:virtlogd(8) -Documentation=3Dhttps://libvirt.org =20 [Service] Type=3Dnotify diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in index 3b9819c3bc..2970e855d6 100644 --- a/src/remote/libvirtd.service.in +++ b/src/remote/libvirtd.service.in @@ -1,5 +1,7 @@ [Unit] Description=3Dlibvirt @name@ daemon +Documentation=3Dman:libvirtd(8) +Documentation=3Dhttps://libvirt.org/ # Use Wants instead of Requires so that users # can disable these three .socket units to revert # to a traditional non-activation deployment setup @@ -22,8 +24,6 @@ After=3Dremote-fs.target After=3Dsystemd-machined.service After=3Dxencommons.service Conflicts=3Dxendomains.service -Documentation=3Dman:libvirtd(8) -Documentation=3Dhttps://libvirt.org =20 [Service] Type=3Dnotify diff --git a/src/virtd.service.in b/src/virtd.service.in index e940b05b19..6b59803574 100644 --- a/src/virtd.service.in +++ b/src/virtd.service.in @@ -1,5 +1,7 @@ [Unit] Description=3Dlibvirt @name@ daemon +Documentation=3Dman:@service@(8) +Documentation=3Dhttps://libvirt.org/ BindsTo=3D@service@.socket BindsTo=3D@service@-ro.socket BindsTo=3D@service@-admin.socket @@ -11,8 +13,6 @@ After=3Dlibvirtd.service After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -Documentation=3Dman:@service@(8) -Documentation=3Dhttps://libvirt.org @service_unit_extra@ =20 [Service] --=20 2.41.0