From nobody Mon Feb 9 22:18:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695668465; cv=none; d=zohomail.com; s=zohoarc; b=FKWrdyInLIUzYDnj81/Qxm23SnoOTROMrSBNsxXIf2t/21ZBdDnddj0DQmxa4aMD8EvGkyCgC1d8xoA6TdV0+ny/Ygc3Gjm/VcwB9Yn+3+f5koaifHf6oTu3GYkOEFjXb4aIHTDtazryvOYIvTjAnaAYrhIbWaPaljer+U7a++U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695668465; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BY2w+whsFXxRpByW2TUU/rmXBtlkvLHVnJVYrPZrUeo=; b=dIbIFerkZLJhtff9aHbbPa0z7BzXDdc2/3MGDdYuCpze0LwkbPgI6DAaTUWVgGE6cYL1dqSz97HqOfpXbMq8YN3zj3FSiya2fcJVjVEw6C1VuwensLYQ2Y9IvZzr+keyPhn0vY9FypPuR/xfcDZaBKWpodYHy/fivmW0XQbmw0w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1695668465509753.3843355232373; Mon, 25 Sep 2023 12:01:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610--a0fmzIsM0Sl77S_zrhHaw-1; Mon, 25 Sep 2023 15:00:16 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A719380117C; Mon, 25 Sep 2023 19:00:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 416B3711297; Mon, 25 Sep 2023 19:00:00 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 14BB019465A4; Mon, 25 Sep 2023 19:00:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BF8D819466F5 for ; Mon, 25 Sep 2023 18:59:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A776C711295; Mon, 25 Sep 2023 18:59:44 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B39D711286 for ; Mon, 25 Sep 2023 18:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695668464; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BY2w+whsFXxRpByW2TUU/rmXBtlkvLHVnJVYrPZrUeo=; b=DU2QSLVHupoGDUQHuzCbH/oNRIKANxHeG2HVUexAYfMWD2qg1TZyksx6/ugarBd6Lb+8dy JA12VXBsOY5lM+NFcog9TK8OhRXVJc3yK1SQEdML58CJsIuVeR3xEgluI2i98VKkQ1w+4Z 6fnW0gyF4g+Gw2JkYzRHpcMCqX4TkaI= X-MC-Unique: -a0fmzIsM0Sl77S_zrhHaw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 36/42] systemd: Augment Requires/Wants with After Date: Mon, 25 Sep 2023 20:58:34 +0200 Message-ID: <20230925185840.880191-37-abologna@redhat.com> In-Reply-To: <20230925185840.880191-1-abologna@redhat.com> References: <20230925185840.880191-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695668466645100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Requires/Wants only tells systemd that the corresponding unit should be started when the current one is, but that could very well happen in parallel. For virtlogd/virtlockd, we want the socket to be already active when the hypervisor driver is started. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/libxl/meson.build | 1 + src/qemu/meson.build | 2 ++ src/remote/libvirtd.service.in | 7 ++++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/libxl/meson.build b/src/libxl/meson.build index e84999e14d..ad8d9b757f 100644 --- a/src/libxl/meson.build +++ b/src/libxl/meson.build @@ -69,6 +69,7 @@ if conf.has('WITH_LIBXL') 'name': 'Libvirt libxl', 'service_unit_extra': [ 'Wants=3Dvirtlockd.socket', + 'After=3Dvirtlockd.socket', 'After=3Dremote-fs.target', 'After=3Dxencommons.service', 'Conflicts=3Dxendomains.service', diff --git a/src/qemu/meson.build b/src/qemu/meson.build index 7e5db09e0c..bf900e3f14 100644 --- a/src/qemu/meson.build +++ b/src/qemu/meson.build @@ -187,6 +187,8 @@ if conf.has('WITH_QEMU') 'service_unit_extra': [ 'Requires=3Dvirtlogd.socket', 'Wants=3Dvirtlockd.socket', + 'After=3Dvirtlogd.socket', + 'After=3Dvirtlockd.socket', 'Wants=3Dsystemd-machined.service', 'After=3Dsystemd-machined.service', 'After=3Dremote-fs.target', diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in index 8839c00a15..a2c3c8f8fa 100644 --- a/src/remote/libvirtd.service.in +++ b/src/remote/libvirtd.service.in @@ -1,13 +1,18 @@ [Unit] Description=3DVirtualization daemon -Requires=3Dvirtlogd.socket # Use Wants instead of Requires so that users # can disable these three .socket units to revert # to a traditional non-activation deployment setup Wants=3Dlibvirtd.socket Wants=3Dlibvirtd-ro.socket Wants=3Dlibvirtd-admin.socket +After=3Dlibvirtd.socket +After=3Dlibvirtd-ro.socket +After=3Dlibvirtd-admin.socket +Requires=3Dvirtlogd.socket Wants=3Dvirtlockd.socket +After=3Dvirtlogd.socket +After=3Dvirtlockd.socket Wants=3Dsystemd-machined.service After=3Dnetwork.target After=3Ddbus.service --=20 2.41.0