From nobody Mon Feb 9 19:25:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695668472; cv=none; d=zohomail.com; s=zohoarc; b=W1vIWD6djnC74BCLVLEW71GSq/poSW0UnUOnOTu5pSQAzAoXHDPa5HBudtggQFyv8JBtOhR2q8K71ECwzjUH1dwgZD/mRj7IYgMDHPr1ny8z8mA/RfBtV4SssOX8/we8B3FeqVp/RJrnULSiTMjf9t1B4m3uZ0YJHhSohBOJJ9U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695668472; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=o5Pjnu7M0NRbfs0t8VtvCnDYMH6n50gTLsxRhorwCNM=; b=XMQm//t1KsrkrU6EAEzxkmf1ofOWwvPlpUj6qGKxVxW0Vm7Ss60xV3OE6AkvcWlwgRzyeybJAJrlxMSpl38ie/ff/17X3a5jx5v5TX8ljL7r9Rd5TwYewYZOwdEfryLaz4tWRdZiUeY4PNx1A/lSfug6VO337YhvjRdz+uvH6Fk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1695668472432471.1087380379622; Mon, 25 Sep 2023 12:01:12 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-306-m61Ba3Q4MBOLDVC2H3k0cg-1; Mon, 25 Sep 2023 14:59:51 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F24DC18162C1; Mon, 25 Sep 2023 18:59:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB54221CAC8D; Mon, 25 Sep 2023 18:59:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C101B1946A76; Mon, 25 Sep 2023 18:59:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D11ED1946A43 for ; Mon, 25 Sep 2023 18:59:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C0A0F711294; Mon, 25 Sep 2023 18:59:37 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54C50711293 for ; Mon, 25 Sep 2023 18:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695668471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=o5Pjnu7M0NRbfs0t8VtvCnDYMH6n50gTLsxRhorwCNM=; b=OXZzJC0MQcQr/dzzcv+S6t3ubIqDnsZ+OMV5NONAvS+ur0347/+55+M3RgkFyw5FQnuHV2 H9g/eR1uduojagvs9Q4n6/92qjCZvBdBHzeyRFXI09jFeQTqoYAtaqu2na7nshMPjkfxiV 0quJTJHT6b16c2abXTaPcOVEawZQ1h4= X-MC-Unique: m61Ba3Q4MBOLDVC2H3k0cg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 32/42] systemd: Drop parametrization from libvirtd sockets Date: Mon, 25 Sep 2023 20:58:30 +0200 Message-ID: <20230925185840.880191-33-abologna@redhat.com> In-Reply-To: <20230925185840.880191-1-abologna@redhat.com> References: <20230925185840.880191-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695668473394100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Up until now the files have been used as template for most services, but now that those have been converted to common templates we can drop parametrization and make it clear that these files are for libvirtd only. Signed-off-by: Andrea Bolognani --- src/remote/libvirtd-admin.socket.in | 10 +++++----- src/remote/libvirtd-ro.socket.in | 10 +++++----- src/remote/libvirtd-tcp.socket.in | 8 ++++---- src/remote/libvirtd-tls.socket.in | 8 ++++---- src/remote/libvirtd.socket.in | 6 +++--- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/remote/libvirtd-admin.socket.in b/src/remote/libvirtd-admi= n.socket.in index 39bb0badea..8d927db63b 100644 --- a/src/remote/libvirtd-admin.socket.in +++ b/src/remote/libvirtd-admin.socket.in @@ -1,12 +1,12 @@ [Unit] Description=3D@name@ admin socket -Before=3D@service@.service -BindsTo=3D@service@.socket -After=3D@service@.socket +Before=3Dlibvirtd.service +BindsTo=3Dlibvirtd.socket +After=3Dlibvirtd.socket =20 [Socket] -ListenStream=3D@runstatedir@/libvirt/@sockprefix@-admin-sock -Service=3D@service@.service +ListenStream=3D@runstatedir@/libvirt/libvirt-admin-sock +Service=3Dlibvirtd.service SocketMode=3D0600 =20 [Install] diff --git a/src/remote/libvirtd-ro.socket.in b/src/remote/libvirtd-ro.sock= et.in index b7b7ae0dd8..cc10190ab4 100644 --- a/src/remote/libvirtd-ro.socket.in +++ b/src/remote/libvirtd-ro.socket.in @@ -1,12 +1,12 @@ [Unit] Description=3D@name@ local read-only socket -Before=3D@service@.service -BindsTo=3D@service@.socket -After=3D@service@.socket +Before=3Dlibvirtd.service +BindsTo=3Dlibvirtd.socket +After=3Dlibvirtd.socket =20 [Socket] -ListenStream=3D@runstatedir@/libvirt/@sockprefix@-sock-ro -Service=3D@service@.service +ListenStream=3D@runstatedir@/libvirt/libvirt-sock-ro +Service=3Dlibvirtd.service SocketMode=3D0666 =20 [Install] diff --git a/src/remote/libvirtd-tcp.socket.in b/src/remote/libvirtd-tcp.so= cket.in index 7c8bcdb525..bc35f19c06 100644 --- a/src/remote/libvirtd-tcp.socket.in +++ b/src/remote/libvirtd-tcp.socket.in @@ -1,12 +1,12 @@ [Unit] Description=3D@name@ non-TLS IP socket -Before=3D@service@.service -BindsTo=3D@service@.socket -After=3D@service@.socket +Before=3Dlibvirtd.service +BindsTo=3Dlibvirtd.socket +After=3Dlibvirtd.socket =20 [Socket] ListenStream=3D16509 -Service=3D@service@.service +Service=3Dlibvirtd.service =20 [Install] WantedBy=3Dsockets.target diff --git a/src/remote/libvirtd-tls.socket.in b/src/remote/libvirtd-tls.so= cket.in index c6dceb2d4e..868a0be318 100644 --- a/src/remote/libvirtd-tls.socket.in +++ b/src/remote/libvirtd-tls.socket.in @@ -1,12 +1,12 @@ [Unit] Description=3D@name@ TLS IP socket -Before=3D@service@.service -BindsTo=3D@service@.socket -After=3D@service@.socket +Before=3Dlibvirtd.service +BindsTo=3Dlibvirtd.socket +After=3Dlibvirtd.socket =20 [Socket] ListenStream=3D16514 -Service=3D@service@.service +Service=3Dlibvirtd.service =20 [Install] WantedBy=3Dsockets.target diff --git a/src/remote/libvirtd.socket.in b/src/remote/libvirtd.socket.in index aec0708fd4..ea0554546a 100644 --- a/src/remote/libvirtd.socket.in +++ b/src/remote/libvirtd.socket.in @@ -1,10 +1,10 @@ [Unit] Description=3D@name@ local socket -Before=3D@service@.service +Before=3Dlibvirtd.service =20 [Socket] -ListenStream=3D@runstatedir@/libvirt/@sockprefix@-sock -Service=3D@service@.service +ListenStream=3D@runstatedir@/libvirt/libvirt-sock +Service=3Dlibvirtd.service SocketMode=3D@sockmode@ RemoveOnStop=3Dyes =20 --=20 2.41.0