From nobody Mon Nov 17 15:15:46 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1694466577; cv=none; d=zohomail.com; s=zohoarc; b=ZsxrD1acdydSbeOgXKCQPmxx6HVfM1TpywgETq1S7245BaR8KMmDt3930omc+Z/OU1zKjwor85Uf1ptCP2I+4AzgmG7ENvqNkEdo4hd+GIPJq1DztytLd7gyhTH1EiczHWu2PJEMg++tFAmjiS/i4MImVOTJt2IpR3iBucCKLTg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694466577; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VDWx2nmUZotbZAP2LjtHNhpxoRZNKCZHSc6DW6R3zPg=; b=Xvbzk0DQZu6cAPso0NHURhcC7IURoneWYRstJfPjQ5RzfFwbya9eooWe1bdboSDR+XiwPwJ2G0GMADrL0uMXtFc35wpOU3kNP0oSrzwV252njsveuOy4UrtuzzHukSH3yQISSA34CmNJ72DJkBezftSJHBGgSdApZRFSfS6QH48= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=reject dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1694466577146873.3605608029644; Mon, 11 Sep 2023 14:09:37 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-113-0rhQwMzUOMGckugc2bme1w-1; Mon, 11 Sep 2023 17:09:29 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7253B8A4373; Mon, 11 Sep 2023 21:09:23 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D64C2156702; Mon, 11 Sep 2023 21:09:23 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 414121946597; Mon, 11 Sep 2023 21:09:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 319C919465B2 for ; Mon, 11 Sep 2023 21:09:21 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 12D432027045; Mon, 11 Sep 2023 21:09:21 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0AD502026D68 for ; Mon, 11 Sep 2023 21:09:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E34E63803923 for ; Mon, 11 Sep 2023 21:09:20 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-642-ILTJexQ2OwOJa06y0XGR8w-1; Mon, 11 Sep 2023 17:09:19 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38BL7ksw017223 for ; Mon, 11 Sep 2023 21:09:17 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3t29dy9tad-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Sep 2023 21:09:17 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 38BJ53Y2012083 for ; Mon, 11 Sep 2023 21:09:16 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3t13dydybh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Sep 2023 21:09:16 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 38BL9FLx35979788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Sep 2023 21:09:15 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E69E65805A; Mon, 11 Sep 2023 21:09:14 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A7FB158056; Mon, 11 Sep 2023 21:09:14 +0000 (GMT) Received: from li-d664314c-3171-11b2-a85c-fa8047ef35bd.ibm.com.com (unknown [9.67.49.93]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 11 Sep 2023 21:09:14 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694466576; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VDWx2nmUZotbZAP2LjtHNhpxoRZNKCZHSc6DW6R3zPg=; b=EVhao28wY92/Asauu0DQ0CIzn2Tg40//a2WUv4F+xEIt6V1DwwJUpzkEBlwPtCEfltzvJk d8DyV9hO0HQWeeRo1JXmrEQCwTKuY+24MIUOTdFk3IF+JlZ+xaFnhmjRRV751oT5/WKFo8 HBHgc15oikiRl5IRh6+gEwN2R0LFk7M= X-MC-Unique: 0rhQwMzUOMGckugc2bme1w-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: ILTJexQ2OwOJa06y0XGR8w-1 From: Collin Walling To: libvir-list@redhat.com Subject: [PATCH v1 5/9] cpu: conf: add cpu mode for host-recommended Date: Mon, 11 Sep 2023 17:07:12 -0400 Message-ID: <20230911210716.75648-6-walling@linux.ibm.com> In-Reply-To: <20230911210716.75648-1-walling@linux.ibm.com> References: <20230911210716.75648-1-walling@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: yK1vhDzjLbZIMYYIvRMdxENjbMppmZ4C X-Proofpoint-ORIG-GUID: yK1vhDzjLbZIMYYIvRMdxENjbMppmZ4C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-11_16,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 spamscore=0 phishscore=0 mlxlogscore=784 mlxscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309110194 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Fiuczynski Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: linux.ibm.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694466635496100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Add VIR_CPU_MODE_HOST_RECOMMENDED for host-recommended CPU models and satisfy all switch cases. For the most part, host-recommended will follow similar paths as host-model, aside from touching any architecture specifics. Signed-off-by: Collin Walling Reviewed-by: Boris Fiuczynski --- src/conf/cpu_conf.c | 1 + src/conf/cpu_conf.h | 1 + src/cpu/cpu.c | 1 + src/cpu/cpu_ppc64.c | 2 ++ src/qemu/qemu_capabilities.c | 4 ++++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c | 2 ++ src/qemu/qemu_validate.c | 1 + 8 files changed, 13 insertions(+) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 7abe489733..c0116808d8 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -43,6 +43,7 @@ VIR_ENUM_IMPL(virCPUMode, "host-model", "host-passthrough", "maximum", + "host-recommended", ); =20 VIR_ENUM_IMPL(virCPUMatch, diff --git a/src/conf/cpu_conf.h b/src/conf/cpu_conf.h index 3e4c53675c..f73d852e69 100644 --- a/src/conf/cpu_conf.h +++ b/src/conf/cpu_conf.h @@ -44,6 +44,7 @@ typedef enum { VIR_CPU_MODE_HOST_MODEL, VIR_CPU_MODE_HOST_PASSTHROUGH, VIR_CPU_MODE_MAXIMUM, + VIR_CPU_MODE_HOST_RECOMMENDED, =20 VIR_CPU_MODE_LAST } virCPUMode; diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index bb5737e938..805aff1bf5 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -587,6 +587,7 @@ virCPUUpdate(virArch arch, return 0; =20 case VIR_CPU_MODE_HOST_MODEL: + case VIR_CPU_MODE_HOST_RECOMMENDED: relative =3D true; break; =20 diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c index e13cdbdf6b..dc42e869e7 100644 --- a/src/cpu/cpu_ppc64.c +++ b/src/cpu/cpu_ppc64.c @@ -483,6 +483,8 @@ ppc64Compute(virCPUDef *host, * look up guest CPU information */ guest_model =3D ppc64ModelFromCPU(cpu, map); break; + case VIR_CPU_MODE_HOST_RECOMMENDED: + break; } } else { /* Other host CPU information */ diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 59403808ee..d7096a08c2 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2340,6 +2340,10 @@ virQEMUCapsIsCPUModeSupported(virQEMUCaps *qemuCaps, case VIR_CPU_MODE_MAXIMUM: return virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_MAX); =20 + case VIR_CPU_MODE_HOST_RECOMMENDED: + return !!virQEMUCapsGetHostModel(qemuCaps, type, + VIR_QEMU_CAPS_HOST_CPU_RECOMMENDE= D); + case VIR_CPU_MODE_LAST: break; } diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a912ed064f..a45e2fbb95 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6293,6 +6293,7 @@ qemuBuildCpuModelArgStr(virQEMUDriver *driver, virBufferAdd(buf, cpu->model, -1); break; =20 + case VIR_CPU_MODE_HOST_RECOMMENDED: case VIR_CPU_MODE_LAST: break; } diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index c7d64e1b5c..f7493431ac 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4753,6 +4753,7 @@ qemuDomainDefCPUPostParse(virDomainDef *def, break; =20 case VIR_CPU_MODE_HOST_MODEL: + case VIR_CPU_MODE_HOST_RECOMMENDED: def->cpu->check =3D VIR_CPU_CHECK_PARTIAL; break; =20 @@ -6995,6 +6996,7 @@ qemuDomainObjCheckCPUTaint(virQEMUDriver *driver, } break; case VIR_CPU_MODE_HOST_MODEL: + case VIR_CPU_MODE_HOST_RECOMMENDED: case VIR_CPU_MODE_LAST: default: break; diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 1346bbfb44..387c2f1fa8 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -372,6 +372,7 @@ qemuValidateDomainDefCpu(virQEMUDriver *driver, } break; =20 + case VIR_CPU_MODE_HOST_RECOMMENDED: case VIR_CPU_MODE_CUSTOM: case VIR_CPU_MODE_LAST: break; --=20 2.41.0