From nobody Sun May 19 12:45:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1690845033; cv=none; d=zohomail.com; s=zohoarc; b=JNqVHYFzLsiMj55BOzFVKocHGFUpzyZh38YLYHDscD4KcK1dSbMv4OkX7059DAaZJ7jsdZYmsUlIpKgHihL+0HXDzMuOliu0J5uJ5onF2vRgGBi9LkiUY/8wNhsMm82VLROFQ61wFMhxHkuAEzajlY0eBJtwsauFXQPRACYrAOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690845033; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TDqu18UA8BUwoY4PgrXxKIP16GSnGADjtC4u1O/0zSY=; b=LBlysrtUWCPbv3tYbJ2HgpMgVhNKCWlor8yk1bdqyf/kp+ZVzZNqETJGzYF8DyMB0ckte+YB8IT3Og1PdRygrn63bmGUi4e8caicpQtotkdPo+lXgf4V68sNAdec1aQSpH1rv4rxq/lSGsTGk7xz90T/Tkd9PsgaJ8QFjyS0rsE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1690845033265448.03118428809137; Mon, 31 Jul 2023 16:10:33 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-134-iS8QkhhRMaKBdk9GLcV0-w-1; Mon, 31 Jul 2023 19:10:27 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8ED98870CF; Mon, 31 Jul 2023 23:10:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5519F112132E; Mon, 31 Jul 2023 23:10:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EBE1919451C9; Mon, 31 Jul 2023 23:10:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6985D1946A41 for ; Mon, 31 Jul 2023 23:08:03 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id D942A492CA6; Mon, 31 Jul 2023 23:08:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0342492B03 for ; Mon, 31 Jul 2023 23:08:02 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-inbound-delivery-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95CE1185A78B for ; Mon, 31 Jul 2023 23:08:02 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2045.outbound.protection.outlook.com [40.107.7.45]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-257-667_UQzBO1izcKQwJxn43A-2; Mon, 31 Jul 2023 19:08:00 -0400 Received: from DB7PR04MB5980.eurprd04.prod.outlook.com (2603:10a6:10:88::11) by DB9PR04MB9425.eurprd04.prod.outlook.com (2603:10a6:10:36b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 23:07:57 +0000 Received: from DB7PR04MB5980.eurprd04.prod.outlook.com ([fe80::6382:a6b4:d0f7:54c3]) by DB7PR04MB5980.eurprd04.prod.outlook.com ([fe80::6382:a6b4:d0f7:54c3%4]) with mapi id 15.20.6631.043; Mon, 31 Jul 2023 23:07:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690845032; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TDqu18UA8BUwoY4PgrXxKIP16GSnGADjtC4u1O/0zSY=; b=eGeRf6PPOleM93VQM9pcePwD1VO1JoG3TzvAXp8kheAF+lVs4ZeoybxDJuQr6jX2BrkJEg rpu7LDt6tl+VwLEjNG8tE1VfjsHIVdNjDREwwRiujXAIzIrMtjYCQ2ttl/DWnx3f6WJIwY 99pioATNVCJIrrvpiaN9zZp6iFZrj80= X-MC-Unique: iS8QkhhRMaKBdk9GLcV0-w-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 667_UQzBO1izcKQwJxn43A-2 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH 1/2] libvirt-guests: Remove unused variable 'libvirtd' Date: Mon, 31 Jul 2023 17:06:45 -0600 Message-ID: <20230731230749.15856-2-jfehlig@suse.com> In-Reply-To: <20230731230749.15856-1-jfehlig@suse.com> References: <20230731230749.15856-1-jfehlig@suse.com> X-ClientProxiedBy: FR2P281CA0096.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::19) To DB7PR04MB5980.eurprd04.prod.outlook.com (2603:10a6:10:88::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR04MB5980:EE_|DB9PR04MB9425:EE_ X-MS-Office365-Filtering-Correlation-Id: a4939497-f90c-4aa4-3938-08db921afa6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: IrR309ANyw09dH0f2yaJL4YvBVJASTW4lJgl3epQNkO56rTJCPKxdYXuLd8uDYyhmx+AmQX/Gxt79eipT10bK6PLpaVZpMTh0VmmoZX5rcXvgKSBFFb43GQ51gIvfYs7ymMgsHNy/tcdGb9rM9gTFlWtio3tqvfuCyLgLLbYihbUDOtJmWUtWLsHy0NhFwW9XlrfyOyi2gBY1gxI5+MQSgk49LJlaAyjj7tMNLMYazy7mTd0zZ3MODkOSlzKbIqNp2PEUKzB+ppg34SI4ADy8kybiF8pJzyjh+UBtDZ59SNebbujU7CD3f4fFrcZlfeBPK9v051uBEDOdmRmAFEomgTdRMpbpgAMr3BlwIOV/7zdMUygqAxf1fo6tJSOibcb6KtdTVLQhRlf6q5pTlmo2RaSNhzmrL7OyT1G8Z20E5HO2mvEC0+4jv701gXDVcXpO8QKQfop+fVwR0zSzQJ8mCEN36LeB3HwW6LFsRkB69rs8Eb88g0+ByHhfAWEMZI97UlIFc0EP8TZTlKggjJnpK6587cNYKtO+5FH/L13zu7dAfMHlhJMhtnLXYQ0Zc/e X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR04MB5980.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(376002)(396003)(346002)(39860400002)(366004)(451199021)(86362001)(66476007)(8936002)(6916009)(8676002)(316002)(5660300002)(41300700001)(38100700002)(66556008)(66946007)(478600001)(4744005)(2906002)(6666004)(36756003)(6512007)(6486002)(6506007)(1076003)(26005)(83380400001)(186003)(2616005); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VrQFjZcEm00c9mlDlJuZDm8ur8uH/c8NCJOfQD6tnkHhRQWGdIKyLbIgQbrP?= =?us-ascii?Q?JnIk8igeLU1L76PeeTbcLQ0pCWoBmmzE3VDI+qYAIQCwPp5FEdGgfdPhl4Vs?= =?us-ascii?Q?LWuXwq7Y5q/2EoACwWN1ShXOQHfGLM/CAlvTnfyzb0Lna/19LpZzTosgsFk4?= =?us-ascii?Q?/kVqx4IZU5tHwTYRxNpG69yosU77OqKaDd/T7kcdFNW5tUtmOppPkNq5JXqX?= =?us-ascii?Q?NFULqlpDYElZRKWH2Xs0/8qsmRFUW3Y9GlIWZpL8plLU5TenVA4ho66u8esK?= =?us-ascii?Q?RaxB8a4g0MKgFp9+fP7NJqvTkGj+9xu+Ktilc/6/+3R5sKW7pNRAnnELcu5u?= =?us-ascii?Q?tV7QKSrUdvR1VTm5ZahWC/4UCb9ViPE4rFauBaB8WQk3imu9R2e/jBfvStCZ?= =?us-ascii?Q?6IK3rV5Jo5cers2cavSXumifuW59N50dQgUUhIGFwRxNuX6En6dgO3Mr3KgD?= =?us-ascii?Q?Sgq0JWzDey8zCZF3j2UG2vKZXmCtR8+dh/nGr12GfXmEsZOzI1VsEZH4Tc0Y?= =?us-ascii?Q?cwXXtgHLrZVcUP/2SK0FX3mNFVWQc8RDzS72T3GDY3KrPnn2Jnug6yo9fbfb?= =?us-ascii?Q?oXNzBrfERJCeg5pFGsbKBgWvwQVGsYePvj20m5CyFq9+20eZ22hp30dOa6oN?= =?us-ascii?Q?12b27S8CnasEadHroaRVTRBjodOY/1fARElWMNWEGzagZHui86/v/8GXE/Hw?= =?us-ascii?Q?Uz/A6m5Mvb2Fpr2a/Sze9PbjWXpYa+Y1VcWfo4wpyIh2GA634Zj/r0d8eEwB?= =?us-ascii?Q?wjKl+NSIAL4k3HX2kgEiGv9R0r1nZ0zZ94490zVuYNzClDSsb+hDWfRnkq1E?= =?us-ascii?Q?ziVWeLtiL3RNBiTBrWSCtkBImgK/kXz8SQVFQ/9oTKvAYPeHXbgRqu7tC/hQ?= =?us-ascii?Q?Lfer4LraMeBRSS+18GhOMvrpIJjPKWSXQ5naO6w3RTCPM23u+fezR9SjIDWm?= =?us-ascii?Q?gvpc0EaFmceF7YDNMhK86Y0xmbDxroiwuKm826AiVdaViG9Nj/uXYp79WuyH?= =?us-ascii?Q?gxjSwBA4LBufcJdVuzDD62yuMMb2kXHs0OVdX1NDjAI7edEernCEURrfIVyp?= =?us-ascii?Q?bX5lbTPM1iyW9FBWm3Z89eAYI6jgUIYPoVXqeBx6CQKaAzPutvbRzGp5Zu+X?= =?us-ascii?Q?iQBKLgwVil71hdO5P+C2S+ZXevwgYB10iwuNZu9/8GqfUvsd9oGU5h9tYQyy?= =?us-ascii?Q?0Lj/JKor+hyeOjiFjZx2fSscBdKtNCGpw0FclkVAuk6iZ0RYhREGOIbRDTaZ?= =?us-ascii?Q?nyA6+FWvXpG9ZvdyFMqAlVlQADIpoCle5JHurBYa6oHWJ0TcSfHY2J8dVAyh?= =?us-ascii?Q?NJEA5SlCDNcE6Bsl8zVgghjA0k3XAKcBcIJDc+VTL+P2V30VOZQeq2A16EJa?= =?us-ascii?Q?VAsapAWIhl0Q2C5UPHv4rF8YfUF/nhaV4TQMdn7BmlBg401IiHwjmgHsIxMZ?= =?us-ascii?Q?z/7ClRdTPqL44Ru7fJ4cKT9n0qkUFoGQdzNjXa0hA2WfV3hN1am/WGgeyOUA?= =?us-ascii?Q?k1A+HbgwdVRMMpc9IFUW2PZouPzoQkkTGb7kKDvnbC/aNOlNA7ING0WWKJgc?= =?us-ascii?Q?b0tTvj1kFcMV6rBOrypeXPvO3+OiwSGShDGZR8EE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4939497-f90c-4aa4-3938-08db921afa6e X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5980.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 23:07:57.2714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YX+VYnk+pOveX4MgTvFLppO0E9AKZQ5rJ+0i5i0kP+WhjYsqgOelJjU3zrsFGUypTSFlOE1WCcCPN+7e5Gb85g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9425 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: suse.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1690845035670100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Jim Fehlig Reviewed-by: Martin Kletzander --- tools/libvirt-guests.sh.in | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 016014215f..344b54390a 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -19,7 +19,6 @@ sysconfdir=3D"@sysconfdir@" localstatedir=3D"@localstatedir@" initconfdir=3D"@initconfdir@" -libvirtd=3D"@sbindir@"/libvirtd =20 # Source function library. test ! -r "$sysconfdir"/rc.d/init.d/functions || --=20 2.41.0 From nobody Sun May 19 12:45:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1690846876; cv=none; d=zohomail.com; s=zohoarc; b=E2tXNYa3Ssd3DUNBevRVXVrsGPpgJIfmrQlBAqe9F7phBwZSu1S9i5vOB/2Ly+HJ1aeAbn/7FF+ngvNIJDihVJavw1feb0uT/lrqHeNVIvxqjkVhXpoYQ39Ijxp6bJHd0nHmP6y1oH7mpE0S9smwr07CEdDLO2YNlAAuu/OJ/b8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690846876; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S0Cdw+TNrRtQXIh9BknbNtif/mY2BHPdh7fzwtiyTqM=; b=VNB4QufUyocHIrOLuMEOs+E2k+G7kd2rmMFai44hAb5wFu9Qik1NM021ZQI0gokkaM6u372XWVZTbvLBSLrq5j61n3hSYlykcktB8OHDj0I6PzzXyvXZt7o21P65oqgIetb6LlKOpGFpvYGlYrPV+FCEml3TpJMnKlmquE5zYgA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1690846875959430.4984841651733; Mon, 31 Jul 2023 16:41:15 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-678-QiYWCTisP-aFdbLUVOn-GA-1; Mon, 31 Jul 2023 19:41:12 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF643104D51C; Mon, 31 Jul 2023 23:41:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D69A40D283A; Mon, 31 Jul 2023 23:41:05 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 20CEE1946A79; Mon, 31 Jul 2023 23:41:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6E08F1946A5A for ; Mon, 31 Jul 2023 23:08:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 409C71454143; Mon, 31 Jul 2023 23:08:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36DD71415115 for ; Mon, 31 Jul 2023 23:08:04 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-inbound-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19AE4803DBE for ; Mon, 31 Jul 2023 23:08:04 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2045.outbound.protection.outlook.com [40.107.7.45]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-257-l284Eq6rPNyoDKUuwmaS7A-3; Mon, 31 Jul 2023 19:08:02 -0400 Received: from DB7PR04MB5980.eurprd04.prod.outlook.com (2603:10a6:10:88::11) by DB9PR04MB9425.eurprd04.prod.outlook.com (2603:10a6:10:36b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 23:08:00 +0000 Received: from DB7PR04MB5980.eurprd04.prod.outlook.com ([fe80::6382:a6b4:d0f7:54c3]) by DB7PR04MB5980.eurprd04.prod.outlook.com ([fe80::6382:a6b4:d0f7:54c3%4]) with mapi id 15.20.6631.043; Mon, 31 Jul 2023 23:08:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690846874; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=S0Cdw+TNrRtQXIh9BknbNtif/mY2BHPdh7fzwtiyTqM=; b=EfQqr4c4MD0OL1mhxiDPRKAuHXzcpWIogSY7MiIXu/nSNM/RuXinn+wSMQ/sWZlph17m0s W2zWKF7/Z9Q3JkyCCM6owALe/ezkLsYSN7yWbIoqn9aDMIXJRbHIU0NGwAhNsCgW309uhb oz/SFw5rli4Z6cLdwO6VJW7Dnz1Leck= X-MC-Unique: QiYWCTisP-aFdbLUVOn-GA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: l284Eq6rPNyoDKUuwmaS7A-3 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH 2/2] libvirt-guests: Add systemd odering dependency to virtproxyd Date: Mon, 31 Jul 2023 17:06:46 -0600 Message-ID: <20230731230749.15856-3-jfehlig@suse.com> In-Reply-To: <20230731230749.15856-1-jfehlig@suse.com> References: <20230731230749.15856-1-jfehlig@suse.com> X-ClientProxiedBy: FR2P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::15) To DB7PR04MB5980.eurprd04.prod.outlook.com (2603:10a6:10:88::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR04MB5980:EE_|DB9PR04MB9425:EE_ X-MS-Office365-Filtering-Correlation-Id: 688d304c-c0e3-4865-b577-08db921afc7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: FJwTQrIaWkFn5lcYqkY679ZLumv0gxOC1OjXiOpuIqDaCtQmyYx/6TEwlJdkNtFONd7Ey3nc4BQh1Gl9aTtjAUtsR6v1/fEu7ko65eSDfk4dgck85IU2wrvWOmZYXLdDeiVfg/CwfBlO88hoA+Uz98wUIDIMwTm0G3LlrAyVhBX8kNk/TWo/WpUbFpdzHFeq1W9u5OGD98cuLS1z7UO/Gbr9wbV1IIsmqLROzK6NoJVqzx120aHp08rTgJRycMBYs92tb//CU6qUQ3Nul9xrO//NHnfiRYN+dmDUPYkL0Clq/KJySBdJkaDyjhQeT7zMjVkovciid1E+kPS0XE1i+m4gcBiZ7JxgvKudpGRWkHmfO8FYLA89nNptQ1NtYbJJbInlPL3k8gM1X5UKBTwwY243sDvPqsp5RIz2ZiUnsx+l5mAIuvn1t8sI70nD1vGvH/T+f8UHOoyifCvfoSL5tjr46HR6twM/xzYdNQn0A46wAXWK/MRtCZ//d12qtHw5lkbf4ZZ+c8SHp96wleAp52RqVXI4l2bNKF/UcBkEsag= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR04MB5980.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(376002)(396003)(346002)(39860400002)(366004)(451199021)(86362001)(66476007)(8936002)(6916009)(8676002)(316002)(5660300002)(41300700001)(38100700002)(66556008)(66946007)(478600001)(2906002)(6666004)(36756003)(6512007)(6486002)(6506007)(1076003)(26005)(83380400001)(186003)(2616005); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qoLGqdzKCHHwekGjl3tQs0yxQ+pNGhGmYeWZVCyMNo/JOE00izAueLmz04qj?= =?us-ascii?Q?EVP9knbej7yERx/ygnzMytzYJFwCyDWrRAdymJzzHsLSQ8sMtJ6JuI9daS+w?= =?us-ascii?Q?aE7yUa93xpYXz9XhpL0Rqx3GYiWC5/XLYzuUjKLjYQF2CFE8snmnPPyFJVio?= =?us-ascii?Q?76CCePEReREcx4yPX6UpjBRjvPhOOgqogGOyDX3/kU2Pj2Lgga32CJmzjxLD?= =?us-ascii?Q?/a57+UfrCvJ+6TQLvK9KCU78fOz5hWoFSI4OZ8+JMn9AJRfQFQ2Mhf5hLovh?= =?us-ascii?Q?2EBwhDuKfD7k0UgFDZAGKKFwd5AbegTHEgNVv9qlsu9bIQR3y6ePpOllWMlO?= =?us-ascii?Q?usi+cOZYsWfyQg6mz0irk/QqcUu6NlsGCFmgQ0VWseQUoJ+p/JIoFhj633Rd?= =?us-ascii?Q?Zc2EtOAwjHg17tdV0ds5h2zU0Bg6PF+k+8Q+CVQWkOBPRXYMm4gyszzd6C20?= =?us-ascii?Q?a5o35wt1CUlDkYXwLEiKnv4rxjuVUEO16LH7CU8dNZzFBMzELmUbUKWc09AS?= =?us-ascii?Q?vVBF4elZvZcFZo8Tyse5/8UafJxdJWXHwimIyAVotgZY60oMevHPDtsq+9Zr?= =?us-ascii?Q?5a+AG75Reg8XiqUcWkRiW9xCBw8LVXxH2oOXbNO6yBV0uINhsGSeYOUJAmcm?= =?us-ascii?Q?guKNl1NwHgQFzIak29XE9wW5J/L+4jxpVP0957ctj6RTkch9Xjt/wbFkyyiH?= =?us-ascii?Q?RogZFjQ3wXMmZkCvnN+GqrgOoEx6Ab0MB7NA59717MolUEBWedEbnM8GucGT?= =?us-ascii?Q?gBTNCTFojqtD0bKJnesGu81Rl5T1HVY2OBtixielqj54CRuSq8cEUvZBGpbH?= =?us-ascii?Q?/a63qPLAEsg92I/cSM0J2S+yHqrQrBzC4EHpTSsOHFWo4MhMBW/jARyLAvZA?= =?us-ascii?Q?oPlgJlB3gCWhSZYTEUHElP+fdjn413DEZ+4YtiLYjXb6kxqo1qOzoat6R+ok?= =?us-ascii?Q?iFqCbeJasSSHxd4xfOLg8CHArydZqgdMv3jajaEOuNJbVzK6WCJmfI+u9DJn?= =?us-ascii?Q?znKAll3YqacCj2GmHnbUWrx32A9viYUp5r5Dr7uAK4KZdOOIp7CsLrGTvZkp?= =?us-ascii?Q?SCrqGPzqxjb3vFoGUYsNNHDSc7RF5DQ5L6WVW1C10FzsYrFbtYbuG3fJdh3a?= =?us-ascii?Q?mambAfywe4m5V8AIHAgQKzXAGavGVRnykoIFuxduBOC2a5j1iVHjYQM2YAHH?= =?us-ascii?Q?e7RY1oMYieT2F5IwU7P4b1kOzZiBcdZWBhz5bktO15boG6Oivx7Obcn3kf1l?= =?us-ascii?Q?1yGGS743ZVrdnCn16VktX5G1Sv+pG8DnxHl+yHajnpDWo+BWzKfAhebrHz18?= =?us-ascii?Q?WoR9N2AfKU8KtNz88nX8XEYCG8jiBVL/REUhdnY76K/YGuNBtZ7hTGmE3MnD?= =?us-ascii?Q?cm2Bsi1xHhd6ZF9MlNa9f3Lk416SknLMgAWd5OJmzBmZPZ7ptm4sWKSJQPvB?= =?us-ascii?Q?zSy+H6iXidv4QGBWHp4Fw0HIv96wBjD68c8umv+A+A356OX6HRLbgfSHLcvb?= =?us-ascii?Q?eNKlpNhODHG8D0dW0gCV9Z6u/HoQq79qrsCa6QSTBGKRiao9giBOiw67cCXG?= =?us-ascii?Q?w7QePcFDNyo4FdLSyi4eCLP7+jcemMR4sP7ux868?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 688d304c-c0e3-4865-b577-08db921afc7a X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5980.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 23:08:00.7983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zQV+bbt2vrtxZ5bkLiQdnetKWvypv2pXh9wdTgxgoZZUS/4PK2y/g268fj2xzf85XuDIPxU2h4Mfak8p5AiT2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9425 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: suse.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1690846876892100001 Content-Type: text/plain; charset="utf-8" It's possible to configure a system such that libvirt-guests connects to the legacy /run/libvirt/libvirt-sock when running modular daemons, in which case it connects to virtproxyd. If virtproxyd is stopped before libvirt-guests, the latter will fail to connect and no running guests will be stopped/suspended. Likewise on startup, virtproxyd must be availabel before libvirt-guests. Ensure these conditions are met by adding an 'After=3Dvirtproxyd.socket' ordering dependency to libvirt-guests. Signed-off-by: Jim Fehlig --- tools/libvirt-guests.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service= .in index c547218f2a..29607bbd66 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -9,6 +9,7 @@ After=3Dvirtlxcd.socket After=3Dvirtvboxd.socket After=3Dvirtvzd.socket After=3Dvirtxend.socket +After=3Dvirtproxyd.socket After=3Dvirt-guest-shutdown.target Documentation=3Dman:libvirt-guests(8) Documentation=3Dhttps://libvirt.org --=20 2.41.0