From nobody Sun May 19 21:29:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1689907042; cv=none; d=zohomail.com; s=zohoarc; b=A4qH/xAKHBBWXv8TbVi9D7plvV5OKVG16rxdSHmC0qzRyPW1mqm9nZ6SZbUkewKlKKp8hg1YSgIX6WTd476jT0oXEFc2m24KrjBIcBDRBPzhY78MVj3F0JwqXhSMs9uHFnsHElaVcTS4miYeG6S7iT2MjtRvMSbshgABCPR+zuY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689907042; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j3Ev3qALC2ZNrkKXUW73DZZF5505AZHScrcHHHQKDyo=; b=fMNLEFAayrLqBtbMBKI8FPlUXF+MpB2HWyDyEnJiFxzckvphK5f/5myRqg0uavJx0LtRLjz0Gv7jxATR0cF9+QaTalImnSD+IC/D1oMSPFqhQ5OGRU9jje1P1yamKSygVlt+uyeZfhJi1XTAoGJWxAc4muW+THAw4n/0iG6LMow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1689907042468216.8231399145168; Thu, 20 Jul 2023 19:37:22 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-581-I3HsiAyQMyWW2YigXF7Ktg-1; Thu, 20 Jul 2023 22:37:19 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1327E830DAC; Fri, 21 Jul 2023 02:37:17 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EDB11454147; Fri, 21 Jul 2023 02:37:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1FB9A1946A43; Fri, 21 Jul 2023 02:37:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4C70019465BA for ; Fri, 21 Jul 2023 02:37:07 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3F4DEC5796B; Fri, 21 Jul 2023 02:37:07 +0000 (UTC) Received: from localhost.localdomain (ovpn-13-7.pek2.redhat.com [10.72.13.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBB36C57969; Fri, 21 Jul 2023 02:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689907041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=j3Ev3qALC2ZNrkKXUW73DZZF5505AZHScrcHHHQKDyo=; b=c44e6MG0+v2B2f04/lWM1OaLwdCilfNfI22aMDzQzRAeUOEj7HwOBnZfdN8IVCSWz4pc+5 vnuKZv7QwoROkBmCtWzdyn+IrDS2OAldMYqds90BILdBMfsr/viuxoihN5Pl0yWpYdMQCC 3wdt0GEXQob76Ev9r4a2hMLJH7QNG6Y= X-MC-Unique: I3HsiAyQMyWW2YigXF7Ktg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Han Han To: libvir-list@redhat.com Subject: [PATCH 1/2] conf/domain_validate.c: Improve the err for queue validation Date: Fri, 21 Jul 2023 10:36:39 +0800 Message-ID: <20230721023700.438160-2-hhan@redhat.com> In-Reply-To: <20230721023700.438160-1-hhan@redhat.com> References: <20230721023700.438160-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Han Han Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1689907044277100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Queues is supported by virtio bus, including virtio-blk and vhost-user-blk. Signed-off-by: Han Han Reviewed-by: Michal Privoznik --- src/conf/domain_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 16bf3b559f..e835ad33ad 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -784,7 +784,7 @@ virDomainDiskDefValidate(const virDomainDef *def, =20 if (disk->queues) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("queues attribute in disk driver element is o= nly supported by virtio-blk")); + _("queues attribute in disk driver element is o= nly supported for virtio bus")); return -1; } =20 --=20 2.41.0 From nobody Sun May 19 21:29:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1689907042; cv=none; d=zohomail.com; s=zohoarc; b=gzTFbaPJna4YxXKG9aQE+gTA+sq8YUhWRkng7fl+YNK9PPRfC9FUt22hNTyyb4P7D+n38MvPSHsgf5Z4woUXoYLcWbEGz2d1fcfZe0MQtw38IWhX5ncRJn8GE6dVRF2PDE9jRA2NP8BPfbdnCTiwu57CuLvqjTWRDfBsYDXQRqY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689907042; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mI6Yn3VqcDMVHd7xMBNLzgNLfBVR5iKUOtRwdzWLPY4=; b=FlhWV4m/vI27w1i+h9RlZy1Y5gNgWpGnRk4hwYdNswGFQvYnEpsA+floqk6F1XBsXRP77mhW07mX9UyuTYiGQQxYdsB+iLCsECW4d4hGth7zxAQRgz1DKiURh4I7/Bb7/HMknroOlFaTYAo/RS61t+iTR6k8B3TL5HofKDtSbAw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 168990704268245.86374196705276; Thu, 20 Jul 2023 19:37:22 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-xMkJ6rypO0SZkPay5HmhsQ-1; Thu, 20 Jul 2023 22:37:19 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 11761185A794; Fri, 21 Jul 2023 02:37:17 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36BC51121315; Fri, 21 Jul 2023 02:37:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EF81119465BD; Fri, 21 Jul 2023 02:37:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 536B019465BA for ; Fri, 21 Jul 2023 02:37:09 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 36DFDC5796B; Fri, 21 Jul 2023 02:37:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-13-7.pek2.redhat.com [10.72.13.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAFD1C57969; Fri, 21 Jul 2023 02:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689907041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mI6Yn3VqcDMVHd7xMBNLzgNLfBVR5iKUOtRwdzWLPY4=; b=HOtcvVerqeYECy8ijNFP5gYG1g2U0gC4rXYVKDn4ydTm7tD86fcTlSFup1JXFTtEYK7T7L JbmsjCfRzLqOJ1wrflXZJPottvBHAaTddwe9kHo9An+KnAwkbHVnQJoDh/sriIT0iwoUa/ Q2IkqZ+EWB75gmp16yL+fckPcAyy2kI= X-MC-Unique: xMkJ6rypO0SZkPay5HmhsQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Han Han To: libvir-list@redhat.com Subject: [PATCH 2/2] conf/domain_validate: Validate the disk queue_size Date: Fri, 21 Jul 2023 10:36:40 +0800 Message-ID: <20230721023700.438160-3-hhan@redhat.com> In-Reply-To: <20230721023700.438160-1-hhan@redhat.com> References: <20230721023700.438160-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Han Han Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1689907044883100003 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Han Han Reviewed-by: Michal Privoznik --- src/conf/domain_validate.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index e835ad33ad..ad383b604e 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -788,6 +788,12 @@ virDomainDiskDefValidate(const virDomainDef *def, return -1; } =20 + if (disk->queue_size) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("queue_size attribute in disk driver is only = supported for virtio bus")); + return -1; + } + if (disk->event_idx !=3D VIR_TRISTATE_SWITCH_ABSENT) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("disk event_idx mode supported only for virti= o bus")); --=20 2.41.0