From nobody Mon Feb 9 17:22:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1689891668; cv=none; d=zohomail.com; s=zohoarc; b=lFLicgBXxXPp2nxWx5YxI/KEaRxiM27t7EcwLuaajdO/+Y5TYGMRZx2zJVZKrPrJ3GWsvqdWB6p8L6X1dsSvh0yd4r6eoDdM35/3VcCidUd+GFd2W6xci6izKU98aGwbyU3dOEGlcdHv4urXjuXyEvm6F/w7H4fapoLVPokvrbM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689891668; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FT1K453fcXNFNL+iEFNOxlRYe0RF3i3L/5n2FNsDjyg=; b=Bmru+gbnYPuIE+yEQZyTZ3bR2CREABT7ksd8EHidE4DFKbgRO+B1QI65IcoFmB0bWfE3cNdjuGDU2OCWHnMcSFkfQAOPZy7drcf851gU3ltrr6TOaTzTWSFMrgvp64F3SXnA5zu+nS3Un8syTPmqePd8Jy8ezLZgkFkFdsIU108= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1689891668704897.6466330454399; Thu, 20 Jul 2023 15:21:08 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-164-LCVgI5vIOQquV3BII6QK2Q-1; Thu, 20 Jul 2023 18:20:42 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 509B587323F; Thu, 20 Jul 2023 22:20:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 33480207B350; Thu, 20 Jul 2023 22:20:32 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C77B81946A6B; Thu, 20 Jul 2023 22:20:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C18DF19465BA for ; Thu, 20 Jul 2023 22:20:14 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B459D40B4CCB; Thu, 20 Jul 2023 22:20:12 +0000 (UTC) Received: from himantopus.redhat.com (unknown [10.22.8.155]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 92FA340C207D for ; Thu, 20 Jul 2023 22:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689891667; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FT1K453fcXNFNL+iEFNOxlRYe0RF3i3L/5n2FNsDjyg=; b=VJfsHr+ukSZ6sT5cXVdLsfxfHSnzQ1DiVXdxI7Ht2DUpCwKyEkHikMeGhg4vApC7LBXoP7 eZ4ci0OBoEbiqdCqKgwQsuOk8VErejee9fM6N7txSBPQHlnSME8K8oU0K7oCTRcb23NNHP I53nzA4tn3ZMAAKQ61zL/7VQirbgI2k= X-MC-Unique: LCVgI5vIOQquV3BII6QK2Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Jonathon Jongsma To: libvir-list@redhat.com Subject: [libvirt PATCH v6 33/36] schema: add ssh-agent configuration for ssh disks Date: Thu, 20 Jul 2023 17:20:00 -0500 Message-ID: <20230720222003.411549-34-jjongsma@redhat.com> In-Reply-To: <20230720222003.411549-1-jjongsma@redhat.com> References: <20230720222003.411549-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1689891670496100005 Content-Type: text/plain; charset="utf-8"; x-default="true" Add the ability to specify a path to a ssh-agent socket in order to use the ssh-agent to authenticate to remote ssh disks. Example configuration: ... ... Signed-off-by: Jonathon Jongsma --- docs/formatdomain.rst | 13 ++++++++----- src/conf/schemas/domaincommon.rng | 11 ++++++++--- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 364fe285a3..e7b14503b2 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -2989,11 +2989,14 @@ paravirtualized driver is specified via the ``disk`= ` element. are intended to be default, then the entire element may be omitted. =20 When using an ``ssh`` protocol, this element is used to enable - authentication via ssh keys. In this configuration, the element has = two - attributes. The ``username`` attribute specifies the name of the use= r on - the remote server and the ``keyfile`` attribute specifies the path t= o the - keyfile. Note that this only works for ssh keys that are not - password-protected. + authentication via ssh keys. In this configuration, the element has = three + possible attributes. The ``username`` attribute is required and spec= ifies + the name of the user on the remote server. ssh keys can be specified= in + one of two ways. The first way is by adding them to an ssh-agent and + providing the path to the ssh-agent socket in the ``agentsock`` + attribute. This method works for ssh keys with or without password + protection. Alternatively, for ssh keys without a password, the ssh = key + can be specified directly by setting the ``keyfile`` attribute. ``reconnect`` For disk type ``vhostuser`` configures reconnect timeout if the conn= ection is lost. This is set with the two mandatory attributes ``enabled`` a= nd diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 5b90b71dff..91f399e057 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -2201,9 +2201,14 @@ - - - + + + + + + + + --=20 2.41.0