From nobody Sun Feb 8 12:19:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1687355317; cv=none; d=zohomail.com; s=zohoarc; b=bFwJ1zMIug+MixM1DSvRTFvdWGfjpeYIPiQ2HoRYUCVN2cABwMyM25/NDhVOJ5Q8ADlf2Dggj9tEoyiFt6KO0TxAEYfbvIjgn4T0IS39BpB8rv0k0NzT8Jgyz5CpLVZKSIgvXPE9aKXwYkvfWhZJ+4wKnhIyyySsS4RqMDm8Vlc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1687355317; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4BeP33TekH7TKM8g02lljAVeRHAqgdUFQx+4Z9jBFX8=; b=LocMrDxIxV2wadtPPzvptpmI5jCtcxchMtDzN+yrl+vvqycwmCD8zQ7Rr6lNRRJ1FlPbtPw9r2w/jb47BCS7ZswhpJ3oATXAYnbVftK/KS9oOl1oc/uAGUS7fi7MMtebT4IcPBwStrVbJeEl0Qf1Wtv1NICijvA6q3Feerpl+o0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1687355317657897.809972204202; Wed, 21 Jun 2023 06:48:37 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-izqDBJQ5N1qkAbJV1rVvdw-1; Wed, 21 Jun 2023 09:48:34 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92B863C15FAA; Wed, 21 Jun 2023 13:48:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7C519112132E; Wed, 21 Jun 2023 13:48:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 220721946588; Wed, 21 Jun 2023 13:48:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2220D1946586 for ; Wed, 21 Jun 2023 13:32:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 15510425357; Wed, 21 Jun 2023 13:32:35 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.28.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 68CC0425358; Wed, 21 Jun 2023 13:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687355316; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4BeP33TekH7TKM8g02lljAVeRHAqgdUFQx+4Z9jBFX8=; b=L7Uc45YQ22M+OWvBIsxhX5N8fqI+fDtW0xHQiJZ1cPbWI3GcPkzbs4y/ZdOCE2eiDy5MWr aJfTjUnqXmgRY+u0FYZzH92SsToFG03wPgZ23ol0J5Ib+8CVoWl5uV4Bn1w69nzvSse6wt e9YnpCK3oBg/o1gu9OJIQHD1rLgqZ9w= X-MC-Unique: izqDBJQ5N1qkAbJV1rVvdw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/9] src: remove After=local-fs.target from systemd units Date: Wed, 21 Jun 2023 14:32:24 +0100 Message-Id: <20230621133232.4156333-2-berrange@redhat.com> In-Reply-To: <20230621133232.4156333-1-berrange@redhat.com> References: <20230621133232.4156333-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1687355319415100001 All services are ordered after local-fs.target unless they have set DefaultDependencies=3Dno, which we do not do. https://gitlab.com/libvirt/libvirt/-/issues/489 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/ch/virtchd.service.in | 1 - src/interface/virtinterfaced.service.in | 1 - src/libxl/virtxend.service.in | 1 - src/lxc/virtlxcd.service.in | 1 - src/network/virtnetworkd.service.in | 1 - src/node_device/virtnodedevd.service.in | 1 - src/nwfilter/virtnwfilterd.service.in | 1 - src/qemu/virtqemud.service.in | 1 - src/remote/libvirtd.service.in | 1 - src/remote/virtproxyd.service.in | 1 - src/secret/virtsecretd.service.in | 1 - src/storage/virtstoraged.service.in | 1 - src/util/virstring.c | 6 ++++++ src/vbox/virtvboxd.service.in | 1 - src/vz/virtvzd.service.in | 1 - 15 files changed, 6 insertions(+), 14 deletions(-) diff --git a/src/ch/virtchd.service.in b/src/ch/virtchd.service.in index a07c04a845..6e3b13446f 100644 --- a/src/ch/virtchd.service.in +++ b/src/ch/virtchd.service.in @@ -8,7 +8,6 @@ Wants=3Dsystemd-machined.service After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target After=3Dsystemd-logind.service After=3Dsystemd-machined.service diff --git a/src/interface/virtinterfaced.service.in b/src/interface/virtin= terfaced.service.in index 1be3ab32dc..5cb2cd19dc 100644 --- a/src/interface/virtinterfaced.service.in +++ b/src/interface/virtinterfaced.service.in @@ -7,7 +7,6 @@ Requires=3Dvirtinterfaced-admin.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target Documentation=3Dman:virtinterfaced(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/libxl/virtxend.service.in b/src/libxl/virtxend.service.in index abb1972777..c6a88f7fe9 100644 --- a/src/libxl/virtxend.service.in +++ b/src/libxl/virtxend.service.in @@ -8,7 +8,6 @@ Wants=3Dvirtlockd.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target After=3Dxencommons.service Conflicts=3Dxendomains.service diff --git a/src/lxc/virtlxcd.service.in b/src/lxc/virtlxcd.service.in index 2623f7375a..06c70ccde2 100644 --- a/src/lxc/virtlxcd.service.in +++ b/src/lxc/virtlxcd.service.in @@ -8,7 +8,6 @@ Wants=3Dsystemd-machined.service After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target After=3Dsystemd-logind.service After=3Dsystemd-machined.service diff --git a/src/network/virtnetworkd.service.in b/src/network/virtnetworkd= .service.in index 48423e777d..f35cccb8f7 100644 --- a/src/network/virtnetworkd.service.in +++ b/src/network/virtnetworkd.service.in @@ -10,7 +10,6 @@ After=3Diptables.service After=3Dip6tables.service After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target Documentation=3Dman:virtnetworkd(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/node_device/virtnodedevd.service.in b/src/node_device/virt= nodedevd.service.in index 3ceed30f29..2ac41db32e 100644 --- a/src/node_device/virtnodedevd.service.in +++ b/src/node_device/virtnodedevd.service.in @@ -7,7 +7,6 @@ Requires=3Dvirtnodedevd-admin.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target Documentation=3Dman:virtnodedevd(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/nwfilter/virtnwfilterd.service.in b/src/nwfilter/virtnwfil= terd.service.in index 37fa54d684..d6e98240a8 100644 --- a/src/nwfilter/virtnwfilterd.service.in +++ b/src/nwfilter/virtnwfilterd.service.in @@ -7,7 +7,6 @@ Requires=3Dvirtnwfilterd-admin.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target Documentation=3Dman:virtnwfilterd(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/qemu/virtqemud.service.in b/src/qemu/virtqemud.service.in index 032cbcbbf0..46917b746d 100644 --- a/src/qemu/virtqemud.service.in +++ b/src/qemu/virtqemud.service.in @@ -10,7 +10,6 @@ Wants=3Dsystemd-machined.service After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target After=3Dsystemd-logind.service After=3Dsystemd-machined.service diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in index 11507207a1..b691d35938 100644 --- a/src/remote/libvirtd.service.in +++ b/src/remote/libvirtd.service.in @@ -16,7 +16,6 @@ After=3Dip6tables.service After=3Ddbus.service After=3Discsid.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target After=3Dsystemd-logind.service After=3Dsystemd-machined.service diff --git a/src/remote/virtproxyd.service.in b/src/remote/virtproxyd.servi= ce.in index dd3bdf3429..9b829641f7 100644 --- a/src/remote/virtproxyd.service.in +++ b/src/remote/virtproxyd.service.in @@ -7,7 +7,6 @@ Requires=3Dvirtproxyd-admin.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target Documentation=3Dman:virtproxyd(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/secret/virtsecretd.service.in b/src/secret/virtsecretd.ser= vice.in index 774cfc3ecd..3804fe553b 100644 --- a/src/secret/virtsecretd.service.in +++ b/src/secret/virtsecretd.service.in @@ -7,7 +7,6 @@ Requires=3Dvirtsecretd-admin.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target Documentation=3Dman:virtsecretd(8) Documentation=3Dhttps://libvirt.org =20 diff --git a/src/storage/virtstoraged.service.in b/src/storage/virtstoraged= .service.in index e1a1ea6820..235fbc6798 100644 --- a/src/storage/virtstoraged.service.in +++ b/src/storage/virtstoraged.service.in @@ -8,7 +8,6 @@ After=3Dnetwork.target After=3Ddbus.service After=3Discsid.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target Documentation=3Dman:virtstoraged(8) Documentation=3Dhttps://libvirt.org diff --git a/src/util/virstring.c b/src/util/virstring.c index 6b728ff047..e189b9de31 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -50,6 +50,7 @@ virStrToLong_i(char const *s, char **end_ptr, int base, i= nt *result) =20 errno =3D 0; val =3D g_ascii_strtoll(s, &p, base); + g_assert(errno !=3D EAGAIN); err =3D (errno || (!end_ptr && *p) || p =3D=3D s || (int) val !=3D val= ); if (end_ptr) *end_ptr =3D p; @@ -71,6 +72,7 @@ virStrToLong_ui(char const *s, char **end_ptr, int base, = unsigned int *result) =20 errno =3D 0; val =3D g_ascii_strtoull(s, &p, base); + g_assert(errno !=3D EAGAIN); =20 /* This one's tricky. We _want_ to allow "-1" as shorthand for * UINT_MAX regardless of whether long is 32-bit or 64-bit. But @@ -103,6 +105,7 @@ virStrToLong_uip(char const *s, char **end_ptr, int bas= e, unsigned int *result) =20 errno =3D 0; val =3D g_ascii_strtoull(s, &p, base); + g_assert(errno !=3D EAGAIN); err =3D (memchr(s, '-', p - s) || errno || (!end_ptr && *p) || p =3D=3D s || (unsigned int) val != =3D val); if (end_ptr) @@ -160,6 +163,7 @@ virStrToLong_ulp(char const *s, char **end_ptr, int bas= e, =20 errno =3D 0; val =3D g_ascii_strtoull(s, &p, base); + g_assert(errno !=3D EAGAIN); err =3D (memchr(s, '-', p - s) || errno || (!end_ptr && *p) || p =3D=3D s || (unsigned long) val = !=3D val); if (end_ptr) @@ -202,6 +206,7 @@ virStrToLong_ull(char const *s, char **end_ptr, int bas= e, =20 errno =3D 0; val =3D g_ascii_strtoull(s, &p, base); + g_assert(errno !=3D EAGAIN); err =3D (errno || (!end_ptr && *p) || p =3D=3D s); if (end_ptr) *end_ptr =3D p; @@ -223,6 +228,7 @@ virStrToLong_ullp(char const *s, char **end_ptr, int ba= se, =20 errno =3D 0; val =3D g_ascii_strtoull(s, &p, base); + g_assert(errno !=3D EAGAIN); err =3D (memchr(s, '-', p - s) || errno || (!end_ptr && *p) || p =3D=3D s); if (end_ptr) diff --git a/src/vbox/virtvboxd.service.in b/src/vbox/virtvboxd.service.in index e73206591a..a567ed2443 100644 --- a/src/vbox/virtvboxd.service.in +++ b/src/vbox/virtvboxd.service.in @@ -7,7 +7,6 @@ Requires=3Dvirtvboxd-admin.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target Documentation=3Dman:virtvboxd(8) Documentation=3Dhttps://libvirt.org diff --git a/src/vz/virtvzd.service.in b/src/vz/virtvzd.service.in index bd98d96262..5521e89e10 100644 --- a/src/vz/virtvzd.service.in +++ b/src/vz/virtvzd.service.in @@ -7,7 +7,6 @@ Requires=3Dvirtvzd-admin.socket After=3Dnetwork.target After=3Ddbus.service After=3Dapparmor.service -After=3Dlocal-fs.target After=3Dremote-fs.target Documentation=3Dman:virtvzd(8) Documentation=3Dhttps://libvirt.org --=20 2.40.1