From nobody Sun Feb 8 16:24:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1686491074; cv=none; d=zohomail.com; s=zohoarc; b=ZtUoe7pvnFUCJ3CrGIb0kwaf+s+GZaSxqfOioloKH/nVXLTGgAr//y8QWRzPVDZOUMx4IFkHDjtt0odHsKojTdbvlSTHT1/afzi1cT4VEWdwpfgh/zOdOBFsLfkM1vG4+UJzWhgWUgk/Nt4D9VLo/PT2Nqbd60arYe0zWvA4MiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686491074; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=M83xeOuQ8QcB9RDTMYJpcQuUejRIPwhRv+lmiCVLMJo=; b=F5K8iqCNLvRhxP3aFgI6etkAubCtI8cMWbIXE/18L1c7zeTGEUKXOQ5muq/SHuniVBgo+YP+v0aXrFKWWud/IEKmC5KiJz/MP9hFSKjZcDI3iWMe9p6kaETlGXLhz4WVFNHvPMisdTWnyIbTbSigtc/knBDcxaQfpfMFjzWtN1g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1686491074935711.0863917894831; Sun, 11 Jun 2023 06:44:34 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-524-rWPXYBtCO82fd7tzyn-dbw-1; Sun, 11 Jun 2023 09:44:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30CD78060A9; Sun, 11 Jun 2023 13:44:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14FA52166B25; Sun, 11 Jun 2023 13:44:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E531719465B6; Sun, 11 Jun 2023 13:44:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A62E5194658C for ; Sun, 11 Jun 2023 13:44:23 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 884A1492B0D; Sun, 11 Jun 2023 13:44:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8029E492B0B for ; Sun, 11 Jun 2023 13:44:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 61F7E28237CA for ; Sun, 11 Jun 2023 13:44:23 +0000 (UTC) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2065.outbound.protection.outlook.com [40.107.241.65]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-cVHzdcxWMZu7CZqEpOddKQ-1; Sun, 11 Jun 2023 09:44:19 -0400 Received: from PAXPR04MB8607.eurprd04.prod.outlook.com (2603:10a6:102:21a::14) by AM9PR04MB8986.eurprd04.prod.outlook.com (2603:10a6:20b:409::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Sun, 11 Jun 2023 13:44:17 +0000 Received: from PAXPR04MB8607.eurprd04.prod.outlook.com ([fe80::ff9e:3629:f0c8:cfde]) by PAXPR04MB8607.eurprd04.prod.outlook.com ([fe80::ff9e:3629:f0c8:cfde%7]) with mapi id 15.20.6477.028; Sun, 11 Jun 2023 13:44:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686491074; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=M83xeOuQ8QcB9RDTMYJpcQuUejRIPwhRv+lmiCVLMJo=; b=Yvn6TcC77H5qaOi7JotT0LxebS/7Vx3usRCcAZN+svfaVbeWZATK7tgnv18xc4nXqGk4Fm 8pKXtWUlyNw8x9sSfjn1pnvgX4WA8ff3gFV9bmOmXXbIElsK2AL/YEUXGiHjvksg+/Oq5n Qj3Ac5IgDK5w5ccCxSok4lTSt6iyuX0= X-MC-Unique: rWPXYBtCO82fd7tzyn-dbw-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: cVHzdcxWMZu7CZqEpOddKQ-1 From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] qemu: Generate command line for notify VM exit feature Date: Sun, 11 Jun 2023 21:43:33 +0800 Message-ID: <20230611134334.3890-4-lma@suse.com> In-Reply-To: <20230611134334.3890-1-lma@suse.com> References: <20230611134334.3890-1-lma@suse.com> X-ClientProxiedBy: TY2PR0101CA0022.apcprd01.prod.exchangelabs.com (2603:1096:404:92::34) To PAXPR04MB8607.eurprd04.prod.outlook.com (2603:10a6:102:21a::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8607:EE_|AM9PR04MB8986:EE_ X-MS-Office365-Filtering-Correlation-Id: 520a3460-271b-4608-a220-08db6a81f384 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: W8Ii5ezoyBVJ7VgljHaHC6HGcUdhdWldyU8CFOQ7FLEjKXQU1WgUvN5eWep7B+q/eTrQo/8xEkVFeiO+fr6tF8Y+8mtYqbUTnC4VfO2RPOwMuUaQM8iz7bZAUXMumtUQE2mTCKi+c87tVE7N2shXM93javlInZsuVd3P1kXw7fdHjvl9TlPcOf/1N31c6gWlOajbBNN8vONmIzlwFiiz6MAbREOto08v8TpUKng3GaN4ej3ZEssXx/mQyn2gqAsDbvnJSvT3ZU1BtTjrp3DbHy/M8UgRjpRGBOv/EZ0armPtDQcu/cXl+6PM8roDe5olk8Rg+d2fiPHox4ko66TQXsQ+oGX7jpJwvz/5gWXzG0ORul7511dP/qqkpvExWCwvE4p/zbCbl2Q5+p2IGkzM9ORAVKujb9cFnRxyPcI0VwM1TaboqSWzv7F9XN3BNelFo8jXFaHXr+Z1M3kv1Opf0UaARW2NVWNwf56TB0tq5eHW/Eo3YssFJvksTOII7JOdJwsbO3QH46yDd/aeMKAzcUV2QpkFtySTQgiBEtt+GZYXrzElKr9JIOJjtn068dB7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8607.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39850400004)(396003)(376002)(346002)(136003)(366004)(451199021)(316002)(6486002)(41300700001)(83380400001)(86362001)(2616005)(6506007)(26005)(1076003)(186003)(2906002)(6512007)(38100700002)(8676002)(36756003)(5660300002)(8936002)(66556008)(66476007)(66946007)(478600001)(6666004)(4326008)(6916009); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m6pGlYvyBbF5xmvYApkFRWj/XEXRmY31QIokUtJ8A7YlQWyai8PvlCvtPjPW?= =?us-ascii?Q?Vrw6o+Ma2srLxozef/P5kkr1vTqf0VwRjP/dx+7Xu68mpZwRR0J2teMXTsLP?= =?us-ascii?Q?7co6hcSEpYP+hm7qi2FttHnNiWYwaYZvePVKLit2iR0sJ03LwZ6NxlxF+2zp?= =?us-ascii?Q?kcJPuS71mBuQj3DjF7kwpnsjiVnx8B+DKGdjWyadsZ51e85g8ObpSPgnUXLB?= =?us-ascii?Q?llCddaDfmgXGynI5wr6l4xuAJ/dlobBiGn+6hFyJRm72oUFbOkfomsmWVJXi?= =?us-ascii?Q?5mAjBzwF+VFLulo2vX+YaCgwSeHDOlTao13HhV/RcefdgtohwTdWqU9Ly9Ul?= =?us-ascii?Q?MiBWhMxcYn2kk+NlzKXBCGfJ7yNrOr+WkkfsHYi6xvdvbMdGqC4Qe4QaZtdU?= =?us-ascii?Q?U0ssgDasl34nts80U25Wy8Ke21CEFwnc8/XTxXsqTkYlf4FHS9LdcH4nBU71?= =?us-ascii?Q?xP94SNv62ajMPzSF+uRhn/loYTbsdtDYW2aVaATwR+nwcuYpyacx80tWjNLp?= =?us-ascii?Q?5U9VLD+bUXN2Lh5+F2oJ/a512mhxlddJYcGb/ppEMj1n1L3MvbUPeQOcOzdz?= =?us-ascii?Q?S9/3AVgoZtGPf3FnLtqQQ+YwK5GN8ez+q+Mi+fBYKk1kP0j9Rym8ehU1D4v9?= =?us-ascii?Q?0M9uv24hfyEaAgZEVqkNByuZYIaNd5PmZcgTxgxveOWeH37bwg4nX7LfUspf?= =?us-ascii?Q?kjUMC/G7yw5H7jActm+SN2s8EeWXeqo0A1Fk1J/V76QL8+4CnWsxHhwqXHx1?= =?us-ascii?Q?mEaGF7Bzr3qA2Cy5CcFquCSgde+3c89Q1Tt1bqmMrDnXjh6KKGmWP5oZrETi?= =?us-ascii?Q?YAOnz+H2EGXOrvZJ0GCGK8rzTvtrzfagTOvJBrX5x9As8dt+HxNlssmTzKQL?= =?us-ascii?Q?tA3rvQGVGlyyKDeEmbzpUtaD6mhctkXniTBEZnKNYcaKrjRZqudPgf8FdJ2L?= =?us-ascii?Q?ya8FJNPYJ3tT0nyFSofDqNYlcV7x+vBf6CWPdeAU3App6p/KcDvHfVt3fnIV?= =?us-ascii?Q?XlqQKPWE6Y5ej5xbj3DuvRGZ0931C9dw1V0484+5vbvm/j9aKMxSwyhLATDE?= =?us-ascii?Q?QFNYJM+KUKamLqfo+WllvOUBS5drtd3MiLAfpp9k9Ev7+Br7N5AHaNE5dgCG?= =?us-ascii?Q?wjZyikpl6bGTMc7bhplnEEEVbbkaC8FsjRaMfH1WkPB1BVUisbMkCRtvhbhd?= =?us-ascii?Q?wz7DK/464z3fOSw5ddcK4FpuSavHpUBHsMGY03HQ0nKKAffmAnNvZ1baZ+/q?= =?us-ascii?Q?t6O6iWdiRkNo6tj5UnjWF2vC2l42bLoPqCNelba/AEXpwdH0Xh4GSDD/oEMz?= =?us-ascii?Q?g/GUforWvBmZcgxdf/9MW5HG0cbj6oH8JKnwoTDwkBqZDa/Vj6OCSIRuG3BR?= =?us-ascii?Q?KOZeyCFk9UJ7BpZQ6s5wnrTFXokDGsnFPCqYOvgDggSXN5MB5dBon2VbCdLB?= =?us-ascii?Q?wlpwwUd6m1bst+kg4BoNo/duaZgFTFFw2V+a4ShVNz+Sc/jbP6ScXm9BwkTi?= =?us-ascii?Q?LReH2E9nQUrquPD2Vd44W9IlkbSQbuVGKaUFSaAb1xldmgG/FjQSTgxabQO8?= =?us-ascii?Q?C4p7ow+MBETQ3xn/l+k=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 520a3460-271b-4608-a220-08db6a81f384 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8607.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2023 13:44:17.2655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cViB1mn7SLUN45nsfr28MPF2aW23F44VjuWSGV6mbTuZ7ULMChPXzn1615cuKFJB X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8986 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, Lin Ma Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: suse.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1686491077022100001 Content-Type: text/plain; charset="utf-8" From: Lin Ma Signed-off-by: Lin Ma --- src/qemu/qemu_command.c | 20 +++++++++++++++++--- tests/qemuxml2argvdata/kvm-features.args | 2 +- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b82ec4508c..cd9b77497e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7066,9 +7066,23 @@ qemuBuildAccelCommandLine(virCommand *cmd, * not that either kvm or tcg can be specified by libvirt * so do not worry about the conflict of specifying both * */ - if (def->features[VIR_DOMAIN_FEATURE_KVM] =3D=3D VIR_TRISTATE_SWIT= CH_ON && - def->kvm_features->features[VIR_DOMAIN_KVM_DIRTY_RING] =3D=3D = VIR_TRISTATE_SWITCH_ON) { - virBufferAsprintf(&buf, ",dirty-ring-size=3D%d", def->kvm_feat= ures->dirty_ring_size); + if (def->features[VIR_DOMAIN_FEATURE_KVM] =3D=3D VIR_TRISTATE_SWIT= CH_ON) { + if (def->kvm_features->features[VIR_DOMAIN_KVM_DIRTY_RING] =3D= =3D + VIR_TRISTATE_SWITCH_ON) { + virBufferAsprintf(&buf, ",dirty-ring-size=3D%d", + def->kvm_features->dirty_ring_size); + } + + if (def->kvm_features->features[VIR_DOMAIN_KVM_NOTIFY_VMEXIT] = =3D=3D + VIR_TRISTATE_SWITCH_ON) { + virBufferAsprintf(&buf, ",notify-vmexit=3D%s", + def->kvm_features->notify_vmexit.mode); + if (def->kvm_features->notify_vmexit.notify_window && + STRNEQ(def->kvm_features->notify_vmexit.mode, "disable= ")) { + virBufferAsprintf(&buf, ",notify-window=3D%u", + def->kvm_features->notify_vmexit.not= ify_window); + } + } } break; =20 diff --git a/tests/qemuxml2argvdata/kvm-features.args b/tests/qemuxml2argvd= ata/kvm-features.args index 985d406ad7..51d5a6aae2 100644 --- a/tests/qemuxml2argvdata/kvm-features.args +++ b/tests/qemuxml2argvdata/kvm-features.args @@ -11,7 +11,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -S \ -object secret,id=3DmasterKey0,format=3Draw,file=3D/var/lib/libvirt/qemu/d= omain--1-QEMUGuest1/master-key.aes \ -machine pc,usb=3Doff,dump-guest-core=3Doff \ --accel kvm,dirty-ring-size=3D4096 \ +-accel kvm,dirty-ring-size=3D4096,notify-vmexit=3Drun,notify-window=3D1638= 4 \ -cpu host,kvm=3Doff,kvm-hint-dedicated=3Don,kvm-poll-control=3Don \ -m 214 \ -overcommit mem-lock=3Doff \ --=20 2.40.1