From nobody Thu Dec 18 22:23:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1684742884; cv=none; d=zohomail.com; s=zohoarc; b=Y1s/OjEblqdQ9IdB81R2nUU5FNfX16fLF7obJJP6Cs3wcjrpNMML3inPP4e9VsZr6/ezsjzCDxdYMS6+xqsEUjTvQfsPSFpGYjyNkIZFv3zrx5zrw8rlfbZAQTUFTerNKshBCphIRA9kbf2R6M0u9gEBjxmZy9/V4QkyiAQZjgg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684742884; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hgzA2axwnnapV04/84KLDU9EfLip9OsPhTU1cT9iJ14=; b=EI+ZoXK/KT9al++9PRrVAPDfJKamH8jlTVhLcDnj8t8IgQd9g1/hvMQEzcKpkJnhu9hrLpVV4IGQWx1jsfNZnkKgH+k1MJ7dWn5AvlFD92yOcauWG0hFqsENRyZ/22leYhUlIhQsXhtq3JZWkca4cLOxZ4AwN/tQu/oeWwhZb78= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1684742884038150.28046949215684; Mon, 22 May 2023 01:08:04 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-tVrpA9otMsGaDBQijCnh8A-1; Mon, 22 May 2023 04:07:56 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 79821800B35; Mon, 22 May 2023 08:07:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 609842166B26; Mon, 22 May 2023 08:07:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 34ADD1946595; Mon, 22 May 2023 08:07:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A565D194658C for ; Mon, 22 May 2023 08:07:51 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 987842029F71; Mon, 22 May 2023 08:07:51 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D78F42029F6E; Mon, 22 May 2023 08:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684742883; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=hgzA2axwnnapV04/84KLDU9EfLip9OsPhTU1cT9iJ14=; b=NroumMIpKnkVnrsVAHavRxwiI8iaBjWM4ypnbXRZ9M9KWpqD2uE0KMLGvRVyWAtS60TWat K5fAnxw8/bMRHaouLeLZVeEa5mYp7u+aj9tWlxqbPDiX20MLNqzYwqkvhj46I38tznyxQ3 LSxUkZc+PLkMM1SI0knLiS9GdM3iHdc= X-MC-Unique: tVrpA9otMsGaDBQijCnh8A-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 4/4] Revert "conf: Introduce MTE domain feature" Date: Mon, 22 May 2023 10:07:44 +0200 Message-Id: <20230522080744.38527-5-abologna@redhat.com> In-Reply-To: <20230522080744.38527-1-abologna@redhat.com> References: <20230522080744.38527-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, cohuck@redhat.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1684742884762100005 Content-Type: text/plain; charset="utf-8"; x-default="true" The QEMU interface is still in a state of flux, and KVM support has been pulled shortly after having been merged. Let's not commit to a stable interface in libvirt just yet. Reverts: 720e8f13ff71377580cd37b118cee8a1f982d1d8 Signed-off-by: Andrea Bolognani --- docs/formatdomain.rst | 7 ------- src/conf/domain_conf.c | 6 +----- src/conf/domain_conf.h | 1 - src/conf/schemas/domaincommon.rng | 5 ----- src/qemu/qemu_validate.c | 1 - tests/qemuxml2argvdata/aarch64-gic-v3.xml | 1 - tests/qemuxml2xmloutdata/aarch64-gic-v3.aarch64-latest.xml | 1 - 7 files changed, 1 insertion(+), 21 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index b46eefb0f6..dd28a565e1 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -2000,7 +2000,6 @@ Hypervisors may allow certain CPU / machine features = to be toggled on/off. 128 - ... =20 @@ -2231,12 +2230,6 @@ are: tb-cache The size of translation block cache size an integer (= a multiple of MiB) :since:`8.0.0` =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D =20 -``mte`` - Configure Memory Tagging Extensions for ARM guests. Possible values for= the - ``state`` attribute are ``on`` and ``off``. If the attribute is not - defined, the hypervisor default will be used. :since:`Since 9.4.0` (QEM= U/KVM - only) - Time keeping ------------ =20 diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 047a4c97bf..6a864a8db9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -181,7 +181,6 @@ VIR_ENUM_IMPL(virDomainFeature, "sbbc", "ibs", "tcg", - "mte", ); =20 VIR_ENUM_IMPL(virDomainCapabilitiesPolicy, @@ -16646,8 +16645,7 @@ virDomainFeaturesDefParse(virDomainDef *def, =20 case VIR_DOMAIN_FEATURE_HTM: case VIR_DOMAIN_FEATURE_NESTED_HV: - case VIR_DOMAIN_FEATURE_CCF_ASSIST: - case VIR_DOMAIN_FEATURE_MTE: { + case VIR_DOMAIN_FEATURE_CCF_ASSIST: { virTristateSwitch state; =20 if (virXMLPropTristateSwitch(nodes[i], "state", @@ -20488,7 +20486,6 @@ virDomainDefFeaturesCheckABIStability(virDomainDef = *src, case VIR_DOMAIN_FEATURE_HTM: case VIR_DOMAIN_FEATURE_NESTED_HV: case VIR_DOMAIN_FEATURE_CCF_ASSIST: - case VIR_DOMAIN_FEATURE_MTE: if (src->features[i] !=3D dst->features[i]) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("State of feature '%1$s' differs: source:= '%2$s', destination: '%3$s'"), @@ -27008,7 +27005,6 @@ virDomainDefFormatFeatures(virBuffer *buf, case VIR_DOMAIN_FEATURE_HTM: case VIR_DOMAIN_FEATURE_NESTED_HV: case VIR_DOMAIN_FEATURE_CCF_ASSIST: - case VIR_DOMAIN_FEATURE_MTE: switch ((virTristateSwitch) def->features[i]) { case VIR_TRISTATE_SWITCH_LAST: case VIR_TRISTATE_SWITCH_ABSENT: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 3f8d6e81c0..c1cb2ed69d 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2169,7 +2169,6 @@ typedef enum { VIR_DOMAIN_FEATURE_SBBC, VIR_DOMAIN_FEATURE_IBS, VIR_DOMAIN_FEATURE_TCG, - VIR_DOMAIN_FEATURE_MTE, =20 VIR_DOMAIN_FEATURE_LAST } virDomainFeature; diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 37e350ac2c..f8c7b6a648 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -6653,11 +6653,6 @@ - - - - - diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 99c7775e9b..da4b9a3b35 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -123,7 +123,6 @@ qemuValidateDomainDefFeatures(const virDomainDef *def, break; =20 case VIR_DOMAIN_FEATURE_GIC: - case VIR_DOMAIN_FEATURE_MTE: if (def->features[i] =3D=3D VIR_TRISTATE_SWITCH_ON && !qemuDomainIsARMVirt(def)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/tests/qemuxml2argvdata/aarch64-gic-v3.xml b/tests/qemuxml2argv= data/aarch64-gic-v3.xml index b9317284b0..247d6025f7 100644 --- a/tests/qemuxml2argvdata/aarch64-gic-v3.xml +++ b/tests/qemuxml2argvdata/aarch64-gic-v3.xml @@ -10,7 +10,6 @@ - diff --git a/tests/qemuxml2xmloutdata/aarch64-gic-v3.aarch64-latest.xml b/t= ests/qemuxml2xmloutdata/aarch64-gic-v3.aarch64-latest.xml index 1a74903aaa..5b2fb7df75 100644 --- a/tests/qemuxml2xmloutdata/aarch64-gic-v3.aarch64-latest.xml +++ b/tests/qemuxml2xmloutdata/aarch64-gic-v3.aarch64-latest.xml @@ -10,7 +10,6 @@ - --=20 2.40.1