From nobody Wed Jan 15 17:41:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1684742878; cv=none; d=zohomail.com; s=zohoarc; b=hZZSGkq5XUfo8+geg0FKSIC3ZtD+9DQnRVKxTPzEJGroz5femsYnW2SupkO5IOfrdg025GCLgGkfol8Wk2IiQqWL2flUJ/dyzxSMLaZ2q+Q0TAS6lbLtyEBNz/865RWkwvmDxbhCMIHWOAkDH2BlrNGCbPSnFGRzXGh/G9p7VKU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684742878; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tce/NtnRoFYFrhjAAaBRrtqQxXj3tXLXtf82E4mRiyY=; b=Q+idQgCAju3Cdvdjkwo/+tr/bxGAcmQWFq3wpqXvKuDEzqmCm1Lc7JzHT3LcTr+bJNiuEXt8Auk+vrINfaTuY+ihjh3EyDYLTBvVMoj2sXHr6LFNhStEm4fKjRSXBqVm2uctZWH9TVsyzUJN00bza9TmgvgMnuSb8YeVq2ub5nA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 168474287891691.30180130101314; Mon, 22 May 2023 01:07:58 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-32-KK_Dl_McNtuzXFSNu9OgOA-1; Mon, 22 May 2023 04:07:54 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F09F7185A7AB; Mon, 22 May 2023 08:07:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC6BCC54186; Mon, 22 May 2023 08:07:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9454E19465A8; Mon, 22 May 2023 08:07:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9CD39194658C for ; Mon, 22 May 2023 08:07:49 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8BA4E20296C8; Mon, 22 May 2023 08:07:49 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA0FA200C0EE; Mon, 22 May 2023 08:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684742878; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tce/NtnRoFYFrhjAAaBRrtqQxXj3tXLXtf82E4mRiyY=; b=NFWo0iNvzzLQtEQgibo5DAtR3feFkUgUuN85BsSEBnamSULA9zFA+iaDajI5sKZDCDJRkQ 8lZnf7HkE7MOY2ZU5yxv4VZ5vRftrDw0JHWGxtsgA3tQ1ugPldpi0kK/jPJiIB8FsMJk2E RgsMO0tKV0wHV2amG7UWSpKSUUNwg4k= X-MC-Unique: KK_Dl_McNtuzXFSNu9OgOA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 2/4] Revert "qemu: Validate MTE feature" Date: Mon, 22 May 2023 10:07:42 +0200 Message-Id: <20230522080744.38527-3-abologna@redhat.com> In-Reply-To: <20230522080744.38527-1-abologna@redhat.com> References: <20230522080744.38527-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, cohuck@redhat.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1684742880333100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The QEMU interface is still in a state of flux, and KVM support has been pulled shortly after having been merged. Let's not commit to a stable interface in libvirt just yet. Reverts: c6c9b5d251de215ed378aa0bc31daa2e1170409e Signed-off-by: Andrea Bolognani --- src/qemu/qemu_validate.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index da76556854..99c7775e9b 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -124,23 +124,14 @@ qemuValidateDomainDefFeatures(const virDomainDef *def, =20 case VIR_DOMAIN_FEATURE_GIC: case VIR_DOMAIN_FEATURE_MTE: - if (def->features[i] !=3D VIR_TRISTATE_SWITCH_ABSENT) { - if (!qemuDomainIsARMVirt(def)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("The '%1$s' feature is not supported = for architecture '%2$s' or machine type '%3$s'"), - featureName, - virArchToString(def->os.arch), - def->os.machine); - return -1; - } - - if (i =3D=3D VIR_DOMAIN_FEATURE_MTE && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_VIRT_MTE))= { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("The '%1$s' feature is not supported = with this QEMU binary"), - featureName); - return -1; - } + if (def->features[i] =3D=3D VIR_TRISTATE_SWITCH_ON && + !qemuDomainIsARMVirt(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("The '%1$s' feature is not supported for = architecture '%2$s' or machine type '%3$s'"), + featureName, + virArchToString(def->os.arch), + def->os.machine); + return -1; } break; =20 --=20 2.40.1