From nobody Wed Jan 15 18:04:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1684742890; cv=none; d=zohomail.com; s=zohoarc; b=CfmtWBYU3lKq/YMPOGZglOP15odOmoKYLaURyH+V8ACH0lhsv2CcfZhJDpTWWgpejdgjNJW78XLus/xHKkGE5wnyydYyT3xUeUjPNty9O87ShL8WY11aMizalIIJhB3c1kumLvKhmhVAGZf+3n3WCf0MGg68cyR8nIPE9ZQ9OwQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684742890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ksLbFtgV89u/0Gxttqswa6NlUYtir/4Z70e94J6nqLg=; b=V9G3Ir1/+D8HJ048P/EMyarkfbUKCEL9cGl31bUwkYvNoKwO9Wz9aqX6uyglN5kY1jIVW/s9GVk6tZiEtzfprCFE8lpjNbDSvNu5BoAfFUu2gPGBxMyWDA4gOnMVwYMfg/WEokxcvZvKKEysT0lu7Wt6xmNWyy0wboG9WmiRkmE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1684742890850940.671967776632; Mon, 22 May 2023 01:08:10 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-74-0T7800o2MjGe2ReMBtW56g-1; Mon, 22 May 2023 04:07:53 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F076C101B042; Mon, 22 May 2023 08:07:50 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAD22C54189; Mon, 22 May 2023 08:07:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BC6B319465A0; Mon, 22 May 2023 08:07:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B021419466DF for ; Mon, 22 May 2023 08:07:48 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 84D42200AE6F; Mon, 22 May 2023 08:07:48 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4307200C0EE; Mon, 22 May 2023 08:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684742882; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ksLbFtgV89u/0Gxttqswa6NlUYtir/4Z70e94J6nqLg=; b=YsgiON8Gl7XvX6OG0T/Zjzuvr6xt7u5S7QvYhEKLzJe6gSn2z31Dr7rHJWJ6x+jJcOUlAn mAm1pdhluNXTuppdvGPJmfLjBHRja0B6+gfgA3uAKTlYmw3ddW+1K9d9RI91+IADB+itQa 2C9YSe601GRBEnnl6cR+NEI5a5XCuoA= X-MC-Unique: 0T7800o2MjGe2ReMBtW56g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 1/4] Revert "qemu: Generate command line for MTE feature" Date: Mon, 22 May 2023 10:07:41 +0200 Message-Id: <20230522080744.38527-2-abologna@redhat.com> In-Reply-To: <20230522080744.38527-1-abologna@redhat.com> References: <20230522080744.38527-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, cohuck@redhat.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1684742892611100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The QEMU interface is still in a state of flux, and KVM support has been pulled shortly after having been merged. Let's not commit to a stable interface in libvirt just yet. Reverts: b10bc8f7ab6f9986ccc54ba04fc5b3bad7576be6 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 6 ------ tests/qemuxml2argvdata/aarch64-gic-v3.args | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9b993c3aad..2a6d9408f6 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6797,12 +6797,6 @@ qemuAppendDomainFeaturesMachineParam(virBuffer *buf, virBufferAsprintf(buf, ",cap-ibs=3D%s", str); } =20 - if (def->features[VIR_DOMAIN_FEATURE_MTE] !=3D VIR_TRISTATE_SWITCH_ABS= ENT) { - const char *str; - str =3D virTristateSwitchTypeToString(def->features[VIR_DOMAIN_FEA= TURE_MTE]); - virBufferAsprintf(buf, ",mte=3D%s", str); - } - return 0; } =20 diff --git a/tests/qemuxml2argvdata/aarch64-gic-v3.args b/tests/qemuxml2arg= vdata/aarch64-gic-v3.args index 0244951d87..0d7a1c259a 100644 --- a/tests/qemuxml2argvdata/aarch64-gic-v3.args +++ b/tests/qemuxml2argvdata/aarch64-gic-v3.args @@ -10,7 +10,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-aarch64= test/.config \ -name guest=3Daarch64test,debug-threads=3Don \ -S \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-aarch64test/master-key.aes"}' \ --machine virt,usb=3Doff,gic-version=3D3,mte=3Don,dump-guest-core=3Doff,mem= ory-backend=3Dmach-virt.ram \ +-machine virt,usb=3Doff,gic-version=3D3,dump-guest-core=3Doff,memory-backe= nd=3Dmach-virt.ram \ -accel kvm \ -cpu host \ -m 1024 \ --=20 2.40.1