From nobody Tue Apr 23 16:17:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683724167; cv=none; d=zohomail.com; s=zohoarc; b=EVdwux1IjzLoAAevasIrjn6LhKx8pnJ5QA8XM77krhf+QjDP5BcGkJeLVzY0dsafs6YZhpK7ybgLthoTZ2RILzhji+sOSOcs/vLCNWM3wwfkuImiv4QNaAh/7PjYay2r+VUx1MOdtuCYXHG5Its46IJxzBDNF1PHc1nQm4lBGQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683724167; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=bjUqwCt9Syrxt5EMrbiI2D5yAyfS1c8QFKvvd4px3UQ=; b=PlTfWRVqbInscpC+hb6fm7jylysVnPjnXqyc35XTJQ7ITAkOUafPCD8tU34yNTqfIw7+DnvZe97FDvLTiqAIPXf+9dzKdWx8FUOx9Z7wJLwdsldZvSaUGK13ihj6ILXZ6+hrCTj8abrxeB+B33C7H9iAc+Pqi60J7Gd5uzS19yo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1683724167688979.9905339736656; Wed, 10 May 2023 06:09:27 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-hQkdGsWZO_OWMfGVBtP6Sg-1; Wed, 10 May 2023 09:09:24 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 259E41C05EC6; Wed, 10 May 2023 13:09:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B8F71410F23; Wed, 10 May 2023 13:09:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0D4D919452C6; Wed, 10 May 2023 13:09:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3364C1946A45 for ; Wed, 10 May 2023 13:08:40 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 03FD663F86; Wed, 10 May 2023 13:08:40 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.225.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B08847CD0 for ; Wed, 10 May 2023 13:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683724166; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=bjUqwCt9Syrxt5EMrbiI2D5yAyfS1c8QFKvvd4px3UQ=; b=P3MT+DK6P3fMiLb7Suso9VLbH0bEMAPeigPzquPuITeZgaUG9oT42gO6ZIlNQlX1clEAy1 C+s2Xv07ZBR57sxSL1C4jM0kBbc4qXz7DVK3u1vdQ6kSrsWmOqzX8nyMmNPwh5fHVSShjt RxWB8bV5YhIUtqlTRn30Zy/M4WLe8hs= X-MC-Unique: hQkdGsWZO_OWMfGVBtP6Sg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH v2] rpm: Explain BuildRequires on qemu-img Date: Wed, 10 May 2023 15:08:37 +0200 Message-Id: <20230510130837.30588-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683724168398100001 Content-Type: text/plain; charset="utf-8"; x-default="true" It's not used as part of the build process or searched for at build time, and the QEMU driver detects its path at runtime, so one could think that the BuildRequires is unnecessary. But we actually need it to be present at build time in order to run the full test suite. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index c542ec3b2b..1f77cd90b7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -310,7 +310,7 @@ BuildRequires: util-linux %if %{with_qemu} # For managing ACLs BuildRequires: libacl-devel -# From QEMU RPMs +# From QEMU RPMs, used by virstoragetest BuildRequires: /usr/bin/qemu-img %endif # For LVM drivers --=20 2.40.1