From nobody Wed Oct 30 22:17:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683309727; cv=none; d=zohomail.com; s=zohoarc; b=KtAszxKPdZO3JMX97fgfuYsVl9leUmLmqPVJne/ThS4pvGXskHZ6wfIi31TcGLCWNAq4qvh1VqbnDQHAGaTTLe4sR1Mv2YvEOo1WybtiwSQ59x2geGyAbZ8xpnaPysipSMbD794Pbq8/Fz+g7IhJ7JP3uOyV2+V1tN7wZ+NLa4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683309727; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mSYCHN6oKlcz7SOmizlu37BVNl1/DVZYg8Jt7Za5e9s=; b=B9yjtmnRIDNXcAd+Z/OCeAtwmWItOg20t0kCmG513dBNAxzHDKdkUX3LZyqOSXWgruvjbRaYfaqDHxRu/qHvNMzSH2rfubj7gm3gtX6nQB/3sMhjEdqJt2gX9wQwiuZ6UIVRAIr2QWapLhLu5K5oVOP/IVx4lOCTvktKBqNX0Ow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1683309727569985.8673382032881; Fri, 5 May 2023 11:02:07 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-204-LOilKDIpOUWVZZwP8V5jtg-1; Fri, 05 May 2023 14:01:59 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B43587DC1C; Fri, 5 May 2023 18:01:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D10D40F177; Fri, 5 May 2023 18:01:53 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 090AA1946A62; Fri, 5 May 2023 18:01:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 549881946A43 for ; Fri, 5 May 2023 18:01:52 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 4617E2026D25; Fri, 5 May 2023 18:01:52 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.224.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C91482026D16 for ; Fri, 5 May 2023 18:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683309726; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mSYCHN6oKlcz7SOmizlu37BVNl1/DVZYg8Jt7Za5e9s=; b=Q3EsI8muyKitd6vXRBd10ZEbnLtVJN3n4f9QCTjfa3XsHWq5aYanhPz1IyKZJCGuI0GvUh SiG8zOp3s4S7SJ/sYMBdygKV5HHdy9kU58MtZZoyfKbbEkEgfRTp5v4tRYiUF+Wyta7g+i +6oma6M0Ag+SgUBzLsS0d4dVhFwbUJA= X-MC-Unique: LOilKDIpOUWVZZwP8V5jtg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 5/5] qemu: Update documentation for qemu.conf keys Date: Fri, 5 May 2023 20:01:46 +0200 Message-Id: <20230505180146.551086-6-abologna@redhat.com> In-Reply-To: <20230505180146.551086-1-abologna@redhat.com> References: <20230505180146.551086-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683309731683100002 Content-Type: text/plain; charset="utf-8"; x-default="true" Reflect the new default value, and explain that a runtime lookup will be performed if the value is not an absolute path. Signed-off-by: Andrea Bolognani --- src/qemu/qemu.conf.in | 8 ++++++-- src/qemu/test_libvirtd_qemu.aug.in | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 3895d42514..e1a9a5e56d 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -650,7 +650,9 @@ # is used to create interfaces when libvirtd is # running unprivileged. libvirt invokes the helper directly, instead # of using "-netdev bridge", for security reasons. -#bridge_helper =3D "/usr/libexec/qemu-bridge-helper" +# If this is not an absolute path, the program will be searched for +# in $PATH as well as a few additional directories. +#bridge_helper =3D "qemu-bridge-helper" =20 =20 # If enabled, libvirt will have QEMU set its process name to @@ -899,7 +901,9 @@ =20 # Path to the SCSI persistent reservations helper. This helper is # used whenever are enabled for SCSI LUN devices. -#pr_helper =3D "/usr/bin/qemu-pr-helper" +# If this is not an absolute path, the program will be searched for +# in $PATH as well as a few additional directories. +#pr_helper =3D "qemu-pr-helper" =20 # Path to the SLIRP networking helper. #slirp_helper =3D "/usr/bin/slirp-helper" diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qe= mu.aug.in index 1dbd692921..af99331886 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -75,7 +75,7 @@ module Test_libvirtd_qemu =3D { "auto_dump_bypass_cache" =3D "0" } { "auto_start_bypass_cache" =3D "0" } { "hugetlbfs_mount" =3D "/dev/hugepages" } -{ "bridge_helper" =3D "/usr/libexec/qemu-bridge-helper" } +{ "bridge_helper" =3D "qemu-bridge-helper" } { "set_process_name" =3D "1" } { "max_processes" =3D "0" } { "max_files" =3D "0" } @@ -107,7 +107,7 @@ module Test_libvirtd_qemu =3D { "1" =3D "mount" } } { "memory_backing_dir" =3D "/var/lib/libvirt/qemu/ram" } -{ "pr_helper" =3D "/usr/bin/qemu-pr-helper" } +{ "pr_helper" =3D "qemu-pr-helper" } { "slirp_helper" =3D "/usr/bin/slirp-helper" } { "dbus_daemon" =3D "/usr/bin/dbus-daemon" } { "swtpm_user" =3D "tss" } --=20 2.40.1