From nobody Tue Dec 31 04:33:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683044350; cv=none; d=zohomail.com; s=zohoarc; b=Ee2o8IMXuXsKxsbTl8SMUIPslagOwa7l1uXZoh25aArjlvb9ldzahQUmAMn1JSLEKEMMfqhN8h/W6QehDoj2WXySYwGIWNxadwP/8gIdpRMe8LqQ4cBOdj8+6Nd1/C+chX+UykxcUM9jd4/P6gUknKbvw0Xp+LAE0lhgWS3h0NE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683044350; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=TtUxkhnpk0nRX1trOEo4ORe2udeU5vwDVNmP4GzlIvc=; b=m8GwCkEEO+ADm/IhwJ95iZF80tXUSDw0Dg3vsNpGK+NiC552tpV+m7YN3IPc8UEKRChyDMBF3WdsA4LRLtbvhVnyc9UG5qi1ju02PQ4mFfQCOQQGMeDjFsaGDkyNos3V88v59yiUD16DrFV5bcYHzcWh4tlzYpElwBIrJ4w02rQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1683044350912648.2068393715438; Tue, 2 May 2023 09:19:10 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-554-hHICagg4ORGoJLExgxtr_Q-1; Tue, 02 May 2023 12:18:16 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9DF60100B369; Tue, 2 May 2023 16:14:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC41E40C2009; Tue, 2 May 2023 16:14:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BE7ED1946595; Tue, 2 May 2023 16:14:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D9003194658C for ; Tue, 2 May 2023 16:14:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id AAB751121331; Tue, 2 May 2023 16:14:05 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.225.242]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C7381121339 for ; Tue, 2 May 2023 16:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683044348; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TtUxkhnpk0nRX1trOEo4ORe2udeU5vwDVNmP4GzlIvc=; b=cxf06G5fyGxWA521bFtZZ9KTnqdFitU5mk8BNaQXYj72srkotp1PL7p2QD3G+jDEoFJnHn j/Q8w67uZ8o2LcEZFP5t/ghzVZzY92GDVq1fCNgBDPHDH5dzjzWBtgvjxcI0vo7ykKBodl fVyYT3gd3Sv8rO2NlMkuveqKf91OG3U= X-MC-Unique: hHICagg4ORGoJLExgxtr_Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] meson: Fix qemu_{user,group} defaults for Arch Date: Tue, 2 May 2023 18:14:03 +0200 Message-Id: <20230502161403.19153-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683044352728100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The current values might have been accurate at the time when the logic was introduced, but these days Arch is using the same ones as Debian. Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- Proof that I'm not making this up: https://github.com/archlinux/svntogit-community/blob/83e66277ba6e08968496c8= 258a14d6109ec6dc82/trunk/PKGBUILD#L110-L111 meson.build | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index bad13c0c9d..09c3ab00f4 100644 --- a/meson.build +++ b/meson.build @@ -1614,20 +1614,18 @@ if not get_option('driver_qemu').disabled() qemu_group =3D 'wheel' else os_release =3D run_command('grep', '-E', '^ID(_LIKE)*=3D', '/etc/o= s-release', check: false).stdout() - if os_release.contains('arch') - qemu_user =3D 'nobody' - qemu_group =3D 'nobody' # RHEL and CentOS both have ID_LIKE=3Dfedora, SLES has ID_LIKE=3Ds= use - elif (os_release.contains('fedora') or - os_release.contains('gentoo') or - os_release.contains('suse')) + if (os_release.contains('fedora') or + os_release.contains('gentoo') or + os_release.contains('suse')) qemu_user =3D 'qemu' qemu_group =3D 'qemu' # Ubuntu has ID_LIKE=3Ddebian so we need to handle it first elif os_release.contains('ubuntu') qemu_user =3D 'libvirt-qemu' qemu_group =3D 'kvm' - elif os_release.contains('debian') + elif (os_release.contains('arch') or + os_release.contains('debian')) qemu_user =3D 'libvirt-qemu' qemu_group =3D 'libvirt-qemu' else --=20 2.40.1