From nobody Sun Feb 8 13:39:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1682508737; cv=none; d=zohomail.com; s=zohoarc; b=W6c9Jcu+9vuXZzEP3gcmn53BEUXVdXA+1G6UjCc4Q1xNoz9/cyStpTZSDLLbVD1cIjrNLx0vNC8//9+Ew2twftCudc88aTmKXOusC0EGMvD0gNman3Dzodv4365BFqcDvy6n3TbKdqTlRylFuULYkMtthtSc3noNLH5uCbRT9+s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682508737; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zvdhcjHvYJSo7H9KEp4tbtRQCb3phlCXXsV2Z88n2Oc=; b=Co7Jl/XMsEnojd6x9xuhJtybRPc6KnbNt93EZJd6Zoj2zM8w5Q2bP+OYX/0bUwaEmImXPbWSOkfPcoOj2xBqgnwzDAIP8ErHYn8dPLjm4kY+xORiYVF2La3ShF4r2vJisqINqF9ISszAJZos1wDPbVEaJDnJ8eJEHIuulZG5MWs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1682508737139842.4493213476054; Wed, 26 Apr 2023 04:32:17 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-343-gAmyxbqVMWO9natT0IakpQ-1; Wed, 26 Apr 2023 07:32:04 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD170185A78F; Wed, 26 Apr 2023 11:32:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE6D51121314; Wed, 26 Apr 2023 11:32:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 85E9D19466DF; Wed, 26 Apr 2023 11:32:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2B06119465BD for ; Wed, 26 Apr 2023 11:31:14 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 1DCCC40C201F; Wed, 26 Apr 2023 11:31:14 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14B0840C2064 for ; Wed, 26 Apr 2023 11:31:14 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE3A02A59549 for ; Wed, 26 Apr 2023 11:31:13 +0000 (UTC) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-275-M8_c-zVcOZq1nhWVffntUQ-1; Wed, 26 Apr 2023 07:31:11 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33QASmsl027996 for ; Wed, 26 Apr 2023 11:31:11 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3q460d948a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 26 Apr 2023 11:31:10 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33QBDYHw008798 for ; Wed, 26 Apr 2023 11:31:09 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2108.outbound.protection.outlook.com [104.47.55.108]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3q461814en-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 26 Apr 2023 11:31:09 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:3ed::10) by DS0PR10MB7270.namprd10.prod.outlook.com (2603:10b6:8:f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 11:31:07 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::f6d:eee7:6b56:1011]) by SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::f6d:eee7:6b56:1011%2]) with mapi id 15.20.6319.022; Wed, 26 Apr 2023 11:31:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682508736; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zvdhcjHvYJSo7H9KEp4tbtRQCb3phlCXXsV2Z88n2Oc=; b=Z7rzltCO1hNacAjqE3pwOzszgFNBN8V0uzgshnKmUhxvSJOK0/qgayuwkTghtFDJpAQfSM ZaY2MAqeVlOxND5IBI3jhUX44hu1JompgN/bGAnTWZIxcCddTEw6uDbCUSF6WQeTTGucCI +y1wgSJdcKVwI8Tt91Xf2QaN58P+q0c= X-MC-Unique: gAmyxbqVMWO9natT0IakpQ-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: M8_c-zVcOZq1nhWVffntUQ-1 From: Shaleen Bathla To: libvir-list@redhat.com Subject: [PATCH 1/2] tools: virsh-domain: refactor variable initialization Date: Wed, 26 Apr 2023 16:58:32 +0530 Message-Id: <20230426112833.2634058-2-shaleen.bathla@oracle.com> In-Reply-To: <20230426112833.2634058-1-shaleen.bathla@oracle.com> References: <20230426112833.2634058-1-shaleen.bathla@oracle.com> X-ClientProxiedBy: SA1P222CA0098.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:35e::8) To SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:3ed::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5768:EE_|DS0PR10MB7270:EE_ X-MS-Office365-Filtering-Correlation-Id: 71630e10-038b-48d5-7cab-08db4649ba20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: sOS1QTjJ9FV42GCXjSsy2AP9ekFZjNJfM6GLiRw7hjZptE5X4mJebfZ4q6o/4JF6P5vegXL31ntF//5g35weXIzCti8oRyZw3QJd6lbulSe5N/8APnKWCgXJreFTMwoCPPG8Eo6QJr62oAU94R58FgPdPTFloYpVXELO71hFa2pREcvWBnBee6ZGxX2OgSrSJ4kwsI62Qr5YKWy0W/M6gChgxYjTkTolApGRwBUWH1hYdktNi6teRy0ZP9M7ixVQnS68tebI1/I9xoO1j6xCP88N/iWY3xeBSEImITY+B3WCvb4S3uX/ioYnAQTdPh59Bv0D1lT2RitwM+75gMykvJXRJixARqGGr4ZzdkvyVswwdQgEtDcrlztduVXSq5xnLuS6riYWhpv4mA6DkJlibxrc8sxAE+cx3rRSonZpjQQJAdMRAbQGKuFmtS/3l/NhPnrmXdM4OWgIe4NAGkpZGa8MZt3/LmJn23cj6P7PeUnAkU8ZAtXli02y5xX2U3SFe6A8gMp1td2pUCgXNQrBIWcjLwccoZlabTGnXTbIs4hfBanDRBLSdj8c4FRhu8fV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5768.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199021)(38100700002)(26005)(1076003)(6506007)(186003)(6512007)(2616005)(83380400001)(4744005)(44832011)(2906002)(8676002)(5660300002)(8936002)(86362001)(36756003)(478600001)(6486002)(6666004)(66556008)(6916009)(316002)(66476007)(66946007)(41300700001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cbhPEAruz/N7XgenKfQKVw8Xyo8NHPpZr7QcMt8jKEgljubKi3bjACqeH/kq?= =?us-ascii?Q?ikeUGM8mCkkQcbmMafUtf4MwtrHnOmvfb6V6bwMRqwH5COBrZfPGLVEQxsex?= =?us-ascii?Q?Dy3OGZN6pWcwdk5dQaUT7sIsAjhDzaQ/D0avLbprdtzi3CtM3fJgGlLqkeK3?= =?us-ascii?Q?N18gz4R3onuu6SHlU80aCJIkiNX0JqUnngGM+4iNgDIhCNRbC4joV9dx6I/B?= =?us-ascii?Q?JtcbaH+LLmFfuYemIQCB9vTPRsWIxZ/tvgm2byAaLH9RY8hz6GSaYtjWeWC6?= =?us-ascii?Q?C5ljPhsigBQsc2+xYFi+34XdW8mUp+l9BTKxZiKNXLg8ObC3H0Vy6rOJEfYv?= =?us-ascii?Q?GHfUNH/Is2vwCDmZgnnadqECRqomENY2jqYVFkgxGXJydBouqdx0XRvVSQHJ?= =?us-ascii?Q?oQTJ903jevc2T4gCTxFs1WCX8HmRPELYrxwe3ylb/CIng0A4OPmUGr8HGnEb?= =?us-ascii?Q?keiF+UFlPbi0052RkLmd9itKopFT8hfPTMbD+T7AWgbexilLdk9kalXJcuU5?= =?us-ascii?Q?S4MCtWPEQoicJuXItWaOsjOI+rhbmV0FPo4YounzEi07B/a4bgUf/MVlUPOC?= =?us-ascii?Q?ijQJtheb2e/nCYGRKGW6STANgAhpaO7cyzv+sdAl+vc2y1+p5/533xuqhCdS?= =?us-ascii?Q?xzlYwk9fvQoRVksrjoyu1igvSndDXhoorUR5bbXqOVnt/j60a2ZIaFf3Oa0+?= =?us-ascii?Q?uqre1DIbHnuCoAAA+nv2d8dvm9M+g82zKmgfZE/Q7noMsVkyAjgfQJid+2SN?= =?us-ascii?Q?7qbi6veviRyn2wCgulsxCqmT/nLn0KlCVKHIeQmnxWwsswy/SaZUbKxh6Zbu?= =?us-ascii?Q?RP8/JbgZWP9F1wY/Mk1VkfXK7FKVCoabZYmtV1SRkUoIS0c8BUTTr/jiyZNh?= =?us-ascii?Q?PFsOIqFAkkUDD/1NuStBGEO8TrxjSDw8ali1O8IckjiN9sHWjTIU0PlKzx4E?= =?us-ascii?Q?OUi3mOXFn+MLM4XOsPSLj6VdjSUzMkwN+gDh+hfoAb71g/bZBI+RI9lK+EQy?= =?us-ascii?Q?dT8q2Z1NYoxkfYvKRBdVmDaIW+r3+ZtX62qI9eqNiishtY38BcNq2iWgOwHw?= =?us-ascii?Q?DnXM7+L8l5P9p0TTac9m0pqZkE5vKL1d8xVqTWGOeYXwhSS/9VyoN03913k9?= =?us-ascii?Q?hbSQncqB4JsJTdHtZku+xhNHf+p/MS5y8mqhLbCR1/EjlbL+oAS2YVIbTHEF?= =?us-ascii?Q?gCJ394Qf8RmX2Axhtjhl8ixJlhu5juCYiyqhTRwJ6OOADzxZV9k/IhPwhKNn?= =?us-ascii?Q?eA4ddcEwf8Izsd7K8yRlsQlENP+zUfEvHQhbDNhKwyFipHavf5gsUZF8k0Fd?= =?us-ascii?Q?sZFVKBzxJrHcg2J7dDKbGclrDzmKJMQ4oZOZ4EPMpZTqt1NJg+c0V51azOQG?= =?us-ascii?Q?I58jMwdqRLlsC1TaJ7tk24pFXF9W0gUhw4s/joATi4zb2vpQ0feFkU82OpdK?= =?us-ascii?Q?jl5gVZ7StnqRgQC4uynw+VO5e7SH1OPAwvDqKYuUGOC3YkDEBNR2NSSw0bBh?= =?us-ascii?Q?qrd4hdsxgZaRVKky9DX84RpSaQMxr3sXD4MqeIuWpPFRiISbNfh0HhNOi/vI?= =?us-ascii?Q?JrKcZNAnQOgppYOkZva6mo8sLUeCcFQRsw0CBIyXhp1vEkL6Jh+hfUSDG/3l?= =?us-ascii?Q?0g=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: K4wLPfvRKO0fPNyUHFc5jEvltNHEH0XJ61isndELuzqCXQsMxaRH8uzvwvaV1ha8hz1z4KU55LBkR42gWtYZnO1LSXLXZNGIiWMrytjftyyzpknvbtu76l9NLmw/rL5xj2JffDUUjdDnwirWQ0F2GicieVYKV3Qu8QKpTjUzNvpxOzQvu/iV79wMHoYVoM6f5vlN0NsMzhNMHAHgNYgMFcRetVQOYFwaIgQipNVNBS5hCm58X8dHOTXCEd8haW1BoeBAmvEZ9pGgTU9CkE0u/PACIcnGP6Aa475AAZ239NcIpcBEyxYkhebmL/loDlGmFBOoVauMJV76TD4y+X885JqSBbOgRqxUMqxH4oJ534U2ISVuhxpQkaHvSWtUD2I+LWqYTL0CIFBE23RiKeUvT9OE73p6hmJadH5qIolAP6mXGgGhuVt6oXR7cbpAeDoX/hLW2KvHY9oNTfms2rhparo7Le8W9WI2MnjXskJcem2ma16UpJBbm9CkLLOXAAykSDBgI2xhhGdY6XvX0sBJMKixMVDhx7Y6jF5utvM5lKla+CTC0Nx1DkGtObpFzQmP/obJfFfzCZ3dizKDDbs2qGxhsSxE+TRAYNV7iW1BP6vpEQXUKpx0x78cGqDvC2wUDkUaI4hy8RncrcPlmXep8t8VWXjrDsjdmXxxWEehPh5DR6MguPRQu4UUbOnPt5ylYWMiGCR9R7VxrFu11sw2PvDNIfpH1qURuflQam5uiGyk8lbkRgc4iXp3J4MIR/Xx X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71630e10-038b-48d5-7cab-08db4649ba20 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5768.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 11:31:07.3782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S310YbedH1mclXPyIQBsTkP7pz+JFRgB0KG6QTYiTzSeH+AxO8o9j874tSDnHmd+ow4ibnIYEIAx8Y1MCVQQoMmanwYDwR9PBExlF/u8MTY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7270 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-26_04,2023-04-26_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304260102 X-Proofpoint-GUID: 0GbYb4EmXo0Wc9BjlfswHBfEUdqgtefP X-Proofpoint-ORIG-GUID: 0GbYb4EmXo0Wc9BjlfswHBfEUdqgtefP X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: oracle.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682508737867100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Shaleen Bathla Reviewed-by: Martin Kletzander Reviewed-by: Michal Privoznik --- tools/virsh-domain.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 6850843a259f..165aa0ee0f19 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1722,12 +1722,10 @@ static void virshPrintJobProgress(const char *label, unsigned long long remaining, unsigned long long total) { - int progress; + int progress =3D 100; =20 - if (remaining =3D=3D 0) { - /* migration has completed */ - progress =3D 100; - } else { + /* if remaining =3D=3D 0 migration has completed */ + if (remaining !=3D 0) { /* use float to avoid overflow */ progress =3D (int)(100.0 - remaining * 100.0 / total); if (progress >=3D 100) { --=20 2.31.1 From nobody Sun Feb 8 13:39:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1682508871; cv=none; d=zohomail.com; s=zohoarc; b=D0BqaaDqfioMmtu5tjSdTxFHIkVQyQrWcmyft63PUYHzKyZKdgNwscSw3zsg8PJWOhcycbwi7LCWjQJ35gnDvWM4nSEnEKvh+bEHS/PkFRnOeMVw7zp2Va8f6AowVG4QmHEaw69DWBTho2JJAA/UIkZ9WCLRoRQb9kG9drqHZDE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682508871; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uWC/2g83ypO0DMcuWQuzytigxIlKZ7QeLuLBuYZ+SKQ=; b=AectuB/vBrag4lrFOe/3I93lMGcGD4Pr0vifix/xdq249puUoOr5w4m43JhdX9ZOD8qzC2WLaE2eHGKe7PYJY6uHygRlnMPJgUM8o55eMuXS2brDx6ubepmVaeZNkE2ftcLEjk+ES7hPJk6tEGjhtUYVrsRGoElhFzp9ejAOq4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1682508871030537.5956917972358; Wed, 26 Apr 2023 04:34:31 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-FflNKSO-PQSYBPFAvoYBQQ-1; Wed, 26 Apr 2023 07:34:22 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C0A88533DF; Wed, 26 Apr 2023 11:34:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 342CB40C6E67; Wed, 26 Apr 2023 11:34:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E143519466DF; Wed, 26 Apr 2023 11:34:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C5CF819465BD for ; Wed, 26 Apr 2023 11:31:21 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A96C92166B41; Wed, 26 Apr 2023 11:31:21 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A179F2166B3A for ; Wed, 26 Apr 2023 11:31:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83A83101A551 for ; Wed, 26 Apr 2023 11:31:21 +0000 (UTC) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-Q6xMVAWsO7CvsRXm85FoNA-1; Wed, 26 Apr 2023 07:31:19 -0400 Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33QASgmH008950 for ; Wed, 26 Apr 2023 11:31:19 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3q47md19yu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 26 Apr 2023 11:31:18 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33QATw1I013387 for ; Wed, 26 Apr 2023 11:31:18 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3q4617j8gx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 26 Apr 2023 11:31:18 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:3ed::10) by CY8PR10MB6515.namprd10.prod.outlook.com (2603:10b6:930:5d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.34; Wed, 26 Apr 2023 11:31:15 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::f6d:eee7:6b56:1011]) by SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::f6d:eee7:6b56:1011%2]) with mapi id 15.20.6319.022; Wed, 26 Apr 2023 11:31:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682508869; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=uWC/2g83ypO0DMcuWQuzytigxIlKZ7QeLuLBuYZ+SKQ=; b=X+Xst9iRU2GAfbGzK0Ai//ATGheToA3zvKHnE5B6YWwIwL+l4pMDiSFllma4A5nNDZr6Wt 1al4tk6PeYljNvxN8+s1/6yhcKlHlub2wTBgk1G+982oHWqAZDbW25qQYdU3BIEOWxzBTd f2vJKZ727WiB7b+TtnpX80Fl28hQwNU= X-MC-Unique: FflNKSO-PQSYBPFAvoYBQQ-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: Q6xMVAWsO7CvsRXm85FoNA-1 From: Shaleen Bathla To: libvir-list@redhat.com Subject: [PATCH 2/2] tools: virsh-domain: display progress with enhanced granularity Date: Wed, 26 Apr 2023 16:58:33 +0530 Message-Id: <20230426112833.2634058-3-shaleen.bathla@oracle.com> In-Reply-To: <20230426112833.2634058-1-shaleen.bathla@oracle.com> References: <20230426112833.2634058-1-shaleen.bathla@oracle.com> X-ClientProxiedBy: LO6P265CA0026.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::16) To SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:3ed::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5768:EE_|CY8PR10MB6515:EE_ X-MS-Office365-Filtering-Correlation-Id: c162d63f-597a-46b3-32b8-08db4649bec1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: okKJVX2IiZ9B/gKC+Fq+o88kJk+zjMvHQulHuD7eLiVo43NzbtVZtWjeB9z0+QL9fjuufrBIVNd9cSTDE61gjSuwHr1kq8B7/Q8ZJ2rS+3OEVHct/Yfa/3LLsu19FbajwpVpomSvuWXLydipv2/APas7VW4X9BLUyiTiBpjhhI/9mWSocHGfuU18Uszl39snC82JOh+a5T/wqt+Di/NWtZsE9HZLLzrrSuT8Et4Q4shLAZMBtmHsAPeOtOKMfcXpo/WrgvFwDMhLY57h0Oup5VP4sSgsia4eFImOppZMiw+TMwZukZYLFiikX2RONmHKG1Nf8LzRg08X5bCaR2J8Fh3C9iugItcTnG5jTEKcSN7AUUhvjklo75PSxKfByeZ6fZnjj4BjD8HQH8j6TMWxVDmldYucTMY+LX/ZXVnvQDnhLRqtP4tNgssM9zvJsEU/6pgyks924blicOKHTV4Mzmi2LRVjZxIY0tnkcpSI/NLIUMvzwPSx1T2J6EiObDmdzzIkN2LiRnO/sigkDRCjfwMfVUH3Ip6suG46atpKTmg+u74dRqAFrvxbBZJtKZUz X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5768.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(39860400002)(376002)(346002)(396003)(451199021)(66946007)(478600001)(6916009)(66476007)(316002)(66556008)(8676002)(8936002)(38100700002)(5660300002)(41300700001)(2616005)(83380400001)(186003)(6486002)(6666004)(6512007)(6506007)(26005)(1076003)(86362001)(2906002)(44832011)(36756003); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ldKXSjb7UnWp07tapQapzl+uNWS5uiACpCG0wCfVaaKXbmOv3oO0BU/eCxiI?= =?us-ascii?Q?lF68vz3KW27bxryvdeFxegh3biSqySYXpe/X2kbhV7tgKrt+nS7Y5Z1+PpOM?= =?us-ascii?Q?LLlYiJ+vXkA/0ns3MVDZvCoq0857OAVkjigTUFtTnGclyUa/wQ9F6lWmEJ3J?= =?us-ascii?Q?9NjVMTdBGd1kZPhNhWECf7QttqJo3qX0DZDY9VMG5Xt6qp7Q2PKLaBorqZKy?= =?us-ascii?Q?N1kKbdhSmpNPBltDGwqSefif7zrJTmGsbutObz+DpVWqYh5zOI7DvyU7Qt1d?= =?us-ascii?Q?DsDrRWDctKrtCWfcbjee9XvFf1crQyvS8wHSvJQYPX7lryQ7Nf1kp7HNhCKH?= =?us-ascii?Q?Xp/Mh+1sg7/KS2Z+aVfDu7jNugzgEaRoPR+VXhdzYiZd9XxowM0q1rIP952n?= =?us-ascii?Q?VIlSzH8zRRNOVvmQkfeNDU125OJkk2nZMLzDQjODRQ1ss4bHOLvD30nvkJi5?= =?us-ascii?Q?tHTcw5pA1JzEKoehkyVmx5U1jp8c6YDinl7o2+Y6lD4cKKoMr4C9fIHk8e8X?= =?us-ascii?Q?Jw5QW15ZzMKTs+me7UUIcpxpHP/1DfUj6QnmGgpwhU/jQZ/tIUSuZDp0vxlW?= =?us-ascii?Q?tBdijJQL8T37wYj4rw78Jtkquf0QUovMksqzg6Q1NObp7cYRYm8uRdpS7Ak0?= =?us-ascii?Q?EbTOXBMqRmSBzvowXbU0PEqLZmAu/MpPZWhDxVNFDgmLouRYjArCLKUKW3c6?= =?us-ascii?Q?HtLbkrDx9c9hBtvgoDohfQKB70IzCKZn3xte1ZMn5rKtGqPXF00/5xqfj+YA?= =?us-ascii?Q?pW7jnutA7EmqPAQrTrpR8xOHUgD0o45efXIxvF1ckn1y4qahvFzliMHU1dd7?= =?us-ascii?Q?BDXxCm4U4NwKzAa/dg/vS7FtbBYAZnRm3sAVW+3sBSP9gl2Egv+kjtjHBlHn?= =?us-ascii?Q?0aMJ9U7gLJ87gd+i5tiijpyWmn3Dq1F17utqWThsV/ey8bAf1hu1uEe9LdbU?= =?us-ascii?Q?PwA3UmYkP+3TnNk1pJNL9X6ZFK8Yx7Iv6ysKBPnpl3vHEx198JeuES6wPcqs?= =?us-ascii?Q?Bmboa3jtOHTHzCj6peliieMePEhFAws6c1YpkaBhJs06KL8mZ4XUgX5F1x7a?= =?us-ascii?Q?9mhxe0tLc+WjIox1OSJ7NJFMMpzPlyQUFKdIEwIcfdcNJT46PLnzEwnv2AOB?= =?us-ascii?Q?RxwbuzjKDNP+MNO9qwbnHJnULpllCC6LupVVbXBeu4hke5PKOFSzVs/F0/n0?= =?us-ascii?Q?mPDAd2Mvb1AuphI7CIjea4fm1LoKre5i9NlaMn/bZAfLHTwhcOk9DNaLzlEQ?= =?us-ascii?Q?vg0YxWz1PJIV2Nz2LBXKpTuOaNRTDEyoX1oEcGqJafPx+exCqk0COla3PRxO?= =?us-ascii?Q?Q3bYFamHwFGrV4NaH8L/9eF5QXo0N0DL0mbS69onxSUK69BodQq6OjEB9+Hk?= =?us-ascii?Q?9z5N3X6ELNKX8xaRT2mul9pFTkUMXFNVI3QW8BZDSd24Lu3uYf5ZEymFzElb?= =?us-ascii?Q?+xpqI8tOgIJ5nO37I7dqgQDBZT2zoPE8SvIpd5pA0OVO/eEtwWPBaKWkvwSr?= =?us-ascii?Q?hERrbPIIzZWf02XcmXLLiDVc64xwGqozL5ZW+HizdLZJfz8CFb+HWhIsfJRN?= =?us-ascii?Q?bGtDWrUN6Mp8ontMjIafiShvujPag1lNq5KK+4heJOb8PqAsD5G9f2OJql00?= =?us-ascii?Q?Vw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: i+YYKGFulJLY7+ucZJArMevKdElwOUgtZofKXXxIJiEEWo6d0nI0O4nBMXupqWOd+9MrOdnQdvIP9jWkNHc+2nF3j0FXvMaUkPCeOljA+4oU+hOswWyPKPMyAaFEiB5YA0WZTOXuDnA8uwGNfhXjUl/5xD2Addqhi/dKMN4c+X4RobfqLGc616ewc00VHULhgY9CJlIzNGOFyALPYe1jW9+0PMKyv1alegKj5pAsVqYIA0d7l32mkKd8SCuXSmGftNjkJ3mQCc+NgkwDn/4TI/giQ0Cc9hKz2lmoL9XARdwNN1PhKpNaveWLJXbQ6NWON0W7blaKnRk/i1BOLvdTASlsywKOeB1/n9TO5K98X1U1C/tbxQCq6USm570Y2jZLjechjTh8Ph+seiLIphubEj7of0IleAoxkPNlZiC8CtgHjm8I9sTYVw1cdjExxmcLXrO5jYawSomN/LBqPwnmbdQ0bLZAQwatNnIRhTdNmsbhfu4KOe0iiklX0n8rnVHI8X7vFUwbAteOMtrLJ+vGPMpJBW5YD3Z9lxsxM0OwIaSZ06hFwlYun8Up9ISm6Xr7FehaFCVPvCbFrxW9jSKMGe4HUyDm5arV5lWtq8kNT9ce+qD6UPYOm9quO2nT16Z8pGlX9nwnpSwU8tvIY9R2qs/pRoveRxDoOFjwHcekJXNMg2N5vs2qvVxzy5zIA9VkLPxCGBojSTbSFihl7nIGpfS5nmMp3nV6dQ1U3LgMQIv8w9Or8zFHQw17JmYSxj8f X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c162d63f-597a-46b3-32b8-08db4649bec1 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5768.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 11:31:15.2591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zHAe/d+yxSsgjkVog4hBzWUPK7iZi5/iyomWfk+v9e0yAPS1doLUbl6nmGo1NsmdNudTCZfiGGX+bRZsG+Tz2vjh9c7zvvqx8t4OxGu94Ng= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6515 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-26_04,2023-04-26_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304260102 X-Proofpoint-GUID: eepx9fYfdixzp-CUmcg0W_kaynKEjLbE X-Proofpoint-ORIG-GUID: eepx9fYfdixzp-CUmcg0W_kaynKEjLbE X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: oracle.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682508872841100001 Content-Type: text/plain; charset="utf-8" Switch from int to double for displaying job progress upto 2 decimal places. Signed-off-by: Shaleen Bathla Reviewed-by: Martin Kletzander Reviewed-by: Michal Privoznik --- tools/virsh-domain.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 165aa0ee0f19..af2c0842079c 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1722,21 +1722,22 @@ static void virshPrintJobProgress(const char *label, unsigned long long remaining, unsigned long long total) { - int progress =3D 100; + double progress =3D 100.00; =20 /* if remaining =3D=3D 0 migration has completed */ if (remaining !=3D 0) { - /* use float to avoid overflow */ - progress =3D (int)(100.0 - remaining * 100.0 / total); - if (progress >=3D 100) { + /* use double to avoid overflow */ + progress =3D 100.00 - remaining * 100.00 / total; + if (progress >=3D 100.00) { /* migration has not completed, do not print [100 %] */ - progress =3D 99; + progress =3D 99.99; } } =20 /* see comments in vshError about why we must flush */ fflush(stdout); - fprintf(stderr, "\r%s: [%3d %%]", label, progress); + /* avoid auto-round-off of double by keeping only 2 decimals */ + fprintf(stderr, "\r%s: [%5.2f %%]", label, (int)(progress*100)/100.0); fflush(stderr); } =20 --=20 2.31.1