From nobody Mon Feb 9 23:57:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1682493129; cv=none; d=zohomail.com; s=zohoarc; b=aLNBokAd/JF1Gt8cXqRRqs5j0sVquLt8Iie4OOHjAzIJOx+OSIMK25FURpOi4pnZ7SMNQmhTQESc3DJBeK9LH7uMCcZka0GwfTxJLMvzT+8AoFdx6NL4L5QE77QwdjjGi2/Poj1uBGA5hZMoZ0mabtZ8m44a5RO7vvcHxKT+LG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682493129; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=R1lqkQy0KQ4ervNa4Nm65Anixx70ZjpV1K4OfV7iAZs=; b=C+wIzzJkIvr418WNmZymiJvIgLCABcGVzAXcGNA+SHf0wBfNAYpuYHUtAkHv3ZToRafumHRg+Ku84v9QL9LLpKxjDFcWwNzwyU3EDxrav1lzZL7hD+4whuDd2dgxDyDy1RGX4hcx7SpTBZf9KqYE4gk/8EhH4DK+MyhdQIDQEsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1682493129382874.719569562103; Wed, 26 Apr 2023 00:12:09 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-443-vN69kSBrOsCyD-C4ujc_QA-1; Wed, 26 Apr 2023 03:12:05 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 63D3D29ABA21; Wed, 26 Apr 2023 07:12:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 47A382027045; Wed, 26 Apr 2023 07:12:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F228D1946597; Wed, 26 Apr 2023 07:12:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1BA4E1946595 for ; Wed, 26 Apr 2023 07:11:56 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 186494E3C7; Wed, 26 Apr 2023 07:11:56 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast10.extmail.prod.ext.rdu2.redhat.com [10.11.55.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D73F4E3C5 for ; Wed, 26 Apr 2023 07:11:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF94F1C05149 for ; Wed, 26 Apr 2023 07:11:55 +0000 (UTC) Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-20-cQMtkGE4O2m-pYNeDHNknw-1; Wed, 26 Apr 2023 03:11:54 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33PMEPEe013644 for ; Wed, 26 Apr 2023 05:27:35 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3q46620k5d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 26 Apr 2023 05:27:35 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33Q3TuQV025226 for ; Wed, 26 Apr 2023 05:27:33 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2104.outbound.protection.outlook.com [104.47.55.104]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3q461dpu5y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 26 Apr 2023 05:27:33 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:3ed::10) by SJ0PR10MB4574.namprd10.prod.outlook.com (2603:10b6:a03:2dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 05:27:31 +0000 Received: from SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::f6d:eee7:6b56:1011]) by SJ0PR10MB5768.namprd10.prod.outlook.com ([fe80::f6d:eee7:6b56:1011%2]) with mapi id 15.20.6319.022; Wed, 26 Apr 2023 05:27:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682493128; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=R1lqkQy0KQ4ervNa4Nm65Anixx70ZjpV1K4OfV7iAZs=; b=YJ5CWt/r7OOSXaWnCmjls3pNms7kG9AkYHKT11rS3pjYHIp6EV2yrDziCjamYo7V4samdv /NQFIlzR7b2uUZLvVqd00LabehiQ3N/snefczRwWBUTr4K2IoBDZt/rC9+FBkA5vB1PxYc K15oQLOE4rmIb86dcQ7nuEzPAYdFohc= X-MC-Unique: vN69kSBrOsCyD-C4ujc_QA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: cQMtkGE4O2m-pYNeDHNknw-1 From: Shaleen Bathla To: libvir-list@redhat.com Subject: [PATCH 2/2] tools: virsh-domain: display progress with enhanced granularity Date: Wed, 26 Apr 2023 10:56:56 +0530 Message-Id: <20230426052656.2555710-3-shaleen.bathla@oracle.com> In-Reply-To: <20230426052656.2555710-1-shaleen.bathla@oracle.com> References: <20230426052656.2555710-1-shaleen.bathla@oracle.com> X-ClientProxiedBy: LO2P123CA0072.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::36) To SJ0PR10MB5768.namprd10.prod.outlook.com (2603:10b6:a03:3ed::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5768:EE_|SJ0PR10MB4574:EE_ X-MS-Office365-Filtering-Correlation-Id: d6fa0cd5-f0b9-4351-150c-08db4616eec9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: /Fd73amt4jHP/2Z1vqvLLwWCpdIdmhlSEq3PQhoC4J65nAs4X1c4QCpFoWbOmLfSLBaifsgrG3apg1QU9gh3rkPKPbdR7tqOTtaoxTrbG3KrTA6P8XKW7vhlf8/g+PHefVB6hFiRBz8HVyukJNyuJEoTB0x12VJYaYr7UrVq+mWGAJjct74jOwA8DUN80reiXcodAKeM1BHtHxVvSYO5cyCb0bmh6RqnFx6YW3Mss6IJA06qysw6YBmpwQo8hpNqo5c6F6GaOz74GhD2/CaZpHuw3TDMzfNM/9RxYdqZMsmJ2c7qY9TMdomLpEq85kKgPoyah0BYk/t+rtHDKqBPdeEd+ilubEqV2ZWbJqitFad3E2n1OG+IVgvycxSTTfJRPV0xghT5ZdHzYDq3EIb2YUMLRK5UT0sG4Cjry/R/0lTknUQGPM4gFG4Y6eO3SjXGVtiGl5v1tRAY5t5yi7oe0zond0KMii25HXMCmhzNuQAwvC4+705VJVhjnFp+K2MintiQ6oIlbmki6DJaf9BfXwbsnyolRfDQsOsWddp1afp+lq926usgoXZ8aJu8lN/5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5768.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199021)(2906002)(2616005)(6486002)(36756003)(6666004)(83380400001)(478600001)(186003)(6506007)(6512007)(1076003)(26005)(316002)(6916009)(66476007)(66556008)(66946007)(8676002)(38100700002)(86362001)(5660300002)(8936002)(44832011)(41300700001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cntVGZZNXM4TbA8jje+ksfvR6ERhBq9lmR8mFU6gckXbL3zBUI2vhcz5enCB?= =?us-ascii?Q?v8pEE7ubdja7GIwUg3ZvKrY8F2WWWGgKbUfDbDpJATG76SGr/QFBHSKXwpcw?= =?us-ascii?Q?LH6SUvUn6CnHJSWBbncp1eVYd3qSQeGgcbwhIMGRW6rNZWv7pGwZnptefpEh?= =?us-ascii?Q?36j12WMG/R8YBnTNb9JQ47kCmGT1uMTO1Wyu1y4ojgnWd4kAa07LejprAKEQ?= =?us-ascii?Q?U3Rgq8sraEVZliWvWCsqy1QRkiSJe6CeHHP3fS4ezYaFSJFA9aq77lmCQeTV?= =?us-ascii?Q?hw8uJ+4NSNhNfbpQN8BLsPCcqlOhKKVsIQp8GZaCnX93CxktsnLXv2QM9ZMo?= =?us-ascii?Q?Z4rY///JkGPdwapTHahKgqp9ybdLRL89HSYqSlxt/Ppfalri5oxRoYF9Zcl4?= =?us-ascii?Q?AEywmTH/lMlTU01MEC88bOLw/XS53vRePTh49ep4IGOD9Kff93wjeKoZHdPj?= =?us-ascii?Q?cOYl3vgS2OkPXEeNKpUpQ86z+0mFqWvxja9zlaVnmkDBxfXPrwFFdbPuYOQT?= =?us-ascii?Q?6YVXpk5IAo1t9TFPXfvLELAPVWukt8e1nbHUQ3KLKv5ZxX1FdjN3VENSdrp7?= =?us-ascii?Q?qbRn+AGe+dHLpmqUrEQKdQwwyB+W0Lp3uctMvtR6dThOh7Y1984wvez1AZXE?= =?us-ascii?Q?kAj7a4fPQAeiQylBVLkIz2OADMzL0OoIM3vAFl8O8B2lRsUPKpDrqOucw3u+?= =?us-ascii?Q?srg/0U8bgAoUnNrYnZG4qvRf8bwrVIqds1d6EhPjEFfC/S42y7GsEAxz9l0t?= =?us-ascii?Q?CeVZfgZ1W0iv3JbQlGzlOvL35WS8Vy2/uBEj8NsyaB+tfHuf7RCES5zgtugR?= =?us-ascii?Q?Lc35Tq1J/ud0+2+iDdtQ3WetzSaBjFhp3DGhJ25+QKKlt3HFrXMD9kHkWvkX?= =?us-ascii?Q?TJHX0gC4J2Tbd8z/46x8A8clRuOGHfufWd2eh5uHixFA+P3+5JkPLYZvloDc?= =?us-ascii?Q?pTYH0ChFXhel7axBAR9nAOWeMnnCV/9WRasD1cllM7llvsxL4oeKgSRSepbb?= =?us-ascii?Q?8/wqYMPWG4fgJPS6jUvHzB4tepIWg7ZisZrUO+7xiMrO8S0RcSguAEEG2F4R?= =?us-ascii?Q?7yv+nOKyAiOdJxleJapXPZXVziwwxuS2UKlHNF2Xu28nSJ0am7YACAihq4Jc?= =?us-ascii?Q?8OYbLuI+BOxawUDyhYpakSEeMyKuvC+DiR4TlYNqLuXnHUVwuXBEdWUsMZyn?= =?us-ascii?Q?A9dFK2GHh02WyZ9v4XjYGQVLFTmnJYwa0Yer4GPuZvEPd3dhGew5FtgXJByx?= =?us-ascii?Q?vtkmxofz1QgDv2Lyk4Ng8vdjqJv60Z/NUt5vCVCzq4riOHRhT40xo6L7uhxj?= =?us-ascii?Q?Gy43SkckgfIPix6oi2X3PxQKRbODD/oKZNYbLC90e0oMg25PzULHdGMNnOj4?= =?us-ascii?Q?bj5jkCKmOX03+yhoilwLe+5dllPbFyhvEYoYQWOeKrKgAq0b6syrFfkdYMeJ?= =?us-ascii?Q?1xIXWvMTY3bPz5/eSnecYUdUkfy36WG4JXNWs2HokmXfhVtmFBaPjAYwxRtk?= =?us-ascii?Q?RugXWeKDZpZOJvjP87DcsyppLZMHQIcZWWIQLjvd3O2llpNSpdFLlM9484tI?= =?us-ascii?Q?ljNkdeEFJBnDwP2hzSzyDi9WIDoihzuWF5VsdSi5ZpDws2MfqwemES0kZIAj?= =?us-ascii?Q?gw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: leYPVr0tUTsWYMId0d3efWTub2deZxTw9sFFlVXsihHcLY+V55a9W7miGn1eNO+dPVcr7Ftm5NB23cuw5Xgbu43a3L0SKYxwQVT1HSpAR4fArjKKbDDEzO3dQyXosRFYP3gPUYE8QUmp6YNUq3EYtaNTOErSI/bpGM1VhZjzTW8/R+w5qt2/vMLnmfNielV9j17gPmm5nI5ae4pZpPcvRasjaFlGSBQlJBOErXnGqJDFv46reDLPhfwmG86aOPXPwXuI8X4rRWbb8tXpC/mSWZT/QUvFQnDz7R4aYbvg/toVdiUjCYFUzgLGaxJprA3w/5gBJWOnTxJxtBCdhOXo56fgg5N1HfwWustcCjgIfKKY95GFUBSdWn8TavratcX1snl3vh2rU5MpC7W6fuPX87PpM0K7QFi3yQgBa5A5ULqcms8rRn5N+HEgr0YKIs7Ep2ZvNiN/g+U353rE6zQ+fEk4HtK+yTBJr+3WxqBhSlSQd/Hl/+PVGTZvbwoUf2mUCkMblxWOk8Ol3+GFCBi57RJ/JCLT0xF99x0NjC9p4myP6MCrZ1AX9gEJoQ00MFkYyLuSdD+m2LsvPZ8TLsfexplsraPFRwE2WJhusgdsGla3PkClHEGNlSaotc9gv5TfSHXDhiSCq2sxuavrfEeemSmBAKUPkHku62nBI1rIlIVFVHYtwaXAKSLYVH4hrBFJCABpJx1dNdhglvwk5F9c4GPAFs3QCpXyRJDkNX3TOa8zMAKwf7iOoOZLMfP4RC7B X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6fa0cd5-f0b9-4351-150c-08db4616eec9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5768.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 05:27:31.5654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cwN0z7B332jxMlO9iEBLHuKPIqMoc7UnwTiqde29d4qK+KOpKcU2ofhkAYsr4EvQicPRJkaRK0MgoGKOV63iCRAZQF/+W2hfRMCcXBOfqDY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4574 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-26_02,2023-04-25_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304260049 X-Proofpoint-ORIG-GUID: vMsOri3fLbkb3l8-T9w6zLANTwI53p67 X-Proofpoint-GUID: vMsOri3fLbkb3l8-T9w6zLANTwI53p67 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: oracle.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682493131650100003 Content-Type: text/plain; charset="utf-8" Switch from int to double for displaying job progress upto 2 decimal places. Signed-off-by: Shaleen Bathla --- tools/virsh-domain.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 165aa0ee0f19..9f82722b2ac6 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1722,21 +1722,21 @@ static void virshPrintJobProgress(const char *label, unsigned long long remaining, unsigned long long total) { - int progress =3D 100; + double progress =3D 100.0; =20 /* if remaining =3D=3D 0 migration has completed */ if (remaining !=3D 0) { - /* use float to avoid overflow */ - progress =3D (int)(100.0 - remaining * 100.0 / total); - if (progress >=3D 100) { + /* use double to avoid overflow */ + progress =3D 100.0 - (remaining * 100.0 / total); + if (progress >=3D 100.0) { /* migration has not completed, do not print [100 %] */ - progress =3D 99; + progress =3D 99.0; } } =20 /* see comments in vshError about why we must flush */ fflush(stdout); - fprintf(stderr, "\r%s: [%3d %%]", label, progress); + fprintf(stderr, "\r%s: [%5.2f %%]", label, (int)(progress*100)/100.0); fflush(stderr); } =20 --=20 2.31.1