From nobody Tue Feb 10 01:50:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680187186; cv=none; d=zohomail.com; s=zohoarc; b=TlI9oyn+cK8Br6vVRbfEE76kXVCtsa/sQeVcGqcEvG4dLKhMonJSoIA3l4PwV6lHXNH7rH8OYtWzfYOaJeZBjClsK9W68SsDuW7EDnwcX9W67XiiKs0LRkmClMn27nl4Js/0guwQWxlJycgcG5QNszyDsBx1bKllJ3yKfcQC6/g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680187186; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wkw/MSOj1qlzl8KG7D2Gr+UeKbJp7IDRaUXA93J5NpE=; b=UtPbzRKQr6Vrjky1kOx4WbQdiQLXwymrCYV4MbbqIBKd6PGCAQG0q9n95rz2TBbDPnHxDQm4Nj745/2ZwaPWtwn0K7VC7M+FNPJB0HyBNIgUUn1B5VFKleGJZslQ8SYBvvJOHsmV2iZdKQfnraTI0IGchU8VWA04jTJtftbL78M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1680187186007777.6277716606655; Thu, 30 Mar 2023 07:39:46 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-435-Lz45vDP6ODuy1h0NiYGFuA-1; Thu, 30 Mar 2023 10:39:42 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 624D71818E5F; Thu, 30 Mar 2023 14:39:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C0EAA14171C8; Thu, 30 Mar 2023 14:39:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7447D19465BD; Thu, 30 Mar 2023 14:39:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 947631946587 for ; Thu, 30 Mar 2023 14:39:36 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7AC4440BC798; Thu, 30 Mar 2023 14:39:36 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.227]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B9D240BC797 for ; Thu, 30 Mar 2023 14:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680187185; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=wkw/MSOj1qlzl8KG7D2Gr+UeKbJp7IDRaUXA93J5NpE=; b=X8R/UjKZv5KDyv2qwTSjCRTsay0+xcF+VPvGbGRidkUykFrp5HxxBIOHBNpt+8L4wKz9us ehOcnbFazk84rL/xejlwpGrUFE1ZnRcphPSB7sDWnBOWTjwZMzscWtG78lVQ9KVAf8Y4XR NPRGpu0hgc8p2DxQCEJ6YKQKkjFw31E= X-MC-Unique: Lz45vDP6ODuy1h0NiYGFuA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] tests: Drop dead code Date: Thu, 30 Mar 2023 16:39:31 +0200 Message-Id: <20230330143933.423024-2-abologna@redhat.com> In-Reply-To: <20230330143933.423024-1-abologna@redhat.com> References: <20230330143933.423024-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680187186845100002 Content-Type: text/plain; charset="utf-8"; x-default="true" Left behind by commit 35eb484 ("tests: remove firewalld backend tests from virfirewalltest.c"). Signed-off-by: Andrea Bolognani Reviewed-by: Jonathon Jongsma Reviewed-by: J=C3=A1n Tomko --- tests/virfirewalltest.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index 51c8006331..e676a434c8 100644 --- a/tests/virfirewalltest.c +++ b/tests/virfirewalltest.c @@ -788,10 +788,6 @@ mymain(void) return ret =3D=3D 0 ? EXIT_SUCCESS : EXIT_FAILURE; } =20 -# if 0 -VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virgdbus"), - VIR_TEST_MOCK("virfirewall")) -# endif VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virfirewall")) =20 #else /* ! defined (__linux__) */ --=20 2.39.2 From nobody Tue Feb 10 01:50:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680187202; cv=none; d=zohomail.com; s=zohoarc; b=KVEsZ1exDWdYlDryBNm8wT6VkfJwq0FZ3ak2EXsMscUCXAhXmJh06LOGeUjEB2dcLWf82CtH9+IruZPCwsQmi6km0b65I+WEYEu31gQjv4JkgXNbZgIzfjr8hBZGkD9rYHqZ1U3nAI1LG50EqHptIVhRX+Uj5rOa9hvZZhdiujk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680187202; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G2xMDEYBKF16Hx5pJSmCR/EHepi8Dxp2Y4odm3rgwtU=; b=O6w+ARC2R0u9be8B+rov3EA+aaNsMle+DDrFlZWcOyZT+jjyaL2gPrvVVICvlDd6lOnOejtre4gEuKKfEZ6cvqkIlobyjV8etM8LlVs5cBR9MVuCVD1G1cPNVJNT6bWrSAvT/AudTpov5x8AucYCiC0/N66Nh3npH/alnnCJ5tw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1680187202665478.852615834076; Thu, 30 Mar 2023 07:40:02 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-542-S3Dv831zNmq6GwrHh9gmsQ-1; Thu, 30 Mar 2023 10:39:56 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F11A1818E66; Thu, 30 Mar 2023 14:39:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6ACA540BC798; Thu, 30 Mar 2023 14:39:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9F21A1946597; Thu, 30 Mar 2023 14:39:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 4E3A719465B2 for ; Thu, 30 Mar 2023 14:39:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3E0C640BC798; Thu, 30 Mar 2023 14:39:37 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.227]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0C7340BC797 for ; Thu, 30 Mar 2023 14:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680187201; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=G2xMDEYBKF16Hx5pJSmCR/EHepi8Dxp2Y4odm3rgwtU=; b=W+r677hRsAJY0OG3FaCAm1N+sM2QGOTq/Wx79LqrSlaEFXuCrjFxrst2RlitOHTPdbYj45 nXWVZMnKkXFprlbKNWGiw3xSU0M332ppetfCk7LHjU8Vds8NXurG2LhWYXxGVw523VXFLw BNUBw3hjZ1ec+7Mp2NQjBQky3FBM51I= X-MC-Unique: S3Dv831zNmq6GwrHh9gmsQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 2/3] tests: Don't build virgdbusmock on Windows Date: Thu, 30 Mar 2023 16:39:32 +0200 Message-Id: <20230330143933.423024-3-abologna@redhat.com> In-Reply-To: <20230330143933.423024-1-abologna@redhat.com> References: <20230330143933.423024-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680187202933100001 Content-Type: text/plain; charset="utf-8"; x-default="true" All of the tests that use this mock (networkxml2firewalltest, virsystemdtest, virpolkittest) are either no-ops on Windows, or are not compiled at all on the target. Signed-off-by: Andrea Bolognani Reviewed-by: Jonathon Jongsma Reviewed-by: J=C3=A1n Tomko --- tests/meson.build | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 6be806f4ae..fa3d5380d4 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -82,7 +82,6 @@ mock_libs =3D [ { 'name': 'virdnsmasqmock' }, { 'name': 'virfilecachemock' }, { 'name': 'virfirewallmock' }, - { 'name': 'virgdbusmock', 'deps': [ virgdbusmock_dep] }, { 'name': 'virhostcpumock' }, { 'name': 'virhostdevmock' }, { 'name': 'virnetdaemonmock' }, @@ -104,6 +103,12 @@ if host_machine.system() =3D=3D 'linux' ] endif =20 +if host_machine.system() !=3D 'windows' + mock_libs +=3D [ + { 'name': 'virgdbusmock', 'deps': [ virgdbusmock_dep] }, + ] +endif + =20 # build libraries used by tests =20 --=20 2.39.2 From nobody Tue Feb 10 01:50:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1680187188; cv=none; d=zohomail.com; s=zohoarc; b=UDvwQuSGO0mLpZLAA3eaIO+PyPWKT8/8KrXm5mi5q2F3jSMIocHwFhGziaWa3+y7Q1h2pBtmb0FDQ8ARmgDBNxczcMs2Em3cNxi/Dt5W54LRcXrVdcDQ3jNbivl3fQvrY+uQmJyDK0Oa9QHFUlmzrNask5lO7yJBBz8za0R/RNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1680187188; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D5uml8AhgoHYjqoBax0XbutfpRKiMRy+PckLdgYy/nU=; b=kTdlILP8DoFkumbTv6a8sLmZCrJEs2fOEFJlwfcj2gj4qjCjxZ9mjPXTL0/tXFvjepwpZ2HEFylU4fODT+2uDkx7STGJi3xUYNK/Dfr8RwBHuJEymtIoEm3/NK7IWMqmgSSEYBy3Iu5Kmmx4nDS86dZr5VXPx97S6u2AQUC7nPI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1680187188342988.7476719316059; Thu, 30 Mar 2023 07:39:48 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-445-mhnS2wusPKKp_elbsenrZA-1; Thu, 30 Mar 2023 10:39:44 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7AEB1100DECD; Thu, 30 Mar 2023 14:39:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65EF318EC2; Thu, 30 Mar 2023 14:39:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D958F194658F; Thu, 30 Mar 2023 14:39:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 772C91946587 for ; Thu, 30 Mar 2023 14:39:38 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 5EC2840BC797; Thu, 30 Mar 2023 14:39:38 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.227]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3D6640BC798 for ; Thu, 30 Mar 2023 14:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680187187; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=D5uml8AhgoHYjqoBax0XbutfpRKiMRy+PckLdgYy/nU=; b=c5/oz203cRTi99W/NxsT/r86mLZSpiyQfO2wS46evG8IMGsMXykgIxsczDQWox9LnNVgu1 ES/M9xiqoNQhRZK3/mvJFjqL/xWqg4nvnw6s7WvbH6wAOUnsLF2ExBjHONppFv+Mj1JoQd uV/BoWxrHp10W42aC98ZGndgKodOZOI= X-MC-Unique: mhnS2wusPKKp_elbsenrZA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 3/3] tests: Don't use GIO_COMPILATION Date: Thu, 30 Mar 2023 16:39:33 +0200 Message-Id: <20230330143933.423024-4-abologna@redhat.com> In-Reply-To: <20230330143933.423024-1-abologna@redhat.com> References: <20230330143933.423024-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1680187188854100005 Content-Type: text/plain; charset="utf-8"; x-default="true" This flag is intended to be used exclusively in the context of building GLib itself and should not be passed to the compiler by a third-party project such as libvirt. Reverts: 77d1fa5 ("tests: Compile virgdbusmock.c with GIO_COMPILATION enabl= ed") Signed-off-by: Andrea Bolognani Reviewed-by: Jonathon Jongsma Reviewed-by: J=C3=A1n Tomko --- tests/meson.build | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index fa3d5380d4..3b77973742 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -65,10 +65,6 @@ else endif =20 =20 -virgdbusmock_dep =3D declare_dependency( - compile_args: [ '-DGIO_COMPILATION' ] -) - # mock_libs: # each entry is a dictionary with following items: # * name - mock library name which is also used as default source file n= ame (required) @@ -105,7 +101,7 @@ endif =20 if host_machine.system() !=3D 'windows' mock_libs +=3D [ - { 'name': 'virgdbusmock', 'deps': [ virgdbusmock_dep] }, + { 'name': 'virgdbusmock' }, ] endif =20 --=20 2.39.2