From nobody Mon Feb 9 15:26:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679476249; cv=none; d=zohomail.com; s=zohoarc; b=jFt8nfxmaNxJr21zIABS2jZwHKymTe/JO8l4t5Sw4g5Wiw+Vhz5p65vKNcrCG+8yWloaRAyx5g5HE5j2BBXTD5dAd5bmXzfdSuvle9987SHzZkc/V774OJn/MB2IwVHlC/Ih0M21gKm54uLJF2Ka6WVU4pYLFmtNQyv3yXy2bPk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679476249; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IvHXtKfpn2OFbvfE6H6Wh2uMc3VK4oLMpCffhmOK2w0=; b=bmNdyzMro+iaRWZ1bQoVNtG+RthqRNh/YMCbwBCqBbiwH8OvNjYqfO7VhEtm/gi2KwNgjUK8Svd1w4Pbhcg7qvxArk9M48ZBSis9JnwAn4w397cyOl9T81NVFVa+93YxgsIXXGfjIzcvSZdNPI6DUx9xE7Die4ZfmykWMmMdWDQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 167947624934352.1637473601977; Wed, 22 Mar 2023 02:10:49 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-438-oKCSan4CPaKVwkNwfVH10g-1; Wed, 22 Mar 2023 05:10:45 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 45AF21C0754B; Wed, 22 Mar 2023 09:10:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F4A3C15BA0; Wed, 22 Mar 2023 09:10:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9BF291946A5A; Wed, 22 Mar 2023 09:10:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9CF6F19465BB for ; Wed, 22 Mar 2023 09:10:31 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 92CA940C6E68; Wed, 22 Mar 2023 09:10:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8966040C6E6C for ; Wed, 22 Mar 2023 09:10:31 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6EBB7857F81 for ; Wed, 22 Mar 2023 09:10:31 +0000 (UTC) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-iSkZkHbaNquTkAf2Z_xR0A-1; Wed, 22 Mar 2023 05:10:28 -0400 Received: by mail-oi1-f176.google.com with SMTP id y184so13106648oiy.8 for ; Wed, 22 Mar 2023 02:10:28 -0700 (PDT) Received: from grind.. ([177.95.89.231]) by smtp.gmail.com with ESMTPSA id s3-20020a05680810c300b00383ef58c15bsm1994784ois.28.2023.03.22.02.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 02:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679476248; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IvHXtKfpn2OFbvfE6H6Wh2uMc3VK4oLMpCffhmOK2w0=; b=Sexoj4vNuwuR7evs2kwdWR5fGhB2lQDdR1G8v2NBYarp7ZfzANCcQBV+aVy2RV8rtY/AgF VLHjXBZf9d/+Dhmy8rYrT86waRfSMbxyyXZQe+AUL1W0zxqfRH2q5NqBpvtD2dBgDmKAS+ zHsPzJ1dADmLkTjrUrE8oztz0gmEDq8= X-MC-Unique: oKCSan4CPaKVwkNwfVH10g-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: iSkZkHbaNquTkAf2Z_xR0A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679476228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IvHXtKfpn2OFbvfE6H6Wh2uMc3VK4oLMpCffhmOK2w0=; b=uikV5ZXNC3fYhi3jkKMo+8j3qHH7xKLTZgbGjqcSXY3e/ncln9u1zXLoWW9utyaUvc NGLhItueDoVnawXphlBn8Sw1ls91tH+YLnUqP5Pg2SpVf5xI/ljojtTkj7c2dl4a+6ZP SmuE1fjCaI9LH9xkJp9UoBv21gc3cmpFksC80qSI+B4so8DTQ69AdL4+4U0vAt4y94tl YBqT8+DSIRrwh/AB3+JWpdCjFQFpNNVOfeSgclN8rEWRVpNtGGGqCec9bz1whidKGGt/ wJwGqAAroac/k8ToYEnPCYXiAR96hs8cF50uD/YnjMnK1kA32sIBht9J+wo3W5auVMY3 EgQQ== X-Gm-Message-State: AO0yUKWZdc0KhQrFlEvRYNJ5t/NK2FJ9KFHWTVDaLX2YaWZWPZGT2Dih ITdF9aejLfBXefcE/42zWG309s6ES5hsi+YufKA= X-Google-Smtp-Source: AK7set8zq3vQrighuvClIYs6LSyAUWi7e9iMtdVMqu/bJuPmbA3CPoxE9PbQ+ECKtRkXlEaL2fDSpw== X-Received: by 2002:aca:1103:0:b0:384:349a:15ef with SMTP id 3-20020aca1103000000b00384349a15efmr936880oir.36.1679476227798; Wed, 22 Mar 2023 02:10:27 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 1/4] conf: add loader type 'none' Date: Wed, 22 Mar 2023 06:10:18 -0300 Message-Id: <20230322091021.186927-2-dbarboza@ventanamicro.com> In-Reply-To: <20230322091021.186927-1-dbarboza@ventanamicro.com> References: <20230322091021.186927-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dbarboza@ventanamicro.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679476250219100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Today, trying to boot a RISC-V Fedora Rawhide image in a RISC-V QEMU domain results in the following error: =3D=3D=3D=3D error: Failed to start domain 'riscv-fedora' error: internal error: process exited while connecting to monitor: 2023-03-20T17:31:02.650862Z qemu-system-riscv64: Some ROM regions are overl= apping These ROM regions might have been loaded by direct user request or by defau= lt. They could be BIOS/firmware images, a guest kernel, initrd or some other fi= le loaded into guest memory. Check whether you intended to load all this guest code, and whether it has = been built to load to the correct addresses. =3D=3D=3D=3D This happens because the default RISC-V QEMU firmware, OpenSBI, is always loaded unless "-bios none" is passed in the command line, and the Fedora Rawhide guest kernel has its own ROM. Other machines such as PPC64 'pseries' shows the same behavior: the default firmware is always loaded unless specified otherwise with the '-bios' option. At this moment we don't have XML support for '-bios none'. Using "" works but it will leave the domain in a tainted state. It'll also have unpredictable consequences with the autoselect firmware feature libvirt has. Add a new loader type 'none' that, if no path is specified and we're not use firmware autoselection, will tell QEMU that no default firmware should be used: (...) Signed-off-by: Daniel Henrique Barboza --- src/conf/domain_conf.c | 5 +++-- src/conf/domain_validate.c | 2 +- src/conf/schemas/domaincommon.rng | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9ef50c818b..d7a5cd094b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16837,7 +16837,7 @@ virDomainLoaderDefParseXMLLoader(virDomainLoaderDef= *loader, return -1; =20 if (virXMLPropEnum(loaderNode, "type", virDomainLoaderTypeFromString, - VIR_XML_PROP_NONZERO, &loader->type) < 0) + VIR_XML_PROP_NONE, &loader->type) < 0) return -1; =20 if (!(loader->path =3D virXMLNodeContentString(loaderNode))) @@ -26259,7 +26259,8 @@ virDomainLoaderDefFormat(virBuffer *buf, virBufferAsprintf(&loaderAttrBuf, " secure=3D'%s'", virTristateBoolTypeToString(loader->secure)); =20 - if (loader->type !=3D VIR_DOMAIN_LOADER_TYPE_NONE) + if (loader->type !=3D VIR_DOMAIN_LOADER_TYPE_NONE || + (loader->type =3D=3D VIR_DOMAIN_LOADER_TYPE_NONE && !loader->path)) virBufferAsprintf(&loaderAttrBuf, " type=3D'%s'", virDomainLoaderTypeToString(loader->type)); =20 diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 5fb2d4971c..1fea9c8e6b 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -1664,7 +1664,7 @@ virDomainDefOSValidate(const virDomainDef *def, if (!loader) return 0; =20 - if (!loader->path) { + if (loader->type !=3D VIR_DOMAIN_LOADER_TYPE_NONE && !loader->path= ) { virReportError(VIR_ERR_XML_DETAIL, "%s", _("no loader path specified and firmware auto s= election disabled")); return -1; diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincom= mon.rng index 6158ed79ac..c96658e3a2 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -341,6 +341,7 @@ rom pflash + none --=20 2.39.2 From nobody Mon Feb 9 15:26:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679476268; cv=none; d=zohomail.com; s=zohoarc; b=VoIlpP8C7dvIuUVJ5jqo1RiVkyeMdWJo7OSwPZZwiKnrCcsev5LY0WDl2zR9Xybsu+hd67eXYoN02orVenZlwMB4qcHwSGCOpRddxi8Bc6aPSYrOrUfJ4kX52D8wDRUXbHvvT94OQ1eqyOAY6541u/OXrKRE4q3TFk6m4midgZs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679476268; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UD8SHZYyvj4wJZVuXEGd3nphZW38JCCs7msgOd7Wx8c=; b=CIOOINFBzD4QZcWz3jJ7pa+PwDCv2JBEeKdfvg/SixzBg0TUJKcPU9/j3DxzBADrdIGlHp3A4LkF4rIn+nrHNDVXlIJRWcdfAvT9vbVNEnRzQyj/H53AEUfz2O78qMXON48c+L1AA8ugzh3bSmVYR8cousgfFNM9C4TQwAITEW8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1679476268115762.4724639573946; Wed, 22 Mar 2023 02:11:08 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-133-KgZbGzfGNgWSoOHZ-9T9LQ-1; Wed, 22 Mar 2023 05:10:51 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C26F185A7AC; Wed, 22 Mar 2023 09:10:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0089240C6E68; Wed, 22 Mar 2023 09:10:49 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C61BE19465BA; Wed, 22 Mar 2023 09:10:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A04621946A61 for ; Wed, 22 Mar 2023 09:10:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8111840C83B6; Wed, 22 Mar 2023 09:10:32 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 798BF40C83AC for ; Wed, 22 Mar 2023 09:10:32 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 600B985A5A3 for ; Wed, 22 Mar 2023 09:10:32 +0000 (UTC) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-umhqiUCQN9mZs9Xh4PMlCQ-1; Wed, 22 Mar 2023 05:10:30 -0400 Received: by mail-oi1-f177.google.com with SMTP id bm2so4210782oib.4 for ; Wed, 22 Mar 2023 02:10:30 -0700 (PDT) Received: from grind.. ([177.95.89.231]) by smtp.gmail.com with ESMTPSA id s3-20020a05680810c300b00383ef58c15bsm1994784ois.28.2023.03.22.02.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 02:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679476267; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UD8SHZYyvj4wJZVuXEGd3nphZW38JCCs7msgOd7Wx8c=; b=M7scZ8GPWOhWROIyIJWLrEK6gPVp0ZZPvY4OZ2774oSK7WXe6kd5Vm0sqVGnJPJk4AlE7H 3i75DMzrNTM08XREV44OIEvectevlPcMUgd9qEZYuRSce+etSHsMv2YncMK6dSnlPMT1TE G6UtgKk4w9PQTcuHOrq2Iq3tzvEi/oI= X-MC-Unique: KgZbGzfGNgWSoOHZ-9T9LQ-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: umhqiUCQN9mZs9Xh4PMlCQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679476229; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UD8SHZYyvj4wJZVuXEGd3nphZW38JCCs7msgOd7Wx8c=; b=PS4B2HlQofNWz7LA9ZhG3MYij16aaKjT3rwUhEyhPPSEBl/oKu5Z/9suWrd+DzTPbh 4fxroDa6asMY6IE5TWfAACLL8Ezmy6P3SyBY9NcRi+Cw160vj9GDL38wWCSaDARHLVUW daE1xEyo3NSu8cFY12FgH8tBY3EqVg/8gilph5OamNEUbOwLT5Ov1lbk8yDHk+KLGJk8 SIqfb6dL+QE+5UefCI+vMnTibYTbhiQ9amGsryyz2LY3WKwswTuYFFOOmclsiThEU1Wv 0oAzCHc7ljBvx7Evj9OelrTGmxnQBFaL+vzlCaYCSB70oO6by6leipH8f9YsyKBVeR0j RVyg== X-Gm-Message-State: AO0yUKWjvcJ29nUBP4KNhYwOSJrbGbrkmk/sssU+ieMhLazmA4EycHL7 HLbjsU68rXPNYDmOofZ4kbz6el63gCnI5c7E4D0= X-Google-Smtp-Source: AK7set8h28Mfl7QXvPnvog1nZq69A+wTkG0XHe0SMpZHn9j4Y/uo4ymBS+U7iCJ0L4zU6LzKZ09L1w== X-Received: by 2002:aca:a90d:0:b0:386:b205:b415 with SMTP id s13-20020acaa90d000000b00386b205b415mr1055032oie.27.1679476229478; Wed, 22 Mar 2023 02:10:29 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 2/4] qemu: handle bios 'none' case in qemuFirmwareFillDomain() Date: Wed, 22 Mar 2023 06:10:19 -0300 Message-Id: <20230322091021.186927-3-dbarboza@ventanamicro.com> In-Reply-To: <20230322091021.186927-1-dbarboza@ventanamicro.com> References: <20230322091021.186927-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dbarboza@ventanamicro.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: ventanamicro.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679476270306100001 Content-Type: text/plain; charset="utf-8"; x-default="true" All the code present in qemuFirmwareFillDomain() assumes that loader->path is always filled if using manual firmware selection. In the newly added "" case, i.e. without using firmware autoselection, qemuFirmwareFillDomain() will call qemuFirmwareFillDomainModern(), which in turn will fetch the number of firmwares in the driver via qemuFirmwareFetchParsedConfigs(). If any firmware is found, qemuFirmwareFillDomainModern() will call qemuFirmwareMatchDomain(), and we'll SIGSEV in: STRNEQ(loader->path, fw->mapping.data.flash.executable.filename)) { Because we never checked if loader->path !=3D NULL ever since the start of qemuFirmwareFillDomain(), 2 callers before. This doesn't happen in the field because, at this moment, there is no RISC-V firmwares set in the live driver. But the test driver from qemuxml2argvdata will populate the list with some firmwares, triggering the call to qemuFirmwareMatchDomain() that causes the seg fault. We'll hit this SIGSEV when adding a xml2xargv test that uses loader type=3D'none'. One fix is to use STRNEQ_NULLABLE() in the forementioned line, , but doing that doesn't fix the loader->path !=3D NULL assumption that we're making in qemuFirmwareFillDomain(). Let's instead exit early in that function if we're dealing with the loader type=3D'none' scenario we're now supporting: no firmware autoselection, loader->type =3D=3D none, loader->path =3D=3D NULL. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_firmware.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 9de4166772..8541a57bf6 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1616,6 +1616,16 @@ qemuFirmwareFillDomain(virQEMUDriver *driver, return -1; } =20 + /* If we're not autoselecting a firmware, and we have a loader + * element, and loader type is 'none', and we don't have a + * loader->path, consider that the user wants to explictly + * disable the firmware selection in QEMU (-bios none). */ + if (!autoSelection && loader && + loader->type =3D=3D VIR_DOMAIN_LOADER_TYPE_NONE && + !loader->path) { + return 0; + } + /* If firmware autoselection is disabled and the loader is a ROM * instead of a PFLASH device, then we're using BIOS and we don't * need any information at all */ --=20 2.39.2 From nobody Mon Feb 9 15:26:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679476245; cv=none; d=zohomail.com; s=zohoarc; b=ZXj2lcH15vGyZHrEeDaYXNHnLFBORKSFORhDJASRaEFf0L0xIQILPCgaZFLeIW5h2SuvAS9J8qBWubqjbdrJWQC8m5TwX7o7VZY1iTdGAW2XHB53LwNXFosNap2oyTKBdo8j41brPIg5whbCq3Wq3FaEaEiaK1C3GDQm0YxXk9I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679476245; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8F+ZCZD5zxA4FSuVyF3nivCoENPr40cueMDrNmfSjX8=; b=aXZNTtwpNKAcK83VTRxZSCkGGx+sIfpQ/8caa3MboEhcdF+DbEpoz6WCVh08utm0g4BKkCkLGe4YC2k1yFQ7ihE+MSmo1pFrdvOA6HESxKk2q4zem4cTkDAtGBWm3QGcY9Lk7El9VBn96mkdRSG6auxx2y6YzJk9fbNN7sJ38+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679476245007964.838989535864; Wed, 22 Mar 2023 02:10:45 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-130-SwwFCvFWP6Ce1efmBva1kQ-1; Wed, 22 Mar 2023 05:10:39 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CC151800B23; Wed, 22 Mar 2023 09:10:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B8A48463E03; Wed, 22 Mar 2023 09:10:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 718CF19465BB; Wed, 22 Mar 2023 09:10:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 90D3219465A2 for ; Wed, 22 Mar 2023 09:10:36 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 851F7483EC4; Wed, 22 Mar 2023 09:10:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D9BD42C827 for ; Wed, 22 Mar 2023 09:10:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FCC0858297 for ; Wed, 22 Mar 2023 09:10:36 +0000 (UTC) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-4S6pznyGPO6jWyx0DpAtQA-2; Wed, 22 Mar 2023 05:10:32 -0400 Received: by mail-oi1-f176.google.com with SMTP id y184so13106732oiy.8 for ; Wed, 22 Mar 2023 02:10:31 -0700 (PDT) Received: from grind.. ([177.95.89.231]) by smtp.gmail.com with ESMTPSA id s3-20020a05680810c300b00383ef58c15bsm1994784ois.28.2023.03.22.02.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 02:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679476244; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8F+ZCZD5zxA4FSuVyF3nivCoENPr40cueMDrNmfSjX8=; b=Nj4jQonQqznTMjUcpO0s6PrN8vZRjcUBLrRv3zBznul2XxNvoQDhP2i7UNGqd5dCizYxHB nyDvTYcPW6i/hK7fsI+8Hmk3jEI6Eh4MFOqoHh3LbCwxKmaP8gTBOt78l1uIqKVc/Y7NkW E0Dj7BDT1VtnGbCToVyqsAyD6OCM668= X-MC-Unique: SwwFCvFWP6Ce1efmBva1kQ-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 4S6pznyGPO6jWyx0DpAtQA-2 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679476231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8F+ZCZD5zxA4FSuVyF3nivCoENPr40cueMDrNmfSjX8=; b=yAVlgJhxC3juuUekDoj7IgSwoxizi8z0UyQoL26L3/YGicdbOfd/6qjZhcwk5ggeet LwtmXleUZ6ISjPY1GVV82l/TYAflvc7+OTqlstBqf40STPzUTAj2IlrcnZWQKl0A2KYU 8ZwaCO9lCyr7Y5qcQwl/f7mxiyubHQiBMc2X+QyMCVqko7E83FPyOo4KjoZafFJnr+6V AozbvlSearWf4r39bJWro5sMHUnufzyDRWLwjgdF8rCUv2JsiQYCFnqzBc4SLfc78q0G 2H7c0uxmLiOpTUFlHTj0WCTOBpm6MOSfLycFmhcq0h9IFmZWnvx/R8fdpHet40h6waAb RcqA== X-Gm-Message-State: AO0yUKUxyVQz47TddtQNFk8+88Ewj4lDjh3twOhXmR1yZv+n6QQcvXKA sHt9Braa/ms1Nsc5/fTXfTF9wFv5QK122SmoCbY= X-Google-Smtp-Source: AK7set/Jldxf/dXHH381zyyvwJSh8Xqz6j6nRcop2o2GQ7nt00G8ad3yyr4y2J0zy0LLxDK6jYaJKA== X-Received: by 2002:a05:6808:8e8:b0:387:6bb:2d8d with SMTP id d8-20020a05680808e800b0038706bb2d8dmr952062oic.12.1679476231341; Wed, 22 Mar 2023 02:10:31 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 3/4] qemu, tests: add -bios none command line Date: Wed, 22 Mar 2023 06:10:20 -0300 Message-Id: <20230322091021.186927-4-dbarboza@ventanamicro.com> In-Reply-To: <20230322091021.186927-1-dbarboza@ventanamicro.com> References: <20230322091021.186927-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dbarboza@ventanamicro.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: ventanamicro.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679476246188100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Also add a qemuxml2argvtest to ensure that we're good. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_command.c | 6 ++++ .../firmware-bios-none.riscv64-latest.args | 31 +++++++++++++++++++ tests/qemuxml2argvdata/firmware-bios-none.xml | 18 +++++++++++ tests/qemuxml2argvtest.c | 2 ++ 4 files changed, 57 insertions(+) create mode 100644 tests/qemuxml2argvdata/firmware-bios-none.riscv64-lates= t.args create mode 100644 tests/qemuxml2argvdata/firmware-bios-none.xml diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 7e75354902..97944dad55 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9366,6 +9366,12 @@ qemuBuildDomainLoaderCommandLine(virCommand *cmd, break; =20 case VIR_DOMAIN_LOADER_TYPE_NONE: + if (!loader->path) { + virCommandAddArg(cmd, "-bios"); + virCommandAddArg(cmd, "none"); + } + break; + case VIR_DOMAIN_LOADER_TYPE_LAST: /* nada */ break; diff --git a/tests/qemuxml2argvdata/firmware-bios-none.riscv64-latest.args = b/tests/qemuxml2argvdata/firmware-bios-none.riscv64-latest.args new file mode 100644 index 0000000000..71efe0361e --- /dev/null +++ b/tests/qemuxml2argvdata/firmware-bios-none.riscv64-latest.args @@ -0,0 +1,31 @@ +LC_ALL=3DC \ +PATH=3D/bin \ +HOME=3D/var/lib/libvirt/qemu/domain--1-guest \ +USER=3Dtest \ +LOGNAME=3Dtest \ +XDG_DATA_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.local/share \ +XDG_CACHE_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.cache \ +XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-guest/.config \ +/usr/bin/qemu-system-riscv64 \ +-name guest=3Dguest,debug-threads=3Don \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-guest/master-key.aes"}' \ +-machine virt,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Driscv_virt_= board.ram \ +-accel tcg \ +-bios none \ +-m 1024 \ +-object '{"qom-type":"memory-backend-ram","id":"riscv_virt_board.ram","siz= e":1073741824}' \ +-overcommit mem-lock=3Doff \ +-smp 1,sockets=3D1,cores=3D1,threads=3D1 \ +-uuid 63840878-0deb-4095-97e6-fc444d9bc9fa \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=3Dcharmonitor,fd=3D1729,server=3Don,wait=3Doff \ +-mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ +-rtc base=3Dutc \ +-no-shutdown \ +-boot strict=3Don \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=3Ddeny,elevateprivileges=3Ddeny,spawn=3Ddeny,resource= control=3Ddeny \ +-msg timestamp=3Don diff --git a/tests/qemuxml2argvdata/firmware-bios-none.xml b/tests/qemuxml2= argvdata/firmware-bios-none.xml new file mode 100644 index 0000000000..b8604e6b8a --- /dev/null +++ b/tests/qemuxml2argvdata/firmware-bios-none.xml @@ -0,0 +1,18 @@ + + guest + 63840878-0deb-4095-97e6-fc444d9bc9fa + 1048576 + 1 + + hvm + + + + + + + /usr/bin/qemu-system-riscv64 + + + + diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 293aea60d5..660d3ffca5 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1135,6 +1135,8 @@ mymain(void) DO_TEST_CAPS_ARCH_LATEST("firmware-auto-efi-format-loader-raw", "aarch= 64"); DO_TEST_CAPS_LATEST_PARSE_ERROR("firmware-auto-efi-format-mismatch"); =20 + DO_TEST_CAPS_ARCH_LATEST("firmware-bios-none", "riscv64"); + DO_TEST_NOCAPS("clock-utc"); DO_TEST_NOCAPS("clock-localtime"); DO_TEST_NOCAPS("clock-localtime-basis-localtime"); --=20 2.39.2 From nobody Mon Feb 9 15:26:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679476265; cv=none; d=zohomail.com; s=zohoarc; b=i0IvJ0uAxnrUfw4jN+d+GdgTh2YuHPF8Gezt6bft1AIL/GtCDg+L61/HKqfvXIHAXeFyOzDo+aOtHOysmOI9yC1JHRaw/BjTiUd17OCUZqmOWgqqWfLrgUS30j48bQLTRnfL5UxVPiQBYjUhZn4yGM6qGemfiSSUBqfL1gBTeOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679476265; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fMrdCbPYp3Xs7JOSPwZGjQYPo5wFvWkUzpA1EcLJf+8=; b=iHO0oXGTYJ7u0qGe4ypf1PoHKAT9TLQlraOfqBDR5c7xhQfi1pXeAlhyZUKk506wnjX1PIJCHYma9nE5ZbDstYfQPakNsI51bm7lR4l/jmWCg1x3Yw/XOLNgYvH6NWN6CST38sPxfRprg35MGnoxkWHWZpm4v49b1GBdPT985Qw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1679476265833119.73854528270931; Wed, 22 Mar 2023 02:11:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-211-p3cSNk1OPp2Gp6INF_l8eA-1; Wed, 22 Mar 2023 05:10:46 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E85EB803525; Wed, 22 Mar 2023 09:10:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95ACB463E03; Wed, 22 Mar 2023 09:10:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EB8511946A6E; Wed, 22 Mar 2023 09:10:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2F83519465A2 for ; Wed, 22 Mar 2023 09:10:36 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 21ED91410F1E; Wed, 22 Mar 2023 09:10:36 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A5231410F1C for ; Wed, 22 Mar 2023 09:10:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ECF7129A9CAC for ; Wed, 22 Mar 2023 09:10:35 +0000 (UTC) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-QkiArakJOI6Ccmboozxh1Q-1; Wed, 22 Mar 2023 05:10:34 -0400 Received: by mail-oi1-f171.google.com with SMTP id bo10so13104945oib.11 for ; Wed, 22 Mar 2023 02:10:33 -0700 (PDT) Received: from grind.. ([177.95.89.231]) by smtp.gmail.com with ESMTPSA id s3-20020a05680810c300b00383ef58c15bsm1994784ois.28.2023.03.22.02.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 02:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679476264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fMrdCbPYp3Xs7JOSPwZGjQYPo5wFvWkUzpA1EcLJf+8=; b=WQ1ReLapxvDuCtwB6sTJR8Ak6Bwg0w3V2/Fo0+NYm6uZFlijXprTkRvqgYidzg7VhkDHm0 KwOwAsBzVaRT+3E5t3sg0zlME0NRtoaBvpPEtB76fmf9/V4Psj7uaefNdOwV8J2zIB2b7C SpLmeXRkrjA/1v9HooYhTuzx7OLvRGk= X-MC-Unique: p3cSNk1OPp2Gp6INF_l8eA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: QkiArakJOI6Ccmboozxh1Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679476233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fMrdCbPYp3Xs7JOSPwZGjQYPo5wFvWkUzpA1EcLJf+8=; b=zkzw58m05ZOAqgZmWov6xVq3TTKk1fUx9XnaCMMo2wEeYglu4Ta1RhvLLyxAzo3jGM yUP8j5DWcAknBsyw3O1D/kB5eVl8xV7nD9ti/KDJwOzsXLn7KVHhPUL4t2wjejbxDcTE mQT+U8Xlaxg6163WFv+mujgaZwA1AJNMLIftk+RmyWVgogi4I9PIPTa4QHPxs4Md3nhu lQXMV/xZD0xgSI4pBCO5ILFCAhlhGT7VifRGbzy4EBNt4TcSVfvEj7d+HvJ3uCvt6KcG B+tcbPlKbtNj12p8IF0+OXX0G3UL1ujYVPmGMuL89uxranLUHM866tgh6ATDMOEeMvFc G/BA== X-Gm-Message-State: AO0yUKV9T6pHv617SVwbkHWYvxeuMsjPIwe6ut9+Alyz4zQiXiu4ngQg R3bE2+pfvjC6SJxCMa+fnu4oDRiakh+Mhr+OA2I= X-Google-Smtp-Source: AK7set+HWuBMdSUHAqwRAiEqZXOasLPFgJFlZ/i1UkYkDJuU8pLkjjsqp0vJ7UH4/c7C9OXF1FKeuA== X-Received: by 2002:aca:1201:0:b0:383:fa46:af5a with SMTP id 1-20020aca1201000000b00383fa46af5amr1082885ois.24.1679476232931; Wed, 22 Mar 2023 02:10:32 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 4/4] docs: Document loader 'none' attribute Date: Wed, 22 Mar 2023 06:10:21 -0300 Message-Id: <20230322091021.186927-5-dbarboza@ventanamicro.com> In-Reply-To: <20230322091021.186927-1-dbarboza@ventanamicro.com> References: <20230322091021.186927-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dbarboza@ventanamicro.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679476266271100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Daniel Henrique Barboza --- docs/formatdomain.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 27f83e254d..3529c7a9c5 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -263,6 +263,13 @@ harddisk, cdrom, network) determining where to obtain/= find the boot image. specific format. Supported values are ``raw`` and ``qcow2``. :since:`Since 9.2.0 (QEMU only)` =20 + When firmware autoselection is not enabled, marking the ``type`` attrib= ute + as ``none`` without any file path will set the QEMU BIOS file path as + ``none``. This is used by architectures that will always load the defau= lt + BIOS image otherwise, making them unable to start the domain when using + a guest kernel that overwrites the memory the default BIOS image uses. + :since:`Since 9.3.0 (QEMU only)` + ``nvram`` Some UEFI firmwares may want to use a non-volatile memory to store some variables. In the host, this is represented as a file and the absolute = path --=20 2.39.2