From nobody Fri Oct 18 08:39:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679081423; cv=none; d=zohomail.com; s=zohoarc; b=SUX08v9s2J+Lzh1p+P8c2ghE/pCMvMKlWLTBCsNKE5+1UAPsPkn8jn/VInh/uBj1UpQJ2Cncqasn4Rd3/K4UpKQAJGc+6KLWoVLZ14ab8Pcrc3uhNMrbUjwqP0MSVPsgdO6UMyVP38ym0r6G1ZXX0mMpsJ0YnZpGhoVMH1ROKC8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679081423; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JMfz2oRQX+xI5dtAXPWALRb+Tw7Rm3vh54ptjGaBuSQ=; b=cr+ANVnFsz5TTXDfcFisYcTbdPsVKS9FIIw9RaOFW+q9NQr3Yf2JYhoaYNME/jlDKfLmddb+5yrUs9HnRRTa8j4EjicwNmt7iMC9h+VRcvMIwv7vOd0whgqKWv2z0H1+cnO69+5ct8Ov6BBGN8PZglV+lM3lNY5MmfyoQqrNzIY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679081423745492.50202848633444; Fri, 17 Mar 2023 12:30:23 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610-EclxEUK1NXuEdkMNI4BUOA-1; Fri, 17 Mar 2023 15:28:16 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D830C18A647D; Fri, 17 Mar 2023 19:28:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3882C16025; Fri, 17 Mar 2023 19:28:10 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 65F511946A4B; Fri, 17 Mar 2023 19:28:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 37E051946A74 for ; Fri, 17 Mar 2023 19:28:04 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 2273B40C6E68; Fri, 17 Mar 2023 19:27:59 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (unknown [10.45.226.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAEA340C6E67 for ; Fri, 17 Mar 2023 19:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679081422; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JMfz2oRQX+xI5dtAXPWALRb+Tw7Rm3vh54ptjGaBuSQ=; b=O09zdvXphphQs1YReuQvhfKIOU9YAef+J5DawczIXuQs1uEHsUEQ4AKRn88ghxJTmOiQTg v4zKwJgs3k3DlwrPkAYrxAP0SZSly/3zfNcA4aWlcFR1S1qqZebdOD5a1V2Si6nmTeVGhc taEC5CO1vwLw8ppdLGr6YVpb4l5r4Yk= X-MC-Unique: EclxEUK1NXuEdkMNI4BUOA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 13/15] conf: Don't explicitly set the secure-boot feature Date: Fri, 17 Mar 2023 20:27:45 +0100 Message-Id: <20230317192747.1311223-14-abologna@redhat.com> In-Reply-To: <20230317192747.1311223-1-abologna@redhat.com> References: <20230317192747.1311223-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679081425403100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Now that we're adding information obtained from the firmware descriptor to the domain XML, this will happen automatically whenever a firmware that has the enrolled-keys feature ends up being selected. Signed-off-by: Andrea Bolognani --- src/conf/domain_postparse.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index 22eb603b3b..79862a72cd 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -101,12 +101,6 @@ virDomainDefPostParseOs(virDomainDef *def) _("firmware feature 'enrolled-keys' cannot be e= nabled when firmware feature 'secure-boot' is disabled")); return -1; } - - /* For all non-broken firmware builds, enrolled-keys implies - * secure-boot, and having the Secure Boot keys in the NVRAM file - * when the firmware doesn't support the Secure Boot feature doesn= 't - * make sense anyway. Reflect this fact explicitly in the XML */ - def->os.firmwareFeatures[VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_SECURE= _BOOT] =3D VIR_TRISTATE_BOOL_YES; } =20 if (!def->os.loader) --=20 2.39.2