[libvirt PATCH] manpages: fix secret injection example for SEV

Daniel P. Berrangé posted 1 patch 1 year ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230316085807.451381-1-berrange@redhat.com
docs/manpages/virt-qemu-sev-validate.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[libvirt PATCH] manpages: fix secret injection example for SEV
Posted by Daniel P. Berrangé 1 year ago
The --disk-password argument was present in early impls of the patch but
replaced by the more generic --inject-secret argument.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 docs/manpages/virt-qemu-sev-validate.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/manpages/virt-qemu-sev-validate.rst b/docs/manpages/virt-qemu-sev-validate.rst
index b1392e0a50..617ef0a57e 100644
--- a/docs/manpages/virt-qemu-sev-validate.rst
+++ b/docs/manpages/virt-qemu-sev-validate.rst
@@ -316,7 +316,7 @@ inject a disk password on success:
        --api-minor 24 \
        --build-id 13 \
        --policy 3 \
-       --disk-password passwd.txt \
+       --inject-secret 736869e5-84f0-4973-92ec-06879ce3da0b:passwd.txt \
        --secret-header secret-header.b64 \
        --secret-payload secret-payload.b64
 
@@ -393,7 +393,7 @@ inject a disk password on success:
        --firmware OVMF.sev.fd \
        --tk this-guest-tk.bin \
        --domain fedora34x86_64 \
-       --disk-password passwd.txt
+       --inject-secret 736869e5-84f0-4973-92ec-06879ce3da0b:passwd.txt
 
 Fetch from local libvirt
 ------------------------
@@ -454,7 +454,7 @@ inject a disk password on success:
        --insecure \
        --tk this-guest-tk.bin \
        --domain fedora34x86_64 \
-       --disk-password passwd.txt
+       --inject-secret 736869e5-84f0-4973-92ec-06879ce3da0b:passwd.txt
 
 COMMON MISTAKES CHECKLIST
 =========================
-- 
2.39.2

Re: [libvirt PATCH] manpages: fix secret injection example for SEV
Posted by Ján Tomko 1 year ago
On a Thursday in 2023, Daniel P. Berrangé wrote:
>The --disk-password argument was present in early impls of the patch but
>replaced by the more generic --inject-secret argument.
>
>Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>---
> docs/manpages/virt-qemu-sev-validate.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Re: [libvirt PATCH] manpages: fix secret injection example for SEV
Posted by Peter Krempa 1 year ago
On Thu, Mar 16, 2023 at 08:58:07 +0000, Daniel P. Berrangé wrote:
> The --disk-password argument was present in early impls of the patch but
> replaced by the more generic --inject-secret argument.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  docs/manpages/virt-qemu-sev-validate.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>